Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 3/5] x86/mce: Use mca_msr_reg() in prepare_msrs()
To:     Borislav Petkov <bp@alien8.de>
Cc:     Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        x86@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>, yazen.ghannam@amd.com
References: <20211019233641.140275-1-Smita.KoralahalliChannabasappa@amd.com>
 <20211019233641.140275-4-Smita.KoralahalliChannabasappa@amd.com>
 <YXk6z9xWvS4B7eRP@zn.tnic> <f5287d1d-bb2b-bb9b-1b33-f6692eaeb566@amd.com>
 <YXplCF5ccfbl+dGg@zn.tnic>
From:   "Koralahalli Channabasappa, Smita" <skoralah@amd.com>
Message-ID: <87bee2b2-4e62-b159-75fb-22f9abb5ac68@amd.com>
Date:   Mon, 1 Nov 2021 13:51:38 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.1
In-Reply-To: <YXplCF5ccfbl+dGg@zn.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amhtR1ZNUFFHSXZ6cUZlSUFkZk9oa25aT0tyd2NOZnF5YytHNzNRZURGV2xV?=
 =?utf-8?B?TlZpcm9KUzl0UEh6RTQ2eGkxMHBINGNITlc5dVlGTDBGR0dHQkhWYTZYeWR5?=
 =?utf-8?B?SnQxR3JaWkJjMi90d0FUSHRsZjVWN2padm5wRzV3SXBlVHR6cVhNV1VodGdp?=
 =?utf-8?B?QUdDS0tsdENXbHR5WnlvZnBCdUZxMk84VmJzLzZ6VldPaHJER2REM2p4Wk5W?=
 =?utf-8?B?QjRNMGE5NjA2N1dOam5ZTFJZT0pBeHRVMzBjRzBnQ1R5cDRmS3g2dXZKeTlW?=
 =?utf-8?B?dFNVVW8wMEpIUG40ZFhVd3ZXY1BjWk9yL1NtbDZvUFFtVG5oK05lbUFHSTdZ?=
 =?utf-8?B?aWVSZ3NFVTlRTVJSMnJhQXFBek5sbDM0NkhZRzhLVnBRclVucFZJZ0c1RDZj?=
 =?utf-8?B?SGhIMjNxSzJzZGo1S1ljWnNXVVdmQ2YvWGlFR2I3L05CeGxlUkxIU29GNjQz?=
 =?utf-8?B?OUNQN1JvVGxJMmt2cXRuYUtIaXNNaDVhZUFlSHVUYTNRTGlNMzF4TjRWRlRj?=
 =?utf-8?B?Rmtoc0RXa280andJRFRUSE5RUVBMc0RtSFBFZ3JpYjl6WlNVS1Y3cDdvWkpl?=
 =?utf-8?B?ejdLNFpxOHcxTkZTNEQrRGRIald5UTMvVzV4WFN4eFR6Vk85eXVaV0E2dmZj?=
 =?utf-8?B?WUMrT203M3Mzd3ZuSE9xeGJRQnJsT1lEN0JNaVBzaDlJODdxamlYVGdXZmxz?=
 =?utf-8?B?NmovK0FHaSt0WkJ2UHpWY2d3dFRhTjJHbUh3ZndpUmZMOUl4NkpHcFhmdWx3?=
 =?utf-8?B?ajJsMzUyeUhUZTgyLzYxeVc0TENESnJlUmpLOFUxWU1vemZYZXVpdm50Q2V1?=
 =?utf-8?B?MXdNL29Zd216Q2dUTUd4RjZqT3A1ZWNZc09NUTdDeHROTyt4clRMcmpOdC9R?=
 =?utf-8?B?bHR5OGRqWW43UHpLOVFLZzlaY2V5N29qUzBGeVErY1FRTWtKSFpNc0JvWVpU?=
 =?utf-8?B?ZFYyRG1mL1Z6QTQ1WEM2SStJOVh4dGZYOEpwOThYSHUyR1NjNTBxYlZhZXdv?=
 =?utf-8?B?eUlPV1d2MUllR0l4NHNBWkkyQS9rSmpCdnFmbjlZZ0tGRmErMWloWDJrR3Fi?=
 =?utf-8?B?cmJHWWF5eGpiY1VnY3VYcS8zZXJTNHk0Nm9IbkFNZTR2MGcvMzV2bnU0WmtI?=
 =?utf-8?B?bXpxT1Zkb0w2MVJzVVhDaDNQdEgxcU1VOFo1ZmpxTGlSMXBEVUtramY5WWNm?=
 =?utf-8?B?emU1aWgxSE9uZ1A1bzFkSWcyNVJpQ3pwT29xZXl6dGdxMFFiS3NkazJrQkhv?=
 =?utf-8?B?RlFKb09CZjZSUXF1TGxiTUlzQnF5UDJ4YXlVbysrSTRGUHE3K0M1Njh2WW5M?=
 =?utf-8?B?L3R0ckhVdHgwRWlvUHc3VERqZ3MvYUNvQWQ0akNJZVRpbmJKWVVHcG5uUjF2?=
 =?utf-8?B?YVZqUmtoejFiczdTRWdac1NrdlVCVDljS3pja0ZyTG1GVUdmUy9MTHB3d0Vh?=
 =?utf-8?B?UkNwUTQ4U3ozWFgwbklvMjh3ZmJVMzZLcHZUejRpYjZQM0MwdGxPYWJoR1JL?=
 =?utf-8?B?TjJKQzcrWUdpL1VKekl1V25WVDFxTW52cGZlVXRmcFdlOC9DdHBkN080NlhD?=
 =?utf-8?B?aUtCY3pWWTRzNHVZaWYya3NtNHEvRmo0WGVJMzJBb0Jvc3BIRTNWclpyek9H?=
 =?utf-8?B?LzJ5RU4xaW4xdTZyWnpFLzNWQ1FFK1ZmeUl4cVB3Tmg1VnhreUp1Ukh0WXpE?=
 =?utf-8?B?RDFqaWVNZTQzTmMybEJSaDBHZXEyL3NXU0djNnM1VkM2bkpzdWdKak0vYUtn?=
 =?utf-8?B?SzJMTG5OdzNMditZY1lsZUxmRzVicUVYVHNCVlkyd05OYTFZcW5sc0FiSVZV?=
 =?utf-8?B?QnE1T0h1TFM1SWFTUFJkc3cvSmxqSUthWjRDY0srV0grcW53NkhHVUZQeVI3?=
 =?utf-8?B?UnpJWUhRdDQwbTBpdGVzdndES2Fvdm9DYnF5eUhGSk56ZW05blpzN2Vzck9w?=
 =?utf-8?B?VFYyLzMvVUdGOWhnRlhGM1h4MkMyYUlpN3gxUmVBTm01ampnYzl1dGl4d3Nn?=
 =?utf-8?B?dnpTb3J6ZmhSNnUxVStQaTE4MGtGRDk4dEFic3BJMmE0YVVtWlBtSXh4N0pF?=
 =?utf-8?B?UHBscEtzdDh6bmFRdUN0WWU2TGpMVGhXRUM1V1FpY2hXVG1iZWh6eWRwZzRY?=
 =?utf-8?B?eGpINkdFN0FHeW5aYXJXMnFOcE11Q3ZkdjlCV1VNcFZCSU9XM2dxZFZZTTcw?=
 =?utf-8?B?Q2F2d2x6VU0xc0dCN2JQVXF5MTh1WkhqYUY3aHNaQUdRMlFpOGQybHNva0Ex?=
 =?utf-8?Q?gyxh+D3R/0nlFGFfs0jfwb5yIh5F6o4F13GOy+3njE=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 538bc358-275f-4a95-62e3-08d99d68a462
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 18:51:41.3034
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r2Aqikxi5ovftKRdqC+gZiWol3kjFB7VDSHB/7mgkT2722xp/jcYIJVAIz2LNbSbPVeyqtYurWX/iUsKHn0M3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3493
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/28/21 3:53 AM, Borislav Petkov wrote:

> On Wed, Oct 27, 2021 at 03:19:51PM -0500, Koralahalli Channabasappa, Smita wrote:
>> Multiple initialization here I mean: Initializing the MCA registers twice.
>> Prior to mca_msr_reg() replacement, the MCA registers were initialized
>> separately for SMCA and legacy processors. However, this is not required
>> after replacing with mca_msr_reg() as it does the job of returning the
>> proper MSR addresses.
> You mean, there was a simple if-else statement
>
> 	if (SMCA)
>
> 		prepare MSRs
>
> 	else
>
> 		prepare MSRs for !SMCA
>
> which did the init for each type of system in one go.
>
> But frankly, your change doesn't make it more readable but less - you
> have a goto label now and another SMCA feature check at the end. Vs a
> simple if-else which is trivial to read.
>
> So I don't see any advantage in this change.

Okay. I will rework and remove this patch in my next series.

Thanks,

>