Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d6cd47b1-3b46-fc44-3a8d-b2444af527e6@linux.ibm.com>
Date:   Mon, 1 Nov 2021 20:30:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH -next] bonding: Fix a use-after-free problem when
 bond_sysfs_slave_add() failed
Content-Language: en-US
To:     Huang Guobin <huangguobin4@huawei.com>, j.vosburgh@gmail.com,
        vfalico@gmail.com, andy@greyhouse.net, davem@davemloft.net,
        kuba@kernel.org
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1635777273-46028-1-git-send-email-huangguobin4@huawei.com>
From:   Julian Wiedmann <jwi@linux.ibm.com>
In-Reply-To: <1635777273-46028-1-git-send-email-huangguobin4@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 01.11.21 15:34, Huang Guobin wrote:
> When I do fuzz test for bonding device interface, I got the following
> use-after-free Calltrace:
> 

[...]

> Fixes: 7afcaec49696 (bonding: use kobject_put instead of _del after kobject_add)
> Signed-off-by: Huang Guobin <huangguobin4@huawei.com>
> ---
>  drivers/net/bonding/bond_sysfs_slave.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/bonding/bond_sysfs_slave.c b/drivers/net/bonding/bond_sysfs_slave.c
> index fd07561..d1a5b3f 100644
> --- a/drivers/net/bonding/bond_sysfs_slave.c
> +++ b/drivers/net/bonding/bond_sysfs_slave.c
> @@ -137,18 +137,23 @@ static ssize_t slave_show(struct kobject *kobj,
>  
>  int bond_sysfs_slave_add(struct slave *slave)
>  {
> -	const struct slave_attribute **a;
> +	const struct slave_attribute **a, **b;
>  	int err;
>  
>  	for (a = slave_attrs; *a; ++a) {
>  		err = sysfs_create_file(&slave->kobj, &((*a)->attr));
>  		if (err) {
> -			kobject_put(&slave->kobj);
> -			return err;
> +			goto err_remove_file;
>  		}
>  	}
>  
>  	return 0;
> +
> +err_remove_file:
> +	for (b = slave_attrs; b < a; ++b)
> +		sysfs_remove_file(&slave->kobj, &((*b)->attr));
> +
> +	return err;
>  }
>  

This looks like a candidate for sysfs_create_files(), no?

>  void bond_sysfs_slave_del(struct slave *slave)
>