Date: Thu, 4 Jan 2007 19:02:23 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Avi Kivity <avi@qumranet.com>
Cc: Andrew Morton <akpm@osdl.org>, kvm-devel <kvm-devel@lists.sourceforge.net>,
       linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/33] KVM: MMU: Cache shadow page tables
Message-ID: <20070104180223.GA11460@elte.hu>
References: <459D21DD.5090506@qumranet.com> <20070104092226.91fa2dfe.akpm@osdl.org> <459D3C65.2090703@qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <459D3C65.2090703@qumranet.com>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1351
Lines: 34


* Avi Kivity <avi@qumranet.com> wrote:

> Andrew Morton wrote:
> >Is this intended for 2.6.20, or would you prefer that we release what we
> >have now and hold this off for 2.6.21?
> >  
> 
> Even though these patches are potentially destabilazing, I'd like them 
> (and a few other patches) to go into 2.6.20:
> 
> - kvm did not exist in 2.6.19, hence we cannot regress from that
> - this patchset is the difference between a working proof of concept and 
> a generally usable system
> - from my testing, it's quite stable

seconded - i have tested the new MMU changes quite extensively and they 
are converging nicely. It brings down context-switch costs by a factor 
of 10 and more, even for microbenchmarks: instead of throwing away the 
full shadow pagetable hiearchy we have worked so hard to construct this 
patchset allows the intelligent caching of shadow pagetables. The effect 
is human-visible as well - the system got visibly snappier.

(I'd increase the shadow cache pool from the current 256 pages to at 
least 1024 pages, but that's a detail.)

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/