Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3519893pxb; Mon, 1 Nov 2021 15:24:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCF1Cyj2LyLLNLkNEDIpblmbZZcvk22mZLogaNTGYE7WwP3wZjai8M5IaUxspPGep+mQtI X-Received: by 2002:a92:360c:: with SMTP id d12mr17852348ila.172.1635805493047; Mon, 01 Nov 2021 15:24:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635805493; cv=none; d=google.com; s=arc-20160816; b=E2XiVDxAq9Ir1dajQcR7zfQKa/aUW2fWul0h7+/eYuX5K2DaBj6hBZhdVWqKOTXCL0 ROBKfVUy3lLR8qYg7vwHoijXTMNMMt9m0Qcrm8GZkbm64oTFGMOKJszajSOK7b90r7SU DKHBmRbLHRYRJrjYTPc6eObdkPhHFjAp9jk7pxZxqJ6XOa34RwrPfj+Hpvm1AA//t0JI rjz09o5h7UJC3gu0BFQ0HH7UMkjDjN1NehAc1aUl0917Oek82fK/1zoYuPylRc7gwO87 gN9wDmIqW1S4FbboOcLpsv4lDgfJFrgHgauyEZ14yXWEqkiFNYu9Fih2FeSUOldHQuHU 2lBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DnYnqLqd12gaQARTKVAqqyWq5HzzIA2bkgQBVsVg4s0=; b=0tR4kqo98XMaIcjCoYcvpIFZoU12k9eN4C3nTqImY1RBwkYcREfbA9FwV1CHdjFVHZ BwNHfVLnuS5ld/z3ZezEVegMN+SnIQyFDxipU49794EqJZLpLrJTwBadTP9oRxAV84Mw 61wNF+RYAd8/iZGYH/sJL3L60OjBlQMyu6WH0yKCOOHRqeHejK+KqGQTKdpOxyg8gnkL G/M0t7me+JAIVvhkyxZpxDm9frorxYM7ROvSrJ6ht4ZwW8j37CrOjBpUWQ0Bf+PVKSYN VK1+T/2jUMfwKhTBG95B7WHwJz9q+8iTl/QvGsRnafj9xVusdUDXNgc7Dw1THn8hDuAJ MzWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20210112.gappssmtp.com header.s=20210112 header.b=gt6wFXhT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t7si18558368ils.113.2021.11.01.15.24.41; Mon, 01 Nov 2021 15:24:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20210112.gappssmtp.com header.s=20210112 header.b=gt6wFXhT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232283AbhKAWZo (ORCPT + 99 others); Mon, 1 Nov 2021 18:25:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230167AbhKAWZn (ORCPT ); Mon, 1 Nov 2021 18:25:43 -0400 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87268C061764 for ; Mon, 1 Nov 2021 15:23:09 -0700 (PDT) Received: by mail-qt1-x836.google.com with SMTP id v4so2845194qtw.8 for ; Mon, 01 Nov 2021 15:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DnYnqLqd12gaQARTKVAqqyWq5HzzIA2bkgQBVsVg4s0=; b=gt6wFXhTP2Om3mCyDlaPZAclh5WszLcpD8FoKutfVj8kgeF1LLfIUwzLFBUYIe1Zzb 1wZFR2yisz7vylQ/KZ2Ca9Df9MstkiyosiVMAmFpqNmIMQkvqBA+nLzzouUtMElvy+Eh Rbk0LDFkDyDxgzsMF1BjOwes+AihSB4ohirmWfuyQuEPhbNOYQo3ZZbJWFpSxD1bVbzT FS39TzcCWib50StejXPsjWz9cwjpT/8kr8xl1HOgo5uhKK4PDMfbwiLzgnBEMV/tMEiB 61A4v1ss0uZPfPNO5JdiHRX1eLDVszL+ITaYkQuWJonGx+1xIITEZQk7hszS792brO9q yfaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DnYnqLqd12gaQARTKVAqqyWq5HzzIA2bkgQBVsVg4s0=; b=ufiks/dMe4zyv4jGg7Z6gsKCYxuF4f4Eq+MzdBlO2qhth9/yc4tXJfpzP1lApWXNLf 13Bi55NRq1u2GAwGs+hNSKNBQs6pW0e1i6qLw8oiQhg0PEmZvQ4HQ0OF1NEdkiw4RpCy NVYYFgUJICDL6y67c9A1SGziyT45OI8SSrtTuhIB4cTeMhui/SjUql7BhEx8PoibFb1E 227MWED0avNJXOkJc7KmP9QxbVEFEhOeFzAX1NFgAONugXHWKqwX+rFJRu+XxlVzRnSe Bbh5f0mg4RB5PRCRj/OaBoCKmOjoU9AqGQmdy093iKvT/+g/w3r3aMNGNtJt0YOEJ/Ds b3BQ== X-Gm-Message-State: AOAM531LT7X1hQm5VIS9VuHDoXgPNRvvAo0T/UhZKCUWRQcUPwcORLze Cfv6rMeO0+vssIhaUqigKbbSwQ== X-Received: by 2002:a05:622a:105:: with SMTP id u5mr16022514qtw.163.1635805388070; Mon, 01 Nov 2021 15:23:08 -0700 (PDT) Received: from localhost (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id h3sm2063742qkn.73.2021.11.01.15.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 15:23:07 -0700 (PDT) Date: Mon, 1 Nov 2021 18:23:06 -0400 From: Josef Bacik To: Yu Kuai Cc: axboe@kernel.dk, linux-block@vger.kernel.org, nbd@other.debian.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH] nbd: error out if socket index doesn't match in nbd_handle_reply() Message-ID: References: <20211101092538.1155842-1-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211101092538.1155842-1-yukuai3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 01, 2021 at 05:25:38PM +0800, Yu Kuai wrote: > commit fcf3d633d8e1 ("nbd: check sock index in nbd_read_stat()") just > add error message when socket index doesn't match. Since the request > and reply must be transmitted over the same socket, it's ok to error > out in such situation. > > Signed-off-by: Yu Kuai Reviewed-by: Josef Bacik Thanks, Josef