Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <58e5ec6a-7b85-3935-f859-6670600ac6a2@gmail.com>
Date:   Mon, 1 Nov 2021 19:34:48 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT
 compatible
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>
Cc:     linux-imx@nxp.com, mturquette@baylibre.com, sboyd@kernel.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, ulf.hansson@linaro.org, aisheng.dong@nxp.com,
        stefan@agner.ch, linus.walleij@linaro.org,
        gregkh@linuxfoundation.org, arnd@arndb.de, olof@lixom.net,
        soc@kernel.org, linux@armlinux.org.uk, abel.vesa@nxp.com,
        adrian.hunter@intel.com, jirislaby@kernel.org,
        giulio.benetti@benettiengineering.com,
        nobuhiro1.iwamatsu@toshiba.co.jp, leonard.crestez@nxp.com,
        b20788@freescale.com, fugang.duan@nxp.com,
        linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-serial@vger.kernel.org
References: <20211024154027.1479261-1-Mr.Bossman075@gmail.com>
 <20211024154027.1479261-9-Mr.Bossman075@gmail.com>
 <YYBKh1KYrWTzm+5G@robh.at.kernel.org>
From:   Jesse Taube <mr.bossman075@gmail.com>
In-Reply-To: <YYBKh1KYrWTzm+5G@robh.at.kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/1/21 16:13, Rob Herring wrote:
> On Sun, Oct 24, 2021 at 11:40:22AM -0400, Jesse Taube wrote:
>> Add i.MXRT documentation for compatible string.
>>
>> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
>> index a90c971b4f1f..4b4340def2aa 100644
>> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
>> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
>> @@ -21,6 +21,7 @@ properties:
>>            - fsl,ls1028a-lpuart
>>            - fsl,imx7ulp-lpuart
>>            - fsl,imx8qm-lpuart
>> +          - fsl,imxrt-lpuart
> 
> Actually, 'rt' is not a single part is it? If the variations are same 
> die, but fused off then no need to distinguish. Otherwise, these should 
> be SoC specific.
> 
I don't exactly know what "but fused off" means I would assume
disconnected but on-die? The imxrtxxx is a series that has the same UART
controller across them. Should I add ACK?
> Same applies to other compatible strings.
> 
>>        - items:
>>            - const: fsl,imx8qxp-lpuart
>>            - const: fsl,imx7ulp-lpuart
>> -- 
>> 2.33.0
>>
>>