Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 09:56:31 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Jitao Shi <jitao.shi@mediatek.com>
Cc:     Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Xin Ji <xji@analogixsemi.com>,
        Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, ck.hu@mediatek.com,
        stonea168@163.com, huijuan.xie@mediatek.com,
        rex-bc.chen@mediatek.com, shuijing.li@mediatek.com
Subject: Re: [PATCH v7 3/3] drm/bridge: anx7625: config hs packets end
 aligned to avoid screen shift
Message-ID: <20211102015631.GA2248315@anxtwsw-Precision-3640-Tower>
References: <20210915223117.7857-1-jitao.shi@mediatek.com>
 <20210915223117.7857-4-jitao.shi@mediatek.com>
 <a16150b6b10dca4bf961b8e02b5e4d940b98468c.camel@mediatek.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a16150b6b10dca4bf961b8e02b5e4d940b98468c.camel@mediatek.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?geMzpC6mraU7wSYiD42sggvUjMv+ASiBzpMecxO11YvNiCgRcsr/KPV5RyjV?=
 =?us-ascii?Q?B1ky48JiDpF7ar4VdSuyCQgdbdouJDEJKC1+hQ3t83T/lEIzN1142TY/xDUp?=
 =?us-ascii?Q?Q79OhPYSOjOTMRGsHa9yiMCX/MGRWzljHDSUIOUpf8Tc8RNFTrdS6LqdvbQY?=
 =?us-ascii?Q?DT3oPdq/6ZkNYi3Ig4mljprVJx99M90gjwEWkeTxtRINS37HDSvxwnRhp1tW?=
 =?us-ascii?Q?XCHqaBQsSvxnxOzFOkqqLX4G+yChRaJIwqQVKtPnvz+bHCvnSKfjMWCGl9XY?=
 =?us-ascii?Q?Y57u8mgzV2zvg9L1O3sOiUo7AD6GdBpfuRrknIiRgAicJOo5KVStZZHS1gHk?=
 =?us-ascii?Q?QY9QRjkinZTAXB24n7MC5QJSJVi//f/eJxuZBZfrqIJ+ZhWEzEAixllb1gOZ?=
 =?us-ascii?Q?1F0hEjUNhvcWZE+WbNHVVACgez10lPvlIHO4zxtK4wxvRMfOLAh5pK3D5g89?=
 =?us-ascii?Q?KwIFVmRbwboqt4VutFkmQR8Z0eod4CeMh62dzQRFnhVk0CUS2ozadOle+unw?=
 =?us-ascii?Q?5ofGxyNSqHPznPHEXGJAVwi4KE/uOtvwRK15KivGsB2kE3LrcgMS+YqJvjTp?=
 =?us-ascii?Q?UZWDhN6r6dQNY29mdJ7tbFS/tVRyAnhX8rjkhXgPWshVFs/1rrHZNIEsPKtn?=
 =?us-ascii?Q?vcDQfIZJ5CswCmu6P+XaNoKGzOeXkGpKH0jPt581oIEb3j3Mg1mYt7dqkJGL?=
 =?us-ascii?Q?2PeZUt7xeW0nR3gAJnzeoSDD0EzQN7BR/8kgRtEpZlT4NDtqBUY82AwWzb7w?=
 =?us-ascii?Q?Ydrvf8fUG1IAitMhwwG2LCAt82yk9jDkkjkgfkazYYCoOY9vNyJlLygJ4M8l?=
 =?us-ascii?Q?FRq0v3Gsp/8NqMhWb5XN0H6va+iCGuYsrA8MKJIU9kZI3FcFMmWzaG9aap7D?=
 =?us-ascii?Q?cUCIBU0Dq7nNvoN2cFwshM47+BAILQs0s4/KvrCHaP7iDuF1x7rVnDD70LvK?=
 =?us-ascii?Q?Cx4XS7PJ+8RmEzg3ZaSZUxE950Nwd1i52BKHBBIRrcsqokmCeWgvq/99+4jn?=
 =?us-ascii?Q?4H4kRAHcmRBTvbmqTeWbTJYE4B4kFmsurXj2pCDNKpBhd92sM201Tt6vF73K?=
 =?us-ascii?Q?cLAPEHmL6wSVZhHVHOXfXlUnn906cdbExsfGNlkBx2hmYWTRGxVoV/sEoRjj?=
 =?us-ascii?Q?Vk+4CHu11pPp6DGNfUtXgKys2tUucgLCvWIXdysxyZ32YZFz80pc3lpStWrZ?=
 =?us-ascii?Q?6WW3mjEPhbjRXGPNk+/MVaCl+uDsusK0oTBipHP5/hpv3oY9GKfpxYoGEKjE?=
 =?us-ascii?Q?tAPVzFfj+nagUsdQqDs1rUq/VToYvYCmCwiurXaF5HftGAhCTMLbVP1BD+tH?=
 =?us-ascii?Q?BEAF9ZJhGcG6tCBKxnbioaGQ9xXLqbjflp+XFzMsrIszUCR1Ol/JckHui/zT?=
 =?us-ascii?Q?aQvdh1ybKbaZCYvv0GM/bx6PJLuGLtIVycSo5CF9xUWPNxjmi4unuynDWFCf?=
 =?us-ascii?Q?qLv9XQTeueFaqEzUeeBdg5U04rqo3XvNZ3Bw6Z4sQ3qSdW4x1Du3sRTdljGk?=
 =?us-ascii?Q?Tdj5yjzto4x7Hyzhj3Rcfz3VKGWfpAL0lWit+EPhaD/px7bJLSYSms0oEJrq?=
 =?us-ascii?Q?8HxNSlDtuwXcN5NVNv/XJRuYa0cLfgSOmxmhQQ2lGhSyYBPdEeyEjjx6GVNG?=
 =?us-ascii?Q?RGFnfhHeHkOJCcWmY1iviWI=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a136137-843a-4158-c76d-08d99da40223
X-MS-Exchange-CrossTenant-AuthSource: CH2PR04MB6741.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 01:56:39.1387
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C3Pw3hHGLQlgprdDqHxjw211SS9BUoMbpesBZXbTUbKoyYL5AnJ1vZjmUbFUYpyIDUR6F4jr72gylCYYXPRTbQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR04MB6569
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 01, 2021 at 11:16:15AM +0800, Jitao Shi wrote:
> Hi Xin,
> 
> Please help to review the changes in anx7625.c
> 
> On Thu, 2021-09-16 at 06:31 +0800, Jitao Shi wrote:
> > This device requires the packets on lanes aligned at the end to fix
> > screen shift or scroll.
> > 
> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> > ---
> >  drivers/gpu/drm/bridge/analogix/anx7625.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 14d73fb1dd15..d76fb63fa9f7 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -1327,6 +1327,7 @@ static int anx7625_attach_dsi(struct
> > anx7625_data *ctx)
> >  		MIPI_DSI_MODE_VIDEO_SYNC_PULSE	|
> >  		MIPI_DSI_MODE_NO_EOT_PACKET	|
> >  		MIPI_DSI_MODE_VIDEO_HSE;
> > +	dsi->hs_packet_end_aligned = true;

Looks good, it's OK for me.
Reviewed-by: Xin Ji <xji@analogixsemi.com>

> >  
> >  	if (mipi_dsi_attach(dsi) < 0) {
> >  		DRM_DEV_ERROR(dev, "fail to attach dsi to host.\n");