Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3729000pxb; Mon, 1 Nov 2021 19:50:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyg7RdBCZTtXDf2DfuKR6UFFb7jiUg1EoJkZS6KncztDzBq+9T54bMylcRq5dUB5Qh8BnDd X-Received: by 2002:a5e:890b:: with SMTP id k11mr24104985ioj.71.1635821411149; Mon, 01 Nov 2021 19:50:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635821411; cv=none; d=google.com; s=arc-20160816; b=MM3k+0Y+vw47QAQkWI8gLqbZdnSpfgdLjJGgK2ol3w6+mFuSeT976iRxmfYYvSV75J KSglvqCKdavvwC8NGPdHM/vhOk91q8OTibIWaRCQYYw/EdHa1RI95RZmX1ml505gOnik mifkhOApn1a+d4MhBpeVfCcvmQBaomcG1eJI7MkKtIxAVLF3W3Dg0861jLhz5oWT4Nps 6fgnEiSWy/86ZTtlXkud2TBI0Adxr9oZD19DxtjSChLhbD6FAxQ1nlB8hjywjs5mUe9h q8Ev2mZWf1C6MPqJRJS7jU68B5X/JJjz1Xz1a7Smhpkk6mWjhaIOpBakli+rm7y5dW2L vmHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=Z10f0b9m29mw9Dhex2eEycqWAJunqIetpImJNFWY83Q=; b=GPEZ6zzL2MliANbj4RzZmPmShAxcISQzzBwj9VO50Tz8Va1kdYxMI9xLdVE/Y8RzzI 3uL8nSDuuQ+CCgjbOSChqGvqBMvMcAadT7ujsjeJC5BRlQvb6o4I35QTnnvm4tSwmezG q79zUkmnPCszn8vggV1f/cvX2/2GmgyN7X3Irm4lD/2CKp+Q0qR0kf0cNO5j1MKlzOds mYT7aAuk5hO+VXStMmjO4AdCXTOZx0kJV6CoqqpCTnyQlh6DhDVgFx2dJTcs4r8t6eTY 6whYzOrPBI+u1K9OhXLDPRXcgVxWAj8pRoJdAZUjkGgF394grkepGdLufUL42XOyHadD p2pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n13si759202ili.16.2021.11.01.19.49.58; Mon, 01 Nov 2021 19:50:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230015AbhKBCux (ORCPT + 99 others); Mon, 1 Nov 2021 22:50:53 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:26220 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbhKBCux (ORCPT ); Mon, 1 Nov 2021 22:50:53 -0400 Received: from dggeme755-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4HjvS66vqGzSh0v; Tue, 2 Nov 2021 10:46:46 +0800 (CST) Received: from [10.67.110.136] (10.67.110.136) by dggeme755-chm.china.huawei.com (10.3.19.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.15; Tue, 2 Nov 2021 10:48:14 +0800 Subject: Re: [PATCH] drm: Grab reference of connector before return connector from sun4i_tcon_get_connector To: Jani Nikula , , , , , CC: , , , References: <20211101062906.231518-1-heying24@huawei.com> <87cznkdo6p.fsf@intel.com> From: He Ying Message-ID: <33e01d45-c9f9-0e8c-6871-868ecd198368@huawei.com> Date: Tue, 2 Nov 2021 10:48:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87cznkdo6p.fsf@intel.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.136] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggeme755-chm.china.huawei.com (10.3.19.101) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2021/11/1 21:02, Jani Nikula ะด??: > On Mon, 01 Nov 2021, He Ying wrote: >> From the comments of drm_for_each_connector_iter(), we know >> that "connector is only valid within the list body, if you >> want to use connector after calling drm_connector_list_iter_end() >> then you need to grab your own reference first using >> drm_connector_get()". So fix the wrong use of connector >> according to the comments and then call drm_connector_put() >> after using connector finishes. >> >> Signed-off-by: He Ying > Please use "drm/sun4i:" subject prefix for sun4i patches. OK. I'll send a V2 later. By the way, may I have your suggestions about this patch's content.