Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 06:54:15 +0000
From:   Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Linuxarm <linuxarm@huawei.com>, mauro.chehab@huawei.com,
        Aditya Srivastava <yashsri421@gmail.com>,
        Alex Dewar <alex.dewar90@gmail.com>,
        Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Baokun Li <libaokun1@huawei.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Kaixu Xia <kaixuxia@tencent.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        Tsuchiya Yuto <kitakar@gmail.com>,
        Yang Li <abaci-bugfix@linux.alibaba.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/2] media: atomisp: better describe get_frame_info
 issues
Message-ID: <20211102065415.4850a80b@sal.lan>
In-Reply-To: <CAHp75VdaTEOaGhA43O1==Deg_0Ej_ZzOp8AX5NKZB5zegN42Pg@mail.gmail.com>
References: <750e50daa3ed65a7eb060cb0eb5cfc60dc9386be.1635497370.git.mchehab+huawei@kernel.org>
        <CAHp75VdaTEOaGhA43O1==Deg_0Ej_ZzOp8AX5NKZB5zegN42Pg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Em Fri, 29 Oct 2021 12:01:57 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> escreveu:

> > +       switch (type) {
> > +       case ATOMISP_CSS_VF_FRAME:
> > +               *info = p_info.vf_output_info[0];
> > +               dev_dbg(isp->dev, "getting vf frame info.\n");
> > +               break;
> > +       case ATOMISP_CSS_SECOND_VF_FRAME:
> > +               *info = p_info.vf_output_info[1];
> > +               dev_dbg(isp->dev, "getting second vf frame info.\n");
> > +               break;
> > +       case ATOMISP_CSS_OUTPUT_FRAME:
> > +               *info = p_info.output_info[0];
> > +               dev_dbg(isp->dev, "getting main frame info.\n");
> > +               break;
> > +       case ATOMISP_CSS_SECOND_OUTPUT_FRAME:
> > +               *info = p_info.output_info[1];
> > +               dev_dbg(isp->dev, "getting second main frame info.\n");
> > +               break;
> > +       case ATOMISP_CSS_RAW_FRAME:
> > +               *info = p_info.raw_output_info;
> > +               dev_dbg(isp->dev, "getting raw frame info.\n");  
> 
> Can we get break; here followed by default case?

Surely. I'll do such change on a separate patch.

Regards,
Mauro