Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3913306pxb;
        Tue, 2 Nov 2021 00:15:56 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxafsljya1PIAZgw4yJ1UfxEJMEq4qnYCogiW6Elwlyi2TN4OhEeFI/LyT/rtdWLUSFm9HS
X-Received: by 2002:a05:6e02:214f:: with SMTP id d15mr23498375ilv.145.1635837355930;
        Tue, 02 Nov 2021 00:15:55 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1635837355; cv=none;
        d=google.com; s=arc-20160816;
        b=rrEaKM+r9hCymqbWnfqragx5b05ysSBJfbpHEKXbG6Ot5eZgrde0+8azZe8dNopZqa
         Dqc6lCjp94umlvtcKWKzNc3K7Z2GxTOPQefQ3fdOr4c+GQbwdO1P74qyCt5RwNVy70oy
         DCybgEqPlriyt/7rM6kcbayT8XBaBQRlowrNnOiv0FfWw7y2b3I0YXZ4Rjws3y4uXhMV
         FpQbtlpwf7YQY0wMbUOwLD9Z6pAWgqwhrzbXa4i8dvx7IrtUAUHeZu1uwSRi23TR4/2V
         a2EeP5e4jhJ1L5gpTqEf1YR1IdVgSNr/WM6JpHKI99SSW7i+tnU08bt6k8g+rYXVHDgm
         Hf7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=iyPiD06oTEYjUMmdxNC2ui2Auz/y/Iufvmou1ZG+EvU=;
        b=EiTGqpAflZ7oXIjlhyOk1BZUzPlHxSq/a60zTSO9nPO2/8CjJOeu4fDVegOPiNg8+q
         Pmpb/x7umzOsTt+Xp2Y8Ff9Uus66ndjwzdEK0jKed43MHQE7UbY1lWayKx3Jo3EN9mEW
         gOqLd096L2w0+znhLUuU/G36UUhknH1qGB47pcXrEUqUb5wx9G/K1kk2oiqcuQNSyV2R
         olwt0E1D3CVeWkefj1PFk6cG4RkKDHyj7Dpbcdepv7xlTo6rvP7qfVJ2Xwtpn9dHfb0M
         MrLYm+fEB/cIYRL/SXg7q6WixsgiluS3+Xbgabrg4/0N9LviBCyeqtvEpRmH4gysNhUo
         4/1g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2Z9yv9wG;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id m16si6577290ioo.85.2021.11.02.00.15.44;
        Tue, 02 Nov 2021 00:15:55 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2Z9yv9wG;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231489AbhKBHQL (ORCPT <rfc822;ly15351151@gmail.com> + 99 others);
        Tue, 2 Nov 2021 03:16:11 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55104 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231181AbhKBHQA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 2 Nov 2021 03:16:00 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89370C061714;
        Tue,  2 Nov 2021 00:13:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=iyPiD06oTEYjUMmdxNC2ui2Auz/y/Iufvmou1ZG+EvU=; b=2Z9yv9wGv98CEqYYbUvfpEB0TT
        rVUichQgFJ2n1a0ugMlmDEYB1wUbpGA0sSJoYMzW7HdX/6eMP9+1CAZ0aG+z0mLzYrofImZheF82K
        g1qQzdiyQy/UThv6UzgQOXSefyPoIjdeFIbdimXtkD2brEPor4b/dWPTWFJWVRB42BKrhAozVKpRo
        tRipzEmb2swrMh1Pji8PmMdB/tCMP/HWqXm370VntdFo+8xQqfoaizddQG/oj0Iz3a3D7H3IS334f
        qdNoi+cfpu69R8zI3/DQOi7j5yrnzBXMSiH5IehIdXkLlJkim8o7WO+M8g474Amlnc1+4TGqYSMgS
        v2qhOdiw==;
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1mhnz0-000jd7-Dg; Tue, 02 Nov 2021 07:13:22 +0000
Date:   Tue, 2 Nov 2021 00:13:22 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc:     "Darrick J. Wong" <djwong@kernel.org>, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 03/21] block: Add bio_for_each_folio_all()
Message-ID: <YYDlEmcpkTrph5HI@infradead.org>
References: <20211101203929.954622-1-willy@infradead.org>
 <20211101203929.954622-4-willy@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211101203929.954622-4-willy@infradead.org>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 01, 2021 at 08:39:11PM +0000, Matthew Wilcox (Oracle) wrote:
> +static inline
> +void bio_first_folio(struct folio_iter *fi, struct bio *bio, int i)

Please fix the weird prototype formatting here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>