Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3991706pxb; Tue, 2 Nov 2021 02:03:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTYDzSFDx0BXvm9YoCP01jMY6kk98unZsrxl5NdagxhV70pUYsMNYqoObknwttdSy4iuKL X-Received: by 2002:a05:6402:84c:: with SMTP id b12mr1713444edz.323.1635843818454; Tue, 02 Nov 2021 02:03:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635843818; cv=none; d=google.com; s=arc-20160816; b=s2zX1rRx2iou/jrxINlmYy/8OEgjsgKOPE+pDBaUupkg/kT6MuSPQ2/lbSgsuc4xHO aZgWthSHtBDflYuha0Au0PWOCvcb8IRowwpApEoKDhjHIP+qAeEt4SeleyfLI6PhEMrX PjrEFyI8TRaBhblvyrzKj1LaxEvuzPnXcDkbY18zJgSal08Jj0epEylj394/ktN7iWEZ uaS4OeRx6QKapcRrJXEkUJolu/M/nwOQpp1U5z2dAUQyvPNggChyXWOTWBRznDA8sKzQ mqq+lNvH2HX/wE1RrliNH557lSK1jsIGmmSAc3y3oY8dkZmfHLQ/qQJoo/p6vEzSDNFJ zCtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=8SdKDvx1dxKEoYl5vYDc0BHQH9v0Nb0/fW4aneEuw5E=; b=H9VBcPtX+VfswPJGI8scxpZHB0AQPTwWU2rjHJ2cC0NkwZ2ykPGkYLVmfnQ7kYuzsb aJw0LPrYsVE9s4rt/+K8QranWLTV6XxNL15XDkDf9gXmqb8dDMz7NeBu96TT+IaWQ12R JHE689o5p0RKv6+vsu5t7MXTEbXS3VZbQXzDee/qfFLZN6Q5Q4zGUs2ihckyo3pRXtlQ lJ90S/c5fJ/L/+lIVJEY4iCBEofPKVQCbBt6zKlwgFaYcHJVXGmjM/CVweksSpD2B2vw use9e5ovHGNSQd408RzvNsd5xGUKZpO0TJN5mZxRGl16D9Ad7onzUGN3dvfYEH2dOsZJ FBrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fz1si30834584ejc.72.2021.11.02.02.03.14; Tue, 02 Nov 2021 02:03:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229770AbhKBJDy (ORCPT + 99 others); Tue, 2 Nov 2021 05:03:54 -0400 Received: from foss.arm.com ([217.140.110.172]:58656 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbhKBJDy (ORCPT ); Tue, 2 Nov 2021 05:03:54 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C3BB113E; Tue, 2 Nov 2021 02:01:19 -0700 (PDT) Received: from bogus (unknown [10.57.46.68]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9C8E33F5A1; Tue, 2 Nov 2021 02:01:17 -0700 (PDT) Date: Tue, 2 Nov 2021 09:01:15 +0000 From: Sudeep Holla To: Wan Jiabing Cc: Wolfram Sang , Zhiqi Song , Tian Tao , Florian Fainelli , linux-i2c@vger.kernel.org, Sudeep Holla , linux-kernel@vger.kernel.org, jiabing.wan@qq.com Subject: Re: [PATCH] i2c: xgene-slimpro: Fix inconsistent IS_ERR and PTR_ERR Message-ID: <20211102090115.svupxektn2vpa7id@bogus> References: <20211102021229.18501-1-wanjiabing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211102021229.18501-1-wanjiabing@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wan, On Mon, Nov 01, 2021 at 10:12:27PM -0400, Wan Jiabing wrote: > Fix following coccicheck warning: > ./drivers/i2c/busses/i2c-xgene-slimpro.c:488:6-12: inconsistent IS_ERR > and PTR_ERR on line 490. There is another version @[1]. Thanks for the effort. Hi Wolfram, Can you pick [1] after -rc1 ? I see mailbox updates are in the mainline already. -- Regards, Sudeep [1] https://lore.kernel.org/kernel-janitors/20211101140235.777322-1-weiyongjun1@huawei.com/