Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 10:50:27 +0100
From:   Corentin Labbe <clabbe.montjoie@gmail.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Corentin Labbe <clabbe@baylibre.com>, davem@davemloft.net,
        kuba@kernel.org, linus.walleij@linaro.org,
        ulli.kroll@googlemail.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: cortina: permit to set mac address in DT
Message-ID: <YYEJ46n978BjGF8H@Red>
References: <20211026191703.1174086-1-clabbe@baylibre.com>
 <YXiYZGEiVMLdN1zt@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YXiYZGEiVMLdN1zt@lunn.ch>
Precedence: bulk

Le Wed, Oct 27, 2021 at 02:08:04AM +0200, Andrew Lunn a ?crit :
> On Tue, Oct 26, 2021 at 07:17:03PM +0000, Corentin Labbe wrote:
> > Add ability of setting mac address in DT for cortina ethernet driver.
> > 
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> >  drivers/net/ethernet/cortina/gemini.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
> > index 941f175fb911..f6aa2387a1af 100644
> > --- a/drivers/net/ethernet/cortina/gemini.c
> > +++ b/drivers/net/ethernet/cortina/gemini.c
> > @@ -2356,12 +2356,14 @@ static void gemini_port_save_mac_addr(struct gemini_ethernet_port *port)
> >  static int gemini_ethernet_port_probe(struct platform_device *pdev)
> >  {
> >  	char *port_names[2] = { "ethernet0", "ethernet1" };
> > +	struct device_node *np = pdev->dev.of_node;
> >  	struct gemini_ethernet_port *port;
> >  	struct device *dev = &pdev->dev;
> >  	struct gemini_ethernet *geth;
> >  	struct net_device *netdev;
> >  	struct device *parent;
> >  	unsigned int id;
> > +	u8 mac[ETH_ALEN];
> 
> Off by one in terms of reverse Christmas tree.
> 

Hello

I will fix it in a v2

Thanks
Regards