Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4088594pxb; Tue, 2 Nov 2021 04:01:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6wAdfpFf9y8g4Q6arCpdjGsbbkXgWay4w40JgUeJVABEGtybjlhyRqv8QbwBl1ncwbUxv X-Received: by 2002:a92:c244:: with SMTP id k4mr22502997ilo.293.1635850862924; Tue, 02 Nov 2021 04:01:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635850862; cv=none; d=google.com; s=arc-20160816; b=m28JQMFE9W/lFRvv8Az7gdvDlBNEDQVhHcZCEdAN8nOekhQJ5lc3qGcNgAZjYO0oh1 c528Qa4p1VT6MqV2OX0Ybe/6vAucnzo828ctWKskWS/XRR715oH75m341GMUHWyxauoQ JUZZsWdbxsZE0xDTb45XYOnm4BxLLzFJ3yurSaGxJeL2sSbthNaFM0go73VoIec7DrGv ehh5SacoXzz+0HH8wOTP7/tKf/bm+ZiTtycBuiAIjkb0JZCqzxy+9FPBiddGVcyQNV3C JLeeaukhy0VT9D9TdW08PKV9CcjYqdQCC/YEIrQmzGJ3SL8McF5SLAiPvx5Zts0aXv08 f3Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:jabber-id:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:dkim-signature:date; bh=2ASguvbY+iXi8FjWwMvh7ZKXDX1Pp5+swkGc3FrzWmg=; b=zhizaJpLJNS1NUiTHVcomK5lGb9/6psj/YCtH2MKBlH+Nof/uTJA8jrQ9y7nNiDggm IOJOZsIMiS6ydr/UR2qLvFFcw+px7A8scDg8GyMbOTOQltx6UyHCuHZmTx/12gzZdjZ5 UE2dsECadIlvmfcTmoiXUdd+M5zveqnFhxMCUQ2WRPA4QBWHxmZnvcuJF5Xa9SrEVzQM 8+9U8xKpAVOwVuuOu0pslpKXFIRxQSnhoy6mnMn0GvW7rDOLqFCdo7k42/cOdWhIj7eS L0bH5BOxDKu49LH/OpbZeIVdn3i7RYiYnITc/qbPqT217tqs8tYYxRp+CLu6lPqP5MNX 9rtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=YOsujDQu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si14724926ilv.130.2021.11.02.04.00.42; Tue, 02 Nov 2021 04:01:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=YOsujDQu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230407AbhKBLCO (ORCPT + 99 others); Tue, 2 Nov 2021 07:02:14 -0400 Received: from todd.t-8ch.de ([159.69.126.157]:48783 "EHLO todd.t-8ch.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbhKBLCO (ORCPT ); Tue, 2 Nov 2021 07:02:14 -0400 Date: Tue, 2 Nov 2021 11:59:32 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1635850778; bh=EQgH6iFqsqRpn3YWDSWz+nzr9GGk1LqsgNBEiOd9Bno=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YOsujDQuLI5Pd5A72ogB7lsJe//g7lv4F5YHhFsroauupNNiSYRf3RnB3z3hImV1d jSzB/ucHxWr7yBQtfAr8cPdjktzgkQUlw7wcPYyucv3hdtlWK3fmGvjRDh4DUpipbb 4mPVMzAS4ahegxuObHfWUhr1nYJdRED7cyGNQYLo= From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Dominique Martinet Cc: Eric Van Hensbergen , Latchesar Ionkov , "David S. Miller" , Jakub Kicinski , v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/9p: autoload transport modules Message-ID: <922a4843-c7b0-4cdc-b2a6-33bf089766e4@t-8ch.de> References: <20211017134611.4330-1-linux@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Jabber-ID: thomas@t-8ch.de X-Accept: text/plain, text/html;q=0.2, text/*;q=0.1 X-Accept-Language: en-us, en;q=0.8, de-de;q=0.7, de;q=0.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2021-11-02 19:51+0900, Dominique Martinet wrote: > Sorry for the late reply > > Thomas Weißschuh wrote on Sun, Oct 17, 2021 at 03:46:11PM +0200: > > Automatically load transport modules based on the trans= parameter > > passed to mount. > > The removes the requirement for the user to know which module to use. > > This looks good to me, I'll test this briefly on differnet config (=y, > =m) and submit to Linus this week for the next cycle. Thanks. Could you also fix up the typo in the commit message when applying? ("The removes" -> "This removes") > Makes me wonder why trans_fd is included in 9pnet and not in a 9pnet-fd > or 9pnet-tcp module but that'll be for another time... To prepare for the moment when those transport modules are split into their own module(s), we could already add MODULE_ALIAS_9P() calls to net/9p/trans_fd.c. Thomas