Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211102100420.112215-1-robert.marko@sartura.hr> <YYEeS8gz8TBW63X8@google.com>
In-Reply-To: <YYEeS8gz8TBW63X8@google.com>
From:   Robert Marko <robert.marko@sartura.hr>
Date:   Tue, 2 Nov 2021 12:20:24 +0100
Message-ID: <CA+HBbNHWV=+qDpOaD-ePz2yPpSjBOFEgdkuWBiqobBP9VN7W4g@mail.gmail.com>
Subject: Re: [PATCH] mfd: simple-mfd-i2c: Select MFD_CORE to fix build error
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Michael Walle <michael@walle.cc>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Nov 2, 2021 at 12:17 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Tue, 02 Nov 2021, Robert Marko wrote:
>
> > MFD_SIMPLE_MFD_I2C should select the MFD_CORE to a prevent build error:
> >
> > aarch64-linux-ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd=
_i2c_probe':
> > drivers/mfd/simple-mfd-i2c.c:55: undefined reference to `devm_mfd_add_d=
evices'
>
> What is your use-case?
>
> How are you enabling this symbol?

Hi Lee,
I am adding a symbol like MFD_SL28CPLD does that you can depend on and
that simply
selects the MFD_SIMPLE_MFD_I2C and I have hit this issue since the
MFD_CORE is not selected.

Regards,
Robert
>
> > Fixes: 3abee4579484 ("mfd: Add simple regmap based I2C driver")
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > ---
> >  drivers/mfd/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 61992edf6a4d..2de69892b631 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -1204,6 +1204,7 @@ config MFD_SI476X_CORE
> >  config MFD_SIMPLE_MFD_I2C
> >       tristate
> >       depends on I2C
> > +     select MFD_CORE
> >       select REGMAP_I2C
> >       help
> >         This driver creates a single register map with the intention fo=
r it
>
> --
> Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF]
> Senior Technical Lead - Developer Services
> Linaro.org =E2=94=82 Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog


--=20
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr