Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 14:26:34 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Tsuchiya Yuto <kitakar@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Patrik Gfeller <patrik.gfeller@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Dinghao Liu <dinghao.liu@zju.edu.cn>,
        Alan <alan@linux.intel.com>, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/17] media: atomisp: pci: fix punit_ddr_dvfs_enable()
 argument for mrfld_power up case
Message-ID: <20211102112634.GB2794@kadam>
References: <20211017161958.44351-1-kitakar@gmail.com>
 <20211017161958.44351-3-kitakar@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211017161958.44351-3-kitakar@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tZSNX74WL87lQzObcWW6WzWkZC2sqWsLXePXq22rjD6aSiWdj8eiSTwFfr0C?=
 =?us-ascii?Q?LzohsrjI1v6VdR8FB+9cAHoS0c7yAFGFY5tOjjZ4+1sA1yZ6BgTrXHMi2aG4?=
 =?us-ascii?Q?DpcZS9/Ik988nuo+eEW5ZV8lT8cIy9mniVuF/vaO5GPc6pm1T3iQorVXvTzb?=
 =?us-ascii?Q?loiQF9g2ItTahqcW/zRCnd8zoVRxYdDAARJ8rcJmqsY0qvrbN1PExmKduTWL?=
 =?us-ascii?Q?TgM4URJIsd6NDUD9485JXDk8facuKT5OHJY26E4HlVNMJcA2IrprpUWYmeJX?=
 =?us-ascii?Q?RIl84QUMkqDahexoSfSQmX6e+Ur/rBqwBG2KEBOPbewcfQ3iPknh5skgS2H/?=
 =?us-ascii?Q?+j/wMhWzn99mQQXOD1EvQAtvNX9HJfR+6sDQBBZojZ+XLkVzEJuu94txAH8b?=
 =?us-ascii?Q?cKanw9CQQcjseS1hpDY2ja5RA/S6F84zkiTS9O5vGh9DGPA6aVSyunHNylXD?=
 =?us-ascii?Q?IxFVJu9HV++Uvt1oN1AXwf43ZX7RgCj/87YS2lWIinp5oeHDwI9h9PiWcKep?=
 =?us-ascii?Q?4ltupm5VAHSld8fZpVLL+T9n8tyqsI4/4ys534ZVGNJYpJaBmOSGu1Esa9r0?=
 =?us-ascii?Q?6uSHGGNM5hOyHbRh7leP/x86jxfmoDaoG3wRughkqIx6VNvcyPYAbLB5a43X?=
 =?us-ascii?Q?GPEg0O57LozNlGMNCdQkQZZJubhXJLxiIOlGbVI9kwTRutf1Trnu6ZrIfZzE?=
 =?us-ascii?Q?H7Q6aC/EHhTqb9RkXrQFybypDNqUV57UL53/xiE5nNVGULphAtlTYD12nmbZ?=
 =?us-ascii?Q?H0HOm3KeKK0FyoJYra3pTOtnKLvkzoFmr4/uWHHybsVqop60ENAPzQlVcXhu?=
 =?us-ascii?Q?U98n7TrVEy49BwCWHhuBiJz+QC8fRDSorx2sV46BZgfaENhiw1xnoPpZ7k2K?=
 =?us-ascii?Q?odlqd0Sh7+tSb5iKYpLHzEU/kGX7cIwT6113cfwYy8HG2uMCWA0cvGdC+aEH?=
 =?us-ascii?Q?9jtrSw6n42Cv0r1EECdkpNZVizgBXeQdUAxoY7GP9R630lHUtZbhMYjDxWWH?=
 =?us-ascii?Q?3vdqjOaHS2TUX7Cm7VyYbHri5fJYIo8C/IYGUPZ5fx0wUjPdpX2I3EHG4fxm?=
 =?us-ascii?Q?9mIVIx2VVKV/5yjf9B0In6F7jYaMFZCDWvw5WuBnJzdpMkAad4hMYIi8zjin?=
 =?us-ascii?Q?irDISce5T8bsQG/imjWYaeIwvd8YIn01pDJGPRhcywe5kAzDwco5DvT/SqCU?=
 =?us-ascii?Q?Gtmcv4vrd0V98c8pxHFSTAkIwx3kqmRD31rlGM3mf8+CYyqtTkARrPYA6Aeo?=
 =?us-ascii?Q?hJgPjpqpZk2abPGS/oUt1Wy+PdFuD/Q8nJrRr/5fhbLxdq4VXCB7Bv8qKnvC?=
 =?us-ascii?Q?X7j3hBB7c67VuzstX+H61AtHJnLw5B/MvLSCsC4cALgwjlf+x9y1qC/F+tVR?=
 =?us-ascii?Q?+tiH4ags8zi74vw4/gbpnbHhRMkSkYXObNoOFbI2H6rWSXsBA/vGVqACUHrL?=
 =?us-ascii?Q?gfz6FZLc4wsYnLrQ6iiR8J6jzoWs1zXnEM410Y3nDceXRBU4772Fjcgz9Gic?=
 =?us-ascii?Q?2ugni7vIl9K2Ee9e42V+cZywXqHVapH3yOPzNe6DUEAGE6GAZiYgpB5fpu0b?=
 =?us-ascii?Q?cn7//eqiSTnMBbR7LCeVHeJWBpl4xEOw+8PFXNtb8pffmyMtJ9MU2F0QeV2Z?=
 =?us-ascii?Q?7Cjl/ZxENAUJXomQtbkaRuYqDqZsLg7zNVQXwUv78vgSqwHf8YCjslL1NYzC?=
 =?us-ascii?Q?u68xlw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20f3ca8c-d1a8-4f1a-ed97-08d99df3ac9d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 11:26:55.1698
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MB6pH7xne2uMesKUpOPvT2qa5nrPDHfkA0RHiAYHtlJZFUVotzWKn5AI+vHyPVOMlpTDLnoHr4pyY/54Vw1PZFYdLujVnWv77LHj1cdmRnE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5667
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10155 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0
 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111020067
X-Proofpoint-GUID: NER8lUhBCZKIVN8J0IDC1UQVAxSpItYd
X-Proofpoint-ORIG-GUID: NER8lUhBCZKIVN8J0IDC1UQVAxSpItYd
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 18, 2021 at 01:19:42AM +0900, Tsuchiya Yuto wrote:
> When comparing with intel-aero atomisp [1], it looks like
> punit_ddr_dvfs_enable() should take `false` as an argument on mrfld_power
> up case.
> 
> Code from the intel-aero kernel [1]:
> 
>         int atomisp_mrfld_power_down(struct atomisp_device *isp)
>         {
>         [...]
>         	/*WA:Enable DVFS*/
>         	if (IS_CHT)
>         		punit_ddr_dvfs_enable(true);
> 
>         int atomisp_mrfld_power_up(struct atomisp_device *isp)
>         {
>         [...]
>         	/*WA for PUNIT, if DVFS enabled, ISP timeout observed*/
>         	if (IS_CHT)
>         		punit_ddr_dvfs_enable(false);
> 
> This patch fixes the inverted argument as per the intel-aero code, as
> well as its comment. While here, fix space issues for comments in
> atomisp_mrfld_power().
> 
> Note that it does not seem to be possible to unify the up/down cases for
> punit_ddr_dvfs_enable(), i.e., we can't do something like the following:
> 
>         if (IS_CHT)
>         	punit_ddr_dvfs_enable(!enable);
> 
> because according to the intel-aero code [1], the DVFS is disabled
> before "writing 0x0 to ISPSSPM0 bit[1:0]" and the DVFS is enabled after
> "writing 0x3 to ISPSSPM0 bit[1:0]".
> 
> [1] https://github.com/intel-aero/linux-kernel/blob/a1b673258feb915268377275130c5c5df0eafc82/drivers/media/pci/atomisp/atomisp_driver/atomisp_v4l2.c#L431-L514
> 
> Fixes: 0f441fd70b1e ("media: atomisp: simplify the power down/up code")
> Signed-off-by: Tsuchiya Yuto <kitakar@gmail.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> index 0511c454e769..f5362554638e 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> @@ -711,15 +711,15 @@ static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable)
>  
>  	dev_dbg(isp->dev, "IUNIT power-%s.\n", enable ? "on" : "off");
>  
> -	/*WA:Enable DVFS*/
> +	/* WA for PUNIT, if DVFS enabled, ISP timeout observed */
>  	if (IS_CHT && enable)
> -		punit_ddr_dvfs_enable(true);
> +		punit_ddr_dvfs_enable(false);
>  
>  	/*
>  	 * FIXME:WA for ECS28A, with this sleep, CTS
>  	 * android.hardware.camera2.cts.CameraDeviceTest#testCameraDeviceAbort
>  	 * PASS, no impact on other platforms
> -	*/
> +	 */
        ^^^

>  	if (IS_BYT && enable)
>  		msleep(10);
>  
> @@ -727,7 +727,7 @@ static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable)
>  	iosf_mbi_modify(BT_MBI_UNIT_PMC, MBI_REG_READ, MRFLD_ISPSSPM0,
>  			val, MRFLD_ISPSSPM0_ISPSSC_MASK);
>  
> -	/*WA:Enable DVFS*/
> +	/* WA:Enable DVFS */
        ^^^^^^^^^^^^^^^^^^^
These two white space changes are unrelated.  Please do them in a
separate patch.

regards,
dan carpenter