Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 14:35:40 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Tsuchiya Yuto <kitakar@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Patrik Gfeller <patrik.gfeller@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Alan <alan@linux.intel.com>,
        Dinghao Liu <dinghao.liu@zju.edu.cn>,
        Deepak R Varma <drv@mailo.com>,
        Alex Dewar <alex.dewar90@gmail.com>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/17] media: atomisp: pci: use IA_CSS_ERROR() for error
 messages in sh_css_mipi.c
Message-ID: <20211102113540.GD2794@kadam>
References: <20211017161958.44351-1-kitakar@gmail.com>
 <20211017161958.44351-7-kitakar@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211017161958.44351-7-kitakar@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FTrYNR0HDKUk65j722UpvmCmMSgBAKO+SoSTg2LWK4PCj6Vnh7TGZoLS09m+?=
 =?us-ascii?Q?Mje6lboFyhKOVix1rrr2Qu5eSQCuLmRf4yY1b2gsv/tkGh6+7L7OC1F/rW5e?=
 =?us-ascii?Q?cR8kMFssKdSIWP8jiC8RNVnTZvubBicXYRWlEtRElHv/xcxeNBW5YPdQyST0?=
 =?us-ascii?Q?ahtU5Y4rWVkH4eLm8vTPLzPAVM5d6q9k6WhNxU21s9mVyIZot+7FO5/tRdoj?=
 =?us-ascii?Q?hN0xX1OCAVBszhKEzd4spY9bQwQLDXsv0VfnuX83KzhXPmMwRUa/P/j9qEKL?=
 =?us-ascii?Q?K2NCX1UVKEv2RWaKqPeQttc4h5WwxF3LDkhjiDr4RtZhtKXYAdKyX45dxJ9W?=
 =?us-ascii?Q?Hx9fhtKpgGS+ulepV6Xnp4bjWKvrAoUG6GhnceuOISRhf1F7ozNbs21XVbX8?=
 =?us-ascii?Q?f0PanFso3Ea0/mbdrQOVYYGPzAeuGFWl82o/LC8t3/BebYircUXJMIaMKrz0?=
 =?us-ascii?Q?V6eF5b10D+Vtm/xlFoi9huOSVvdeOSJRlJvbglJK+1+HcAhtpX3neUn2yeYk?=
 =?us-ascii?Q?LwRdhLU0uXuQkLqnXJlYpZTsNFzKdXEVseXQcJ+abrNozON7qjB48Y+DVXpB?=
 =?us-ascii?Q?vtNXcZFOiS19FUx5ejW4sI0Qy+iWjFC0jeYWSjpGWYdj7oi80vqT0wBSn2mK?=
 =?us-ascii?Q?LwjLXmLgwsCX09vZeYwe1lABZp8SndydMbX2SRs30fPvKFW4o7uGCQ+IS3lG?=
 =?us-ascii?Q?HmB7pMPAAuZXlhTUbMF3VaO/KdNASQ+r32BRPEkT+d5JrSWgmDfAb9MWMG3s?=
 =?us-ascii?Q?fqWimiKQXerCwRZmkMDP0TZG0Q++2EOpsoM7OPA4s/4FbKs1mSXy0aM+3kwJ?=
 =?us-ascii?Q?DyuP9m6sBrCRKtk9GYvSviWcsovlAYCqVmNq/KDQxO6lOlwaSnaSAo83sxvl?=
 =?us-ascii?Q?+Zu3C2fI7rUGroN6GqWlPoTQ8b9Tzvdw6PkEm7r9LK3ZL72RWZeeq0HXjNX9?=
 =?us-ascii?Q?+UtN9Vto/6SMK+V4h9jxaLuAvui5CpOAbjWjZ9CQixEZLVEX+LXiIxcLkL81?=
 =?us-ascii?Q?H/ZZ2zM5pFHhu0voQymMZGPO/pcWVr3X7KZD1cSDcbmLPNtKm3b1H0c8C4zS?=
 =?us-ascii?Q?jHkSPnIzaryRl8mBJkIs6SSNV0ZOIQyfiUnCwWoVaZNVGiCYC2JjhKRl1/K0?=
 =?us-ascii?Q?miHZvtafjqm8dCO1MzBdxrzNEeTPOIbVjBjXRL/NhcNaGu+nrTHH7biudyaT?=
 =?us-ascii?Q?dILDHmZb9rcCa4N5eyM6IKxjdmYbsBYnPLtIrhSO15YeQhxsiC9qhQUtInyz?=
 =?us-ascii?Q?hb15ubk2d/DEeuCLpbIORHtGhW0szHCWcEFKS0pGkh37ITc5Bbn2GvdPGlqu?=
 =?us-ascii?Q?gQLDSKzLGX9zHCGk7xf7cXXNh9/qDPRmm5RI7ty+tHd3HdWzSc2Lx7XrxTcm?=
 =?us-ascii?Q?DVCF9S79VpqwymTa28xzHt0C+T5UaSgXSDrXofZZ/eDw+DGfATNFYCjZGwX9?=
 =?us-ascii?Q?glmMY2apDigT9s8MnZsvxRhAXVk1OMi6XwDCZb+Tli6iUiW1JV5mbH5EGT56?=
 =?us-ascii?Q?Nu1QR7P4xMRbjLXdqJ0n4RI6vv8P63kQ8njubQpd0vG7Otl6fKYOWO010Fmo?=
 =?us-ascii?Q?5+umoAx1/07euHqUlJX2KOzGG54Itc+VYybxomd7yG4P3VVaXGn/3ON51Pis?=
 =?us-ascii?Q?eMaHeaKFmykoqejaRfjpC3gl0MROisWFHWfBGGjpgZhyJKdylgsdlptIfrvO?=
 =?us-ascii?Q?7N+1tQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29d021da-9523-4694-7f63-08d99df4f2ed
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 11:36:02.7704
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ou214Ti/bLauXp13DkcICn4Jlpn0C29YG6el748dt48eSDMB0nAlRv7JxKcTK7D7fianF8SPUIh/LrZ6uJcwMfnTGpmXuH233N2i3R9dnCc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5792
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10155 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 adultscore=0
 spamscore=0 bulkscore=0 phishscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111020068
X-Proofpoint-GUID: hwANBPAN9Wj2FqA4Z8cslWnha326tFSU
X-Proofpoint-ORIG-GUID: hwANBPAN9Wj2FqA4Z8cslWnha326tFSU
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 18, 2021 at 01:19:46AM +0900, Tsuchiya Yuto wrote:
>  .../staging/media/atomisp/pci/sh_css_mipi.c   | 32 ++++++++-----------
>  1 file changed, 13 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> index c1f2f6151c5f..de56a1da754d 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> @@ -434,9 +434,8 @@ allocate_mipi_frames(struct ia_css_pipe *pipe,
>  
>  	if ((!IS_ISP2401 && port >= N_CSI_PORTS) ||
>  	    (IS_ISP2401 && err)) {
> -		ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE,
> -				    "allocate_mipi_frames(%p) exit: error: port is not correct (port=%d).\n",
> -				    pipe, port);
> +		IA_CSS_ERROR("allocate_mipi_frames(%p) exit: port is not correct (port=%d).",
> +			     pipe, port);

Not related to this patch but these printks should be using __func__
instead of hard coding it.

regards,
dan carpenter