Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4127509pxb; Tue, 2 Nov 2021 04:43:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7gkKikC2qbMdTV0T3r8SmbIDBy3OtqKMspf9rwXuAvo+q/USOxY9w8HQrCR5ZduCFQmQ3 X-Received: by 2002:a17:907:6ea1:: with SMTP id sh33mr16588744ejc.150.1635853413364; Tue, 02 Nov 2021 04:43:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635853413; cv=none; d=google.com; s=arc-20160816; b=sVsrZhg/so2/MO0Pk1s/poxNsfvjTNF5j+oMoor/mjdxbuG7qdT1TT/yq0gcG/kOQ0 7rWGgZiERg6DrOxVhkC+7pImlqFAHSAItILb84LJKAfltn2QXO0M/2jEva/0IxFqUEXw +Q9ltiwL1HZQccf2miUPFLiY0NgS6rS4cduICJUt0RU+SQGcra0kFnYBgokJWofJqlWz 6hqNLJZ8GUZgTLDhYqZ/0kEUL6vJ0H7XgY/9FbQq3SdxZ851ATStjXLImSLLfvc/01I5 1zktvGuuukLUdEzEiO24qIkv4i1YRlioEghlQfsbqNjb1AXQExgM9Gl3W+H/R4Yx0z9L hEhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=v7UWhJOKDzsbeHVsYlVjjuST4suQSxXC/GtRwhpTDjM=; b=ZHun+bUH4t6kamgoYqv1Ly0CZVePj47mDIIHstOzTcHUMwY6njhYrs0vInQxjW9qdk t9PqH9qwNUfcPPHNZHu545RoUpBHBRvZqHimeodcBNIS+qoEAPfMtTeB0PlXAsNFmvHK XJjqAXv8BYUaU6xple3BuzLradKezZpE1SODUsHZot+qiWk2DMdMeLY9Z7tbaeFlUaP1 m0cFjihzdm+8JL5ayXgylWQ1EnHlwR/0XhU389ad44LesKh3eQ5ygB3wNFo6GX3MlpIp Cqed3YM5jozBhPNW91nlWrKJEZHpIoYWU+irhmGXcOFoI99WqzlE/cGeEri3ne5xownb QwQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y20si10589829edc.31.2021.11.02.04.43.09; Tue, 02 Nov 2021 04:43:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232139AbhKBLls (ORCPT + 99 others); Tue, 2 Nov 2021 07:41:48 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76]:58305 "EHLO gandalf.ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231556AbhKBLlP (ORCPT ); Tue, 2 Nov 2021 07:41:15 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Hk7Fp65cxz4xdM; Tue, 2 Nov 2021 22:38:38 +1100 (AEDT) From: Michael Ellerman To: Bixuan Cui , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: benh@kernel.crashing.org, paulus@samba.org, ivan@de.ibm.com, mpe@ellerman.id.au In-Reply-To: <1635406102-88719-1-git-send-email-cuibixuan@linux.alibaba.com> References: <1635406102-88719-1-git-send-email-cuibixuan@linux.alibaba.com> Subject: Re: [PATCH -next] powerpc/44x/fsp2: add missing of_node_put Message-Id: <163584792552.1845480.16701207323198181302.b4-ty@ellerman.id.au> Date: Tue, 02 Nov 2021 21:12:05 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Oct 2021 15:28:22 +0800, Bixuan Cui wrote: > Early exits from for_each_compatible_node() should decrement the > node reference counter. Reported by Coccinelle: > > ./arch/powerpc/platforms/44x/fsp2.c:206:1-25: WARNING: Function > "for_each_compatible_node" should have of_node_put() before return > around line 218. > > [...] Applied to powerpc/next. [1/1] powerpc/44x/fsp2: add missing of_node_put https://git.kernel.org/powerpc/c/290fe8aa69ef5c51c778c0bb33f8ef0181c769f5 cheers