Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4128772pxb; Tue, 2 Nov 2021 04:45:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLAchn0g1OOEJBL73fwBNjSBZOmqEW+yW1Qhktc2462nYtG8Aj/XqOhKo9v2BvgxnZuLCn X-Received: by 2002:a17:906:3390:: with SMTP id v16mr29286036eja.93.1635853506980; Tue, 02 Nov 2021 04:45:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635853506; cv=none; d=google.com; s=arc-20160816; b=MBHHl0vzLAuxGXLx3KQB6U4h1ZKRVbe/eCbDcxCdHhegAF7w4wlQccdqEVbPShY0VJ IflUu9tkYKny5BYW55oVxnVG5904fHw2honS+Kjvu/c6BLKxWNm9XvJ+sqD95sQrtmEF joyupdxqtzMR2GrNn2XT3qP8sFPm3jBPO4vpPHIdvRRx2ymduXyIx09ziJaevw3mliTa q7e6q/DaOWyWTyb4h5mANCD3nSaioGUtfJ5OfdTGVQd5GzQVtx7qFzs3R41PjsJNmoEt 7eUPgTQIZoFlwF7xONgERBU0dkkwUtbzmOHm2g4lH/pfcdDyMRSQzebLVKWvsp5cgCGq 8Rrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=RUd4XMAeB1gQjQ254Z9vkPpCt8rcOG/PoDAAmarh5lo=; b=C8zWa0cszkhwMD/zc2X3eHtxGozkcEsjmfhT6yK8shnd0EzjK8eJIYdQNpQ1EWYy+8 eh6Uoo3fa2mpU40nXFUmH+p29++OLI6BIrsp7BVg5vUpFX7J4hnME/6v1UZTef4jkF4W AU16Z4LIHpXMJtc+BS+05bXmgz0Kn3iueAIlA4aUfT/rVydUdmLQAWSTBpOk19FWwzJE JYzMaO/R42e51XgOQL7tGTouMnNehBdu3cdiRoVKv7707t5WAzr50jJDBSN4Z7N/bwck 9PNP0cNFvv0TBtQgyvKzcqj6Is3tL68N1XpZGaNBjbdmyKlDmKEKeXhiS03IJqUtbYmy ptYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id au25si25025906ejc.533.2021.11.02.04.44.43; Tue, 02 Nov 2021 04:45:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231980AbhKBLmN (ORCPT + 99 others); Tue, 2 Nov 2021 07:42:13 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76]:53263 "EHLO gandalf.ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232001AbhKBLlf (ORCPT ); Tue, 2 Nov 2021 07:41:35 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Hk7G82qmLz4xdh; Tue, 2 Nov 2021 22:38:56 +1100 (AEDT) From: Michael Ellerman To: Wan Jiabing , linux-kernel@vger.kernel.org, Paul Mackerras , Michael Ellerman , Lakshmi Ramasubramanian , Sourabh Jain , Hari Bathini , linuxppc-dev@lists.ozlabs.org, Rob Herring , Thiago Jung Bauermann , Benjamin Herrenschmidt Cc: kael_w@yeah.net In-Reply-To: <20211018015418.10182-1-wanjiabing@vivo.com> References: <20211018015418.10182-1-wanjiabing@vivo.com> Subject: Re: [PATCH] powerpc/kexec_file: Add of_node_put() before goto Message-Id: <163584789386.1845480.15708665136918587423.b4-ty@ellerman.id.au> Date: Tue, 02 Nov 2021 21:11:33 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 17 Oct 2021 21:54:16 -0400, Wan Jiabing wrote: > Fix following coccicheck warning: > ./arch/powerpc/kexec/file_load_64.c:698:1-22: WARNING: Function > for_each_node_by_type should have of_node_put() before goto > > Early exits from for_each_node_by_type should decrement the > node reference counter. > > [...] Applied to powerpc/next. [1/1] powerpc/kexec_file: Add of_node_put() before goto https://git.kernel.org/powerpc/c/7453f501d443c7febf48809ee1c530b64d625c59 cheers