Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 02 Nov 2021 13:28:51 +0100
From:   Michael Walle <michael@walle.cc>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Robert Marko <robert.marko@sartura.hr>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: simple-mfd-i2c: Select MFD_CORE to fix build error
In-Reply-To: <YYEeS8gz8TBW63X8@google.com>
References: <20211102100420.112215-1-robert.marko@sartura.hr>
 <YYEeS8gz8TBW63X8@google.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <8b2b9e6f61107b79f93dd191c3fc2918@walle.cc>
Precedence: bulk

Am 2021-11-02 12:17, schrieb Lee Jones:
> On Tue, 02 Nov 2021, Robert Marko wrote:
> 
>> MFD_SIMPLE_MFD_I2C should select the MFD_CORE to a prevent build 
>> error:
>> 
>> aarch64-linux-ld: drivers/mfd/simple-mfd-i2c.o: in function 
>> `simple_mfd_i2c_probe':
>> drivers/mfd/simple-mfd-i2c.c:55: undefined reference to 
>> `devm_mfd_add_devices'
> 
> What is your use-case?
> 
> How are you enabling this symbol?

Mh? drivers/mfd/simple-mfd-i2c.c is using devm_mfd_add_devices which
is provided by drivers/mfd/core.c. So select MFD_CORE is clearly
missing here, no? I mean most of the MFD drivers do a "select MFD_CORE".

-michael