Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 12:45:13 +0000
From:   Jonathan Clarke <jonathan.a.clarke@gmail.com>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH] Make top/rear speaker, mute and micmute leds work on HP
 x360 14-ea000 laptops that use Realtek 245 codec
Message-ID: <20211102124513.GA1298862@rampage-hp2>
References: <20211029154313.1005394-1-jonathan.a.clarke@gmail.com>
 <s5h35oisug0.wl-tiwai@suse.de>
 <20211101103445.GA1064130@rampage-hp2>
 <s5hzgqnotpu.wl-tiwai@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <s5hzgqnotpu.wl-tiwai@suse.de>
Precedence: bulk

On Tue, Nov 02, 2021 at 09:19:25AM +0100, Takashi Iwai wrote:
> Could you try just to flip the bit 0x08?  At LED off state?
> 
> % hda-verb /dev/snd/hwC0D0 0x20 SET_COEF_INDEX 0x0b
> % hda-verb /dev/snd/hwC0D0 0x20 SET_PROC_COEF 0x77f4
> 
> That is, the implementation in alc286_fixup_hp_mute_led_coefbit(),
> which is used by many other HP laptops.

Ah, I see what you mean.  

Yes, you're right, changing from 0x77f4 to 0x77fc makes the mute led light up.
The changes to the other proc_coef bits in my patch are not needed.

I will revise and revert in next few days.  Thanks