Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 16:02:45 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Tsuchiya Yuto <kitakar@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Patrik Gfeller <patrik.gfeller@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Kaixu Xia <kaixuxia@tencent.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Yang Li <abaci-bugfix@linux.alibaba.com>,
        Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        Alex Dewar <alex.dewar90@gmail.com>,
        Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>, Alan <alan@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [BUG/RFC PATCH 3/5] [BUG][RFC] media: atomisp: pci: add NULL
 check for asd obtained from atomisp_video_pipe
Message-ID: <20211102130245.GE2794@kadam>
References: <20211017162337.44860-1-kitakar@gmail.com>
 <20211017162337.44860-4-kitakar@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211017162337.44860-4-kitakar@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TSL1ijuBBpb49wcLS/tVKJx39T1lH0GcsM+J6KEEuEcEqhez1Sb8CsUXJ/+a?=
 =?us-ascii?Q?TdohClmrGceEXVMuI+PVJOeENCv3YBxepTCXNXxdJ6ZF8N6m09DWGy2+Ja8g?=
 =?us-ascii?Q?CX+NMg2uw19nnYANoUcBAY4XZvB1jF2aUT65bae1SxTmVduLqopvODIcAJnV?=
 =?us-ascii?Q?WR//U3oVv/1Oa4Wd3qCKSn+2/MuQ1r7jT7nYQ2rF9g/+j8OV0BLxijsDqW3L?=
 =?us-ascii?Q?w+VR5FQvFaTAkYl4WsOQQQxrxgFv894CO3cz8tUtLdVWBIfErBpedku4lbX0?=
 =?us-ascii?Q?eXhwM9+uUlFzAnNBOMPETqnf+Mru0gxRj1ywISMnxKIQ+Zqcd9KmABDOk44x?=
 =?us-ascii?Q?naK5GRUB2uXYMzq1T0Zu/0eKXi+8u42mOFFX1ehLdmMelfWfp+Eyb8thsHGc?=
 =?us-ascii?Q?ff72KRtCmk/eEIPv0MfiHHTbVcIvEN1gklPmTrd/USCvqauyETIboDFqy/lQ?=
 =?us-ascii?Q?y6tS2cnSNur28cOBdmt97N35f+XiqV59tSEaH9+okotTh1wfSq7uYQ6mHt7a?=
 =?us-ascii?Q?DuwMyXV/nI1R+aZtxBc6wLwrbPN2DNWsYUEaVm1/TAbWwOMeE+FPUk9q41Oa?=
 =?us-ascii?Q?zqRxUPHkasp3hY/YnkbfFziFhRQ8kps44HSrBcSuuRCq951g0Nnvj7yiv2d0?=
 =?us-ascii?Q?AMczPL/BGLG8gP4mkZGptxj3v611H6tLNuYZBtngbulkEU2X2Yjn7DBOQSEt?=
 =?us-ascii?Q?W1AUx1XRGYrC5NFZk/bUYe2iqmd2bP/kgexd0xKfcEPL/qxrw8cV3G9UZNac?=
 =?us-ascii?Q?9l+DaMjppDsMQfel2RbRfdj9PNHEXAKkxxOvJmGANFSKPjjAWPd/U+ziNr8i?=
 =?us-ascii?Q?a1fAjCxpqRpKpUJPWjRFRWvKBxNm7FSIlE3RPk/UUq1+TGeV3spiLIHawDNg?=
 =?us-ascii?Q?nNzkDiolJZa2VK11SL6wQk6wygGxhLVLq0prANU987tmb+Vx55EOvcbUQFr2?=
 =?us-ascii?Q?nb5H7NFqjsaEvu//8ts5koIcyz4q1aNcFqclz+E5DHJb9XLS2kAbPJ3k14LR?=
 =?us-ascii?Q?XIGxx/baOaGvtGuIPX1nO6UznQNtra14ITrymRefYQ+iUIdD9pP69reTaaoQ?=
 =?us-ascii?Q?8pVUhv/8/Y6rF6q4iuojSdwDN23kGZ/rjr5q0nfny8uVg9cvN5UZpLHq4naC?=
 =?us-ascii?Q?iL51aLZPgu2HIKV9EYciiZDCCtrQrIe1YlRcf5+CWnGIt3elgzKh1FSu48z8?=
 =?us-ascii?Q?3PQvq4eMxRwlu45xtg1uirL721AGcBpZccCN2qDVU/LgUZ8KICDUvUjC60Ww?=
 =?us-ascii?Q?ihFaf30xLJcmsith3MC3ZQtilgkSxuQ8a2es1LazHTwavns6IHtMBB53L/md?=
 =?us-ascii?Q?loT6NGpKpDcF34xHf7D1+2bR61ylrw6n41he1D1kCOKpUvcCY16Cd5pUnI5T?=
 =?us-ascii?Q?4QY98EvuBpTcWfuigsOUK5BohDUHKVMQYwjTSB5ZF1dAayppu1Rn0D/UJF0G?=
 =?us-ascii?Q?MQSXXtPRsf+Gf1ymKgfolnpPiiucRUNJeEDlowz/OjavmBGeGsR2HWiU/u5r?=
 =?us-ascii?Q?TsmwoEsEd3141KTlrSCAnnXiWRJwvile0jGu1dQpySQViEKk+iR2bRBsdxKW?=
 =?us-ascii?Q?/6WrtwcgMqreiD9NIBS2XWYDVc+wcqoNDbNA3pUBHQBS9X187aPuiXhlCfy7?=
 =?us-ascii?Q?xe0xf17c3NmHxp1gNQI0iq+WtlqKxeWHR5vIAsvajUzGDeAioKIqM9AN6Qwa?=
 =?us-ascii?Q?0JWPVA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d2db972-7f0b-4cba-866f-08d99e012103
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 13:03:13.9338
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LBVP/VAEYQRNTGeulykJQa/62sqq3Px3C2/Dk7w8nCpC16rUQsS5Ar3rXg/+AVFf8Z5oRuk2LTuqyZyNfFEeHWHJLqd6Cc6wiKtq4tPX24k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4483
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10155 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 malwarescore=0
 mlxscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111020077
X-Proofpoint-GUID: U_xmSRo0ksHAjpTok80QPhLRrKpyHLU_
X-Proofpoint-ORIG-GUID: U_xmSRo0ksHAjpTok80QPhLRrKpyHLU_
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote:
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index 366161cff560..7206d29ba263 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -1715,6 +1715,12 @@ void atomisp_wdt_refresh_pipe(struct atomisp_video_pipe *pipe,
>  {
>  	unsigned long next;
>  
> +	if(!pipe->asd) {

Run your patches through scripts/checkpatch.pl.

> +		dev_err(pipe->isp->dev, "%s(): asd is NULL, device is %s\n",
> +			__func__, pipe->vdev.name);
> +		return;
> +	}

regards,
dan carpenter