Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 10:56:59 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        intel-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/29] drm/i915/gvt: integrate into the main Makefile
Message-ID: <20211102135659.GG2744544@nvidia.com>
References: <20211102070601.155501-1-hch@lst.de>
 <20211102070601.155501-3-hch@lst.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211102070601.155501-3-hch@lst.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+FaOzfQLpchfqN3CGwFToyYDOr/a2umxns3EUaT2T/4etAQ1p5sKkgCLc8Kp?=
 =?us-ascii?Q?EiRk59AMzIPR04DbkRT4o6AmnAAiXzFa9+yGZUY/TZhFomRsQlbikwWsNec7?=
 =?us-ascii?Q?0Oxu8jXcBtxaz2doAvhjnN8xWCyWIAINYTlVKc6sCI/pmXCRTabGDlH0Q1xu?=
 =?us-ascii?Q?v7bRYDc490OU6rQyU1aR4t0xY0AiG/bvf8SsEKm62cf+Q7Z5eJNkNNrGktQw?=
 =?us-ascii?Q?KeTwBlQgnQ23QGLqpUypVmqw1XprGk+8SL/A/R7+ejhqR/MuyHPaNLhjlA6R?=
 =?us-ascii?Q?/MHeM3lJp/IcvKbYd5mfTRla03rlaUlmkBwRP3GtKus2GbnQA+iyDAsPjQgm?=
 =?us-ascii?Q?tcNWzIsedc5YZ/OQyB3rZSk3YWHavFHdJ3cB5NNun1psjXpjdVL52PMt3TMG?=
 =?us-ascii?Q?7j816x9gXNWzdF1tqaRDdnLBJGsmDKqODADc+lzFDjab3hyFm/IWdL1gx5PN?=
 =?us-ascii?Q?47hpzLeE4kOJs1mMqWJOdhcGNhOyZ2yHbCL5PaACayxT1Kae+VUKTbIE0STi?=
 =?us-ascii?Q?qV4rt33BqNf3y5jh164heR7BwkQS+PVlUmpx0J3pgDOApK7ypeaNhVu9saoE?=
 =?us-ascii?Q?Few+Pk/xoawZx5fCVNX2Bndd8/jVZIEgGMyRfawPZj6c6nuN2v7PxaLmv08v?=
 =?us-ascii?Q?BswVRpVXjMQ3tFYg2X/kZt/qGSXwenYX4AnpGZcR7LwlbYFA4yfyVar5Zsis?=
 =?us-ascii?Q?NEIdBAgmxvJz8A/+dTvxVCV+AANm9+Ml8HK9CN1gNDV4JtTIfywuXIht2IDL?=
 =?us-ascii?Q?DTZioaQynouWKRYUJ9+RfmaWHwVj4o5nZ+bewarXPYhGxjdlFmzze6JlaJvo?=
 =?us-ascii?Q?uHzsJEPXvznIsuq8ZYrTuOkhMs9CH4FgBpORRNPUoD7Y5ubeFukAz/CaPmHH?=
 =?us-ascii?Q?hhNDj1x2dvFVSRVz73Dv/hTSPP9J1ahhLVWdCM380DEKGwtHgg8DBv2ikDtQ?=
 =?us-ascii?Q?rBXYO1egssF878yOkIU+h3L7GuaW/M1+BCG19PJxgZR0GikXy1NBaJrb6UFG?=
 =?us-ascii?Q?0U0dCTrkfbHLPSedYlCSbQWKce6ejCOHysd8sdLLxpviodCOx9znuyHFgMv7?=
 =?us-ascii?Q?C/wEKB8SuadlSPUkJYYc5lLxMn8yWtQIsb1GdLjYOtD60w7iE2jwfvSv4rQq?=
 =?us-ascii?Q?We9qKn5C1xVD9akBx8etx0gWpUmrI5gxYJouMqgPN59r3I4VvxkBkM8XIXR1?=
 =?us-ascii?Q?RVAIp3CaWfxjSKq1sM4DFfyTAAnSuCwtWvSdxjYKSARo2vt7S207SGsLg2QM?=
 =?us-ascii?Q?V8OLfusKWigcjDyZ8XDyvhVO0ZktVNQOaloNbI2uE39mPhliseMJp4mAfyrq?=
 =?us-ascii?Q?G+tKxXlu1X2I5AZSmuG0Vnbt3BVbdM1ubp4vfUNaw4QF957wEQ7KQQVresCc?=
 =?us-ascii?Q?JpmOPkYcryit5LxgLbrNZlAOPjAKvlPL7XftFsTx+YriSQ8jXV/JbL3pvwyt?=
 =?us-ascii?Q?d0GthbXnD1vtQegjWRVYvHKaQLvNJu7tt81h+fcPUzLOraz7RnlrlsA3ap44?=
 =?us-ascii?Q?gXqQoSJGkVyUVp7KMlcqxZ/QhVCmpGIlwS15FzHu/4ppYYRSVC4aYXZusmQt?=
 =?us-ascii?Q?r++9yCd6wfP/fHNEjy4=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e72862ab-fefe-43db-6724-08d99e08a4a8
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 13:57:01.1900
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZzQCwp1gXgsKxnxnYTaYeW023WxacnLbybMMsQMcvTjenOlU7yGosrjpcKt7Ec7U
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5556
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 02, 2021 at 08:05:34AM +0100, Christoph Hellwig wrote:
> Remove the separately included Makefile and just use the relative
> reference from the main i915 Makefile as for source files in other
> subdirectories.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/gpu/drm/i915/Makefile     | 29 ++++++++++++++++++++++++-----
>  drivers/gpu/drm/i915/gvt/Makefile |  9 ---------
>  drivers/gpu/drm/i915/gvt/trace.h  |  2 +-
>  3 files changed, 25 insertions(+), 15 deletions(-)
>  delete mode 100644 drivers/gpu/drm/i915/gvt/Makefile

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

> -
> -ifeq ($(CONFIG_DRM_I915_GVT),y)
> -i915-y += intel_gvt.o
> -include $(src)/gvt/Makefile
> -endif
> +i915-$(CONFIG_DRM_I915_GVT) += \
> +	intel_gvt.o \
> +	gvt/gvt.o \
> +	gvt/aperture_gm.o \
> +	gvt/handlers.o \
> +	gvt/vgpu.o \
> +	gvt/trace_points.o \
> +	gvt/firmware.o \
> +	gvt/interrupt.o \
> +	gvt/gtt.o \
> +	gvt/cfg_space.o \
> +	gvt/opregion.o \
> +	gvt/mmio.o \
> +	gvt/display.o \
> +	gvt/edid.o \
> +	gvt/execlist.o \
> +	gvt/scheduler.o \
> +	gvt/sched_policy.o \
> +	gvt/mmio_context.o \
> +	gvt/cmd_parser.o \
> +	gvt/debugfs.o \
> +	gvt/fb_decoder.o \
> +	gvt/dmabuf.o \
> +	gvt/page_track.o

nit, nicer to sort makefile lists

Jason