Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4276760pxb; Tue, 2 Nov 2021 07:08:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7W5ir+KAJkDCFZoRpkLRAG5+rbUUfvSTUuQ3JA1zqnX5qx+4Fy1ZIa2F4niLomItsUcN7 X-Received: by 2002:aa7:c3cd:: with SMTP id l13mr15009118edr.275.1635862125139; Tue, 02 Nov 2021 07:08:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635862125; cv=none; d=google.com; s=arc-20160816; b=AyfBVUisv8mBTaeDIh/Xu9GS4c8nLPyA7UJnT346I1bMHe0t1aWB0qSwoSgoi+te8d FcFvUZnTsQRTZptQ/TgpUuRz2UoSL1a8SyJLxZLwQPefUtDL4L1je5JPnqIFwrj7gT+X pYwTVCBWJcH0PyyIsC57buXWDnSP00iy2Hjfk23TkZZulIcH1PljXPDL+ZSRQ+UsdPfi 1Y+rbih7insxdG8J/m8H+0hZNOhxiprfkHqetrOv/WzUNJMY6rk8xkdAwCDtORzY6R8T iXYQD0EOcP7uRHnkddkl29a5Jey4x+8v3VJ0+xK3KQOcTJLuFeDLy1rUz+mE4UVryG3m Docg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Z/e3HQli0mAA7KoYNRoXQAsa34CtfqY7Wc9F/kaJAVM=; b=XSwbENPt3VJEWc7KoqikuykN9FX6WJsOyMylUPId+qTQU7yiUIQZzkHGI+yOfGguZ8 7E2CAyhPr1LvPqtwMjAkiOnmavHcYpnzjkLX4/a3SbJRPZNuuMypxsgAhQSbdkY4HWKN U4KM173hlXvSA7FQjnOL/CCPVs8XSVT/vhM5tquBzuWQTj0B7ilJ4Ea6twunoNmamyW0 jb5LaEXDHYSiyfgdgFefPhF8xVq282RWDlMqdaBRI8lK7tAMzIr/7veGIFeTpQ098L4L M8enrwoNJIdSKIq19TyTmDPBnZ7L9JKGR9LCKesrRNy5scUhjsan1gAbMYDC/ellQaoq 0Clg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ka26si23426852ejc.280.2021.11.02.07.08.14; Tue, 02 Nov 2021 07:08:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230336AbhKBOHQ (ORCPT + 99 others); Tue, 2 Nov 2021 10:07:16 -0400 Received: from mailgw01.mediatek.com ([60.244.123.138]:37164 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S230124AbhKBOHN (ORCPT ); Tue, 2 Nov 2021 10:07:13 -0400 X-UUID: 6670d21069c341a5b8172b5157fe5cef-20211102 X-UUID: 6670d21069c341a5b8172b5157fe5cef-20211102 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 672707749; Tue, 02 Nov 2021 22:04:34 +0800 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 2 Nov 2021 22:04:33 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs10n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Tue, 2 Nov 2021 22:04:33 +0800 From: Mark-PK Tsai To: CC: , , , , , , , , , Subject: Re: [PATCH] remoteproc: use %d format string to print return error code Date: Tue, 2 Nov 2021 22:04:33 +0800 Message-ID: <20211102140433.28170-1-mark-pk.tsai@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Tue, Nov 02, 2021 at 08:08:05PM +0800, Mark-PK Tsai wrote: > > Use %d format string to print return error code which > > make the error message easier to understand. > > Even better, if you use %pe after converting "ret" to a pointer via > ERR_PTR(ret), when the kernel is appropriately configured, the kernel > will give a textual version of the error code, which is even easier! Thanks for the suggestion! I will use it in v2.