Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211025103322.160913-1-robert.foss@linaro.org>
 <20211025103322.160913-2-robert.foss@linaro.org> <YYBOXQOXM8USks0G@robh.at.kernel.org>
 <CAG3jFytkHi06uaP8RFaS9cma68S9oz_AcAtkMxCrPKGXBTtfsA@mail.gmail.com>
In-Reply-To: <CAG3jFytkHi06uaP8RFaS9cma68S9oz_AcAtkMxCrPKGXBTtfsA@mail.gmail.com>
From:   Rob Herring <robh@kernel.org>
Date:   Tue, 2 Nov 2021 09:18:14 -0500
Message-ID: <CAL_Jsq+u6hwj+hzj54KCWNG4u=oOkysK9y_rTwJozmRiWBLNKA@mail.gmail.com>
Subject: Re: [PATCH v1 2/2] media: dt-bindings: media: camss: Document
 clock-lanes property
To:     Robert Foss <robert.foss@linaro.org>
Cc:     Todor Tomov <todor.too@gmail.com>,
        "Gross, Andy" <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@somainline.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
        Andrey Konovalov <andrey.konovalov@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Nov 2, 2021 at 6:49 AM Robert Foss <robert.foss@linaro.org> wrote:
>
> On Mon, 1 Nov 2021 at 21:30, Rob Herring <robh@kernel.org> wrote:
> >
> > On Mon, Oct 25, 2021 at 12:33:22PM +0200, Robert Foss wrote:
> > > The clock-lanes property corresponds to a hardware register field
> > > that is required to be set, in order to enable the CSI clock signal.
> > >
> > > The physical lane of the clock signal is not programmable, but only
> > > togglable On or Off, which what BIT(7) of the
> > > CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(5) register controls.
> > >
> > > Signed-off-by: Robert Foss <robert.foss@linaro.org>
> > > ---
> > >  .../devicetree/bindings/media/qcom,msm8996-camss.yaml        | 5 +++++
> > >  .../devicetree/bindings/media/qcom,sdm660-camss.yaml         | 5 +++++
> > >  .../devicetree/bindings/media/qcom,sdm845-camss.yaml         | 5 +++++
> > >  3 files changed, 15 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> > > index 38be41e932f0..d4da1fad12cf 100644
> > > --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> > > +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> > > @@ -106,6 +106,11 @@ properties:
> > >
> > >              properties:
> > >                clock-lanes:
> > > +                description:
> > > +                  The index of the clock-lane is not programmable by
> > > +                  the hardware, but is required to define a CSI port.
> > > +                  Lane 7 reflects the hardware register field that enables
> > > +                  the clock lane.
> >
> > If it is fixed, then it should not be required. Fix the required part.
> >
> > >                  items:
> > >                    - const: 7
> >
> > I don't know how we let that in, but this should be the lane number.
> > Each binding can't be making up its own interpretation.
>
> If the clock lane number isn't programmable, can clock-lanes be omitted?

Yes, that would be the correct thing to do.

Rob