Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 16:09:44 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Julian Braha <julianbraha@gmail.com>
Cc:     airlied@linux.ie, daniel@ffwll.ch, jernej.skrabec@gmail.com,
        wens@csie.org, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org, fazilyildiran@gmail.com
Subject: Re: [PATCH] drm/sun4i: fix unmet dependency on RESET_CONTROLLER for
 PHY_SUN6I_MIPI_DPHY
Message-ID: <20211102150944.h7ycdzlm4s5kvk4j@gilmour>
References: <20211028221327.17984-1-julianbraha@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="sdgbi7nuhb2tf3wq"
Content-Disposition: inline
In-Reply-To: <20211028221327.17984-1-julianbraha@gmail.com>
Precedence: bulk


--sdgbi7nuhb2tf3wq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Oct 28, 2021 at 06:13:27PM -0400, Julian Braha wrote:
> When PHY_SUN6I_MIPI_DPHY is selected, and RESET_CONTROLLER
> is not selected, Kbuild gives the following warning:
>=20
> WARNING: unmet direct dependencies detected for PHY_SUN6I_MIPI_DPHY
>   Depends on [n]: (ARCH_SUNXI [=3Dn] || COMPILE_TEST [=3Dy]) && HAS_IOMEM=
 [=3Dy] && COMMON_CLK [=3Dy] && RESET_CONTROLLER [=3Dn]
>   Selected by [y]:
>   - DRM_SUN6I_DSI [=3Dy] && HAS_IOMEM [=3Dy] && DRM_SUN4I [=3Dy]
>=20
> This is because DRM_SUN6I_DSI selects PHY_SUN6I_MIPI_DPHY
> without selecting or depending on RESET_CONTROLLER, despite
> PHY_SUN6I_MIPI_DPHY depending on RESET_CONTROLLER.
>=20
> These unmet dependency bugs were detected by Kismet,
> a static analysis tool for Kconfig. Please advise if this
> is not the appropriate solution.
>=20
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
>  drivers/gpu/drm/sun4i/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig
> index 5755f0432e77..3f70a14a3c94 100644
> --- a/drivers/gpu/drm/sun4i/Kconfig
> +++ b/drivers/gpu/drm/sun4i/Kconfig
> @@ -46,6 +46,7 @@ config DRM_SUN6I_DSI
>  	default MACH_SUN8I
>  	select CRC_CCITT
>  	select DRM_MIPI_DSI
> +  select RESET_CONTROLLER

The indentation is off, can you fix it and resend it?

Maxime

--sdgbi7nuhb2tf3wq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYYFUuAAKCRDj7w1vZxhR
xdQVAQCEOb8We3hYtT3mqkzFKDO4114iJbKGuP+0OpjI3IatWwD/dQ/ShFBmVkCN
VR9uV82ZNKb6qsodk3xIjJPhbE8+Pw4=
=2Lra
-----END PGP SIGNATURE-----

--sdgbi7nuhb2tf3wq--