Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 16:03:31 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     He Ying <heying24@huawei.com>
Cc:     wens@csie.org, airlied@linux.ie, daniel@ffwll.ch,
        jernej.skrabec@gmail.com, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -V2] drm/sun4i: Grab reference of connector before return
 connector from sun4i_tcon_get_connector
Message-ID: <20211102150331.526nn2e6oqjbf6ur@gilmour>
References: <33e01d45-c9f9-0e8c-6871-868ecd198368@huawei.com>
 <20211102084628.149070-1-heying24@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vw4qxeyln6gwbonp"
Content-Disposition: inline
In-Reply-To: <20211102084628.149070-1-heying24@huawei.com>
Precedence: bulk


--vw4qxeyln6gwbonp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Nov 02, 2021 at 04:46:28AM -0400, He Ying wrote:
> From the comments of drm_for_each_connector_iter(), we know
> that "connector is only valid within the list body, if you
> want to use connector after calling drm_connector_list_iter_end()
> then you need to grab your own reference first using
> drm_connector_get()". So fix the wrong use of connector
> according to the comments and then call drm_connector_put()
> after using connector finishes.
>=20
> Signed-off-by: He Ying <heying24@huawei.com>
> ---
>=20
> V2:
>  Use proper subject prefix
>=20
>  drivers/gpu/drm/sun4i/sun4i_tcon.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/s=
un4i_tcon.c
> index 9f06dec0fc61..24fa6784ee5f 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
> @@ -47,12 +47,12 @@ static struct drm_connector *sun4i_tcon_get_connector=
(const struct drm_encoder *
>  	drm_connector_list_iter_begin(encoder->dev, &iter);
>  	drm_for_each_connector_iter(connector, &iter)
>  		if (connector->encoder =3D=3D encoder) {
> -			drm_connector_list_iter_end(&iter);
> -			return connector;
> +			drm_connector_get(connector);
> +			break;
>  		}
>  	drm_connector_list_iter_end(&iter);
> =20
> -	return NULL;
> +	return connector;

Connector might be uninitialized if we don't find one here

>  }
> =20
>  static int sun4i_tcon_get_pixel_depth(const struct drm_encoder *encoder)
> @@ -65,6 +65,7 @@ static int sun4i_tcon_get_pixel_depth(const struct drm_=
encoder *encoder)
>  		return -EINVAL;
> =20
>  	info =3D &connector->display_info;
> +	drm_connector_put(connector);
>  	if (info->num_bus_formats !=3D 1)

We're still accessing connector->display_info here, but it might have been
freed already.

Maxime

--vw4qxeyln6gwbonp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYYFTQwAKCRDj7w1vZxhR
xW5tAP4vLeRUB7hovZ/pzeMNYb3F27REbqDmaJ5hMt09+f8PEwD/cTbVT8+nLcMU
bJyX2cCnGrXIgeAL3mxTmb8Efmeypg0=
=d0nY
-----END PGP SIGNATURE-----

--vw4qxeyln6gwbonp--