Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 18:05:23 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Tsuchiya Yuto <kitakar@gmail.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Patrik Gfeller <patrik.gfeller@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Kaixu Xia <kaixuxia@tencent.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Yang Li <abaci-bugfix@linux.alibaba.com>,
        Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        Alex Dewar <alex.dewar90@gmail.com>,
        Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>, Alan <alan@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        linux-staging@lists.linux.dev,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG/RFC PATCH 3/5] [BUG][RFC] media: atomisp: pci: add NULL
 check for asd obtained from atomisp_video_pipe
Message-ID: <20211102150523.GJ2794@kadam>
References: <20211017162337.44860-1-kitakar@gmail.com>
 <20211017162337.44860-4-kitakar@gmail.com>
 <20211102130245.GE2794@kadam>
 <CAHp75VeThcCywYZsrUNYSA3Yc3MjJwfiCBCGep1DpWFFUg71cw@mail.gmail.com>
 <CAHp75VdnvxCWYrdrBqtSDP0A2PCT6dYvHAhszY9iH9ooWKT49g@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75VdnvxCWYrdrBqtSDP0A2PCT6dYvHAhszY9iH9ooWKT49g@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0eeAnHGs6FSY/X2fKNrcTGRIiV7sd2iNJxC3Kpxwvx2A4IoUQtOgvP2BM3ti?=
 =?us-ascii?Q?KdHXmcXLCStS2wQf+Mq04mAVjjKYh6W3ii4KWKTkbHstxG4f3+UI/fykFoKx?=
 =?us-ascii?Q?KWASjhT1vgaw1dbnHb8lsEsYiZ5dpj/3vpzZqGW34/kAd13ET22mqFYsPab9?=
 =?us-ascii?Q?MlhrBiE3CW51IzYpGNfkgC/YNFrdjwZjNMAHRs/tfADin/EYi3fIhfWeXKOw?=
 =?us-ascii?Q?AF6zNdfPskj/6EocNxhg0J4U8VFoCL0WlbY4Pg6qwFJwCjAMrg6Bf6+egvUW?=
 =?us-ascii?Q?rWq3EoEVqSb3h45n8XTX8cISiAgLdCm9rImGFFSm7o4S8J62vpeWHQp4YswB?=
 =?us-ascii?Q?yxB41a7Rfy23E8tr59HE0BuITJzYQc7axIot5TaLGTUhEP2GM+Nk3hamknet?=
 =?us-ascii?Q?2PMXyPWxv1FKTQpUd4l5liOTgYRorwuFox/Deusa8RKZZvtiJ1TKYyJ3Hmyr?=
 =?us-ascii?Q?4XQOHcns2xMxr9upzGk3jXdQ/PXStC8cEgD7cgIrRMK4bMcAXCbT2ehm8Bzg?=
 =?us-ascii?Q?KxQHO2evnFYXgHUMr61GvGMpeMwVQeyOUgfWy7Wuw4geXB4z+/fbgxqd3YGx?=
 =?us-ascii?Q?On9+Q1nqeQLCGJ3YG5I30EayfO81e2D8kaN7LNr2YH34NDMcmC+OCdg9WvSZ?=
 =?us-ascii?Q?l6Y3BfDfyow/RjQK0fOiub4skemKFCyZRU8Wou60yXL5kVYrVXmXMtgeSb+6?=
 =?us-ascii?Q?IkWp+iaPoIRXV5MD7fI249k7N75rEWbwtujlY7UMwFBboh2TotdnbUI9uh0R?=
 =?us-ascii?Q?eiPh+zPgMcLO6nvu2duFZFDRXTeqf0B0jT3jUg4/d97k5uAXejulJgaBlzXX?=
 =?us-ascii?Q?EFU2tYnxbWjfglrqJYjXeUn/BilDLQW1Ou0ZgqXH/4KoiEexyCjKd5M8qeub?=
 =?us-ascii?Q?PvqoLreMHoZ45Y358zLjvemr3kyqvNK3LiD4WdQK5ZHPDN48UqbchL4edTVt?=
 =?us-ascii?Q?csGn0TyL1sqK7KOyZvxcu1fvEjhA+nPyBaHK4DEhOj+0zfCoANfeSJudRXZg?=
 =?us-ascii?Q?Bne1Jmv7O4qM/Dva2Mv+kg4PdO7KA4DUFcChkJtOefLHp+qdd1gSspvCr5D3?=
 =?us-ascii?Q?3zNPt4akM0w1Jp26UTql3dPzRv2IBL7Mq/13ywxKBS6dEUOOfthG0WjTUf6g?=
 =?us-ascii?Q?ErPAeBCw2slvbXwcwFBUSJbR61l1In5Sdu/75hfArCze/PdFf10CfCkSpr5D?=
 =?us-ascii?Q?dvvaaCwykiL+XbvclDTGtIJSpxwVOBrhEjFxPCNG0Q7REF08e6phj9mNh6xf?=
 =?us-ascii?Q?LHZxrdxG5Bnbq6Dwnd5JSIwUWQVMI0UCbcZ0pEXuzMOTfjDiL8saJzezocWv?=
 =?us-ascii?Q?/Qn+VmvjaS4k9Di7x1Os5RRd0oXQZ5TJ5ZHesBW2LmkSIV9dBnWUpgFWL01C?=
 =?us-ascii?Q?27lZB9amTGWmCoH8lreFc8qwMDxu9373/fzoguXwg0ifnm2afr8H05uLSVjU?=
 =?us-ascii?Q?4M00k6hh21Zd5AGVGo9piPbOkqotC7U4gwF7eaZDYIhhtNcbjP/0+0qfeQ6/?=
 =?us-ascii?Q?PYMkwoO6qjELBx1Mjsl4DfDTHyvrVTR7IPSbHPyqmWfeH5zsivJMznkoURrl?=
 =?us-ascii?Q?X+glx8XFxfh8A/yEeJqU5RIxZarNrEjCHuyAV/Uc+Qy0OliPHkpHFE/vVYKk?=
 =?us-ascii?Q?Qc+yTEMzFpaHWKsaX0Bu6mr7ARlZO0MTO0poTWBZ1I5zdEVnm82DcIMGrc2I?=
 =?us-ascii?Q?odzJ9Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f7fcbfe-dc47-4d83-7e37-08d99e123f39
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 15:05:45.9516
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7mYeAQIDJjacZbWphooZ659fMm/u+K+FlZodNbJowdVwPRJ26aN/53gFrWCvoFCyCg6HbWg65sY96ffWWsMIX7NuGtiP/fHPEAyReaYjPEA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1615
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10156 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0
 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111020089
X-Proofpoint-ORIG-GUID: kgzkLIvATiXo48dBHQ8v-_w7kgltEj7f
X-Proofpoint-GUID: kgzkLIvATiXo48dBHQ8v-_w7kgltEj7f
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 02, 2021 at 04:45:20PM +0200, Andy Shevchenko wrote:
> On Tue, Nov 2, 2021 at 4:44 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Tue, Nov 2, 2021 at 3:10 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > > On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote:
> 
> ...
> 
> > > Run your patches through scripts/checkpatch.pl.
> >
> > While it's good advice, we are dealing with quite a bad code under
> > staging, so the requirements may be relaxed.
> 
> To be more clear: the goal now is getting it _working_. That's why
> this kind of noise is not important _for now_.

If it's a new driver, then we accept all sorts of garbage, that's true.

regards,
dan carpenter