Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 13:08:17 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        intel-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/29] drm/i915/gvt: devirtualize ->{read,write}_gpa
Message-ID: <20211102160817.GS2744544@nvidia.com>
References: <20211102070601.155501-1-hch@lst.de>
 <20211102070601.155501-14-hch@lst.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211102070601.155501-14-hch@lst.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ytTQz6QySX/kXYfiDGJV6MgJmMy3ZoESF5GgzWogPYcNaUPNBY4NvSLx71sJ?=
 =?us-ascii?Q?bKQ0mb/fL22Hgu7iGm0zy1IFJUB3+w6AkRD73ZFsNNtzIcOf6p62ZQj8vC5W?=
 =?us-ascii?Q?lpYcvv7fn5mse3fdwB3OaEa30B6dMEQ+dQC/2cXHsLyykB03VM+AmdWX46rN?=
 =?us-ascii?Q?OQJIpTEZP5kQeajHxoqFwwJ8Z2nscz6MlHmmPmQPH3h+UELgTQdUESAIC8v6?=
 =?us-ascii?Q?SwOMBsuqv51uyNo7ez9TWfLYe2o1xn/gv5EgNbVR4atLTtcUSIihU6BjMA7b?=
 =?us-ascii?Q?71oGjasAIb78s2cA9SB11iOqiGvA8KHm/uyDLZFPbcioGK3koCzIowPtps2G?=
 =?us-ascii?Q?/n8p4AHdNYGFLSoPIEr8VmbziYxwpMk3f/NfD1mfp32ixkHkPmL6A2q/Vefy?=
 =?us-ascii?Q?qQD4/Awy29nMmx8EBqFjeC/vDpgxXO6B+GB6Zr/hKGZZ5zAbuysqXEPFDDCX?=
 =?us-ascii?Q?5PgE/1TNTboHK9UAC9UDYl3cilrdK/eijLLF5GFwIPjKjXVTj7i3ky+gIKKG?=
 =?us-ascii?Q?qOlIFV6TK8qXV82Bf8QOEA86ALNemjQSb4Shu3L6ZLUtZXTV1DGhm3GEYEh4?=
 =?us-ascii?Q?tcv6SDqthu8AF6OUE8RS8SD6uPPSf7rIB945UaiQpG/qwPoGOncAPpj25f2Y?=
 =?us-ascii?Q?ialjwfVy8moDk4WwCiyCD4I3NeJ7hwdvLCUS1wMB04zpcsnR5L5O82Ms1Eto?=
 =?us-ascii?Q?FJUQnsu6Ddg2aW5ZLf0MqS6IhdpZYp3d4C7MC0lQzDWFwW/mbcXTaQeVS6ki?=
 =?us-ascii?Q?ujSMNZgkqBRAiS1eQqbsqjeePOVnBcFOmwQ/0M/6eoZb4GdB6tyEdr6jL2iQ?=
 =?us-ascii?Q?S80jZ48xLrArDXMrEPvhmm7c8txIQIahvRbDPXpOKdiWi93p4AiMdd2O+QTX?=
 =?us-ascii?Q?SJ/QhxF/cMtEOnDa49qwCB0Aqp7YrjvNrNXX/JI2iwy96OTwagW4aewLlVN9?=
 =?us-ascii?Q?4LnjfvSPZgj67wUqlCV9qzElot0N/3548mmiJiGzginEPgrrgkkjSHGVdzLD?=
 =?us-ascii?Q?q67a0PlKK546z/3ZQUbusNo+/jiAa+riThRSivu9mxhET85xsfTmsk193KfF?=
 =?us-ascii?Q?JP7Vc0psDdjSWTfBvgGAxmtYbC8YmjH2ZERXDNN8ECot8GYyM/GGzOwJeVWA?=
 =?us-ascii?Q?OScszqAU9APTl3ucQANHbob+bWBssqRkw8pY/zVnHH+UCOR6sbHcRduWfm7q?=
 =?us-ascii?Q?bMMHdaZDChGT1+ln7U71VNKXJebs99tRihUTrBS42Y7aXsCeNZ4FVScjoTPt?=
 =?us-ascii?Q?pcXYlFZXE2PiV1iTfzU80ago0SG7whnM7p60CVbJrkgQrmRtMNJelHOVa9Mv?=
 =?us-ascii?Q?FN7Dw/U+gxMYIGxS9weYKNxW0Q7e//tLsDV6Ph3v8o92o2vGZuccM+YaOwL2?=
 =?us-ascii?Q?1CAXSwoR2psvhlvA1+lKADcn0zwnx22T3xxj3FziYmX7wO8f4iXQ2hmqDOOQ?=
 =?us-ascii?Q?zSJkXjWgWnZ8aWfRrQNhoMpLMyMyCYnS3oi0hAQl9DYXjYNfgEi3AZkHXimz?=
 =?us-ascii?Q?GVChQWL6jX6mJQ8HTqj0tN1IhXwWG9jly0N7IMCaQdyMvJiiHa6lsiAjxBGN?=
 =?us-ascii?Q?wbg9gL+V7r0PqAu2tp4=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41815909-cb14-40d0-5f3d-08d99e1afc99
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 16:08:19.6651
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Oik2MGlQVFjSpZQ5+9Rqm3RiTvbmsayNbwrrF7K1iWUo0pi2u/81gsnXEKFzOacZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5554
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 02, 2021 at 08:05:45AM +0100, Christoph Hellwig wrote:
> Just call the VFIO functions directly instead of through the method
> table.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/gpu/drm/i915/gvt/cmd_parser.c |  4 +--
>  drivers/gpu/drm/i915/gvt/execlist.c   | 12 ++++-----
>  drivers/gpu/drm/i915/gvt/gtt.c        |  6 ++---
>  drivers/gpu/drm/i915/gvt/gvt.h        | 37 +++++++++++++++++++++++++++
>  drivers/gpu/drm/i915/gvt/hypercall.h  |  4 ---
>  drivers/gpu/drm/i915/gvt/kvmgt.c      | 23 -----------------
>  drivers/gpu/drm/i915/gvt/mmio.c       |  4 +--
>  drivers/gpu/drm/i915/gvt/mpt.h        | 32 -----------------------
>  drivers/gpu/drm/i915/gvt/opregion.c   | 10 +++-----
>  drivers/gpu/drm/i915/gvt/scheduler.c  | 37 +++++++++++++--------------
>  10 files changed, 72 insertions(+), 97 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason