Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4434787pxb; Tue, 2 Nov 2021 09:40:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWYOhAcMkm46+wtkDgCLlE+x5Na1WXI2oYSFhJwfh0357lTJRVOzdXu3ME0yjhkTVOPVNA X-Received: by 2002:a05:6602:48c:: with SMTP id y12mr26366086iov.184.1635871200415; Tue, 02 Nov 2021 09:40:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635871200; cv=none; d=google.com; s=arc-20160816; b=RFoL019tg1nwYM4bfv4AGD/leypDO/IcLyBFViQdlIL4klji/gY2goPTlPWDaB+1vS beTg90tEy73i3bTVGJRbJ5n2mvJ3LApkqt998SQ2/pWNlVk6rIH58K60hOv4I6Xp8EGR zAG2oqC18U6//JvdvGLn7krp1H77qf4f8o3LmVGLWlGReq+aWA8PolkpKSjTOwsjb1/G HzpS4Kd2IJwCNfdV166DQ72dr8qLrwXW09A8vM6WoLyAayd5EDphOWOgsWhm+RycUhou LVdiaPGdMdMmJPUtJ7xfB6p2XCPVs15yDTPL32MgE+RIHwpbPMeMtYNDDfmo2KwYslL6 IXbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=7nyVmI1mw9hsrpGGFASoS9zmXwbZwXMt3G3NBwpCKoI=; b=jLD7vXRdrGNLzi8nFxBEsjhLy4FAHbo99PqQNb/0e2ONUWzXgPbX9yPkhiJ/53riPW Eq+l6PuACvUr7DHmrGq45+n8cLr4SpF3fkYCAFfrm19ihsJwuakeK/0+plPXvCjaVX+s HMn9PijgZnuW4dxiUMypPRLEoTcjhbWbSNU8UZxKIT/qhrQvbHpeinnawbky9tCVx26L veyfO0PdgtD/UKtqDkyFtJox1oUcHKWUe0R5eOd+yFeJXICrwQ+64+28+ZqrWYq8mXrS EL1+i0NNzwvKuscghia9NBFxkK3jImCi0cGMg/RXcBORrFBujLVMgJ84oNhLPFuUYNXP 6nDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=oxpUqcVU; dkim=neutral (no key) header.i=@suse.de header.b=ap4V+wyZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k10si28528221jad.4.2021.11.02.09.39.47; Tue, 02 Nov 2021 09:40:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=oxpUqcVU; dkim=neutral (no key) header.i=@suse.de header.b=ap4V+wyZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234879AbhKBQkp (ORCPT + 99 others); Tue, 2 Nov 2021 12:40:45 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:32892 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235079AbhKBQjz (ORCPT ); Tue, 2 Nov 2021 12:39:55 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9297A212C8; Tue, 2 Nov 2021 16:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1635871036; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7nyVmI1mw9hsrpGGFASoS9zmXwbZwXMt3G3NBwpCKoI=; b=oxpUqcVUqOdx58uNgbc5N6ILlWgD3iJ5JPVwc2mdzgH+1mj50dvEB5b+/uhhjl1TRp4gBu LqFrZ2K4t2GlUf0LdITJXWcCqKYJmqnEd8YJ6PgxhFZwI0AAMs5q04OFKDqkXCyB+mTm9w KVRl2sit9AWi35m02eH2qPy1jDHOqoQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1635871036; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7nyVmI1mw9hsrpGGFASoS9zmXwbZwXMt3G3NBwpCKoI=; b=ap4V+wyZXiSnHi24Hqmm/NJJvV092FZptqOKrb38V8qzI3Vs9bcV3t1Y6DRPVnoyqcb2wL AceBPKZEc9ueKnCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 949F313BB8; Tue, 2 Nov 2021 16:37:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id i3BsIjtpgWGhcQAAMHmgww (envelope-from ); Tue, 02 Nov 2021 16:37:15 +0000 Date: Tue, 2 Nov 2021 17:37:13 +0100 From: Joerg Roedel To: "Eric W. Biederman" Cc: Borislav Petkov , Joerg Roedel , x86@kernel.org, kexec@lists.infradead.org, stable@vger.kernel.org, hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , Kees Cook , David Rientjes , Cfir Cohen , Erdem Aktas , Masami Hiramatsu , Mike Stunes , Sean Christopherson , Martin Radev , Arvind Sankar , linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 01/12] kexec: Allow architecture code to opt-out at runtime Message-ID: References: <20210913155603.28383-1-joro@8bytes.org> <20210913155603.28383-2-joro@8bytes.org> <87pmrjbmy9.fsf@disp2133> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87pmrjbmy9.fsf@disp2133> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 01, 2021 at 04:11:42PM -0500, Eric W. Biederman wrote: > I seem to remember the consensus when this was reviewed that it was > unnecessary and there is already support for doing something like > this at a more fine grained level so we don't need a new kexec hook. It was a discussion, no consenus :) I still think it is better to solve this in generic code for everybody to re-use than with an hack in the architecture hooks. More and more platforms which enable confidential computing features may need this hook in the future. Regards, -- J?rg R?del jroedel@suse.de SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 N?rnberg Germany (HRB 36809, AG N?rnberg) Gesch?ftsf?hrer: Ivo Totev