Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 13:12:11 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        intel-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/29] drm/i915/gvt: devirtualize ->{get,put}_vfio_device
Message-ID: <20211102161211.GT2744544@nvidia.com>
References: <20211102070601.155501-1-hch@lst.de>
 <20211102070601.155501-15-hch@lst.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211102070601.155501-15-hch@lst.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?F9Younx7ZJcHVzUhHsbnIXImfQWIcf0wv1qKA3v8zXcw8ytKudBLStHnY4wY?=
 =?us-ascii?Q?wHeqGln6zB+PUfWqzAYD+nCLmxwTZ4/KVlYML93myb8rQuGk/cLFDLsttbRT?=
 =?us-ascii?Q?X86YoAsvR30bs9jyllfzKjgTvSRb31Sa0uur86X6GugxOk2NEfAKxWoArNfp?=
 =?us-ascii?Q?/KCROB8I768d4UVNcwCDeZ1JDtFt25A3kFsGaEw60Zce9Vr9YAyvpnJ53xD+?=
 =?us-ascii?Q?PgBNJzlHuYZvwI6schrCqvaLqsPH2CAh4MvGUQPetxyCrSG0/eqxREljFNGh?=
 =?us-ascii?Q?lLvneBswMX1R0FrHCF59yu3OGPPwG0imbDkHeOj/Qb0qNv/EiHiyyol5sqwq?=
 =?us-ascii?Q?pGeG7kEzjziUKc0C0RoNYu1GJfiQ77JH6dkx7iINX2f6y5wM387yjq5v6VM0?=
 =?us-ascii?Q?0KGHCOXoi5/MQPbtm57UZy8fUR+VUsnylxrQEVFDcapviLsy89nPU7RMHELQ?=
 =?us-ascii?Q?qt3OJGeJLc43TOuPZbo6snMk7vovAIO61v2BT86t4cZV7i3O00/6Fh4SG2lD?=
 =?us-ascii?Q?6MSj5ulsR4/4IeMpkl7ktdKQAGwpG2s/iHZTgzBLcnqi86mB0X4MziIvSVNw?=
 =?us-ascii?Q?UvPun+9RAIWA33lOQBsvRMHCS/+BH2ZeaggVW6REcpMk3oPSR7RwCEKJadqB?=
 =?us-ascii?Q?kNm9jG3z9lS7nD3o9GbLHBn816mpxY/Etkmqc30/UIeHeoSXRbMZU9UiZF8Z?=
 =?us-ascii?Q?vA3fx8rgVl9vD/uNRt8URCjDRwO7UInc8jo0bMZyJcQ5lRBoylMVo3iVsNOu?=
 =?us-ascii?Q?xIsP4z5zTWwSTh6OIBskBDe4/1tQOaJcPLEeZQrPKWFGH9k8b/mf57i1HOlR?=
 =?us-ascii?Q?uVicmBve106EGOvSoZoUBi5uacjCjNZ/+047+o9xHR69QXbb9THsOKr+6qys?=
 =?us-ascii?Q?6gqREu1I+c7O8M16e0SlWT9SvwMWvipmQ7GWLsBHYLVrjZu+j+VuMqMopqPp?=
 =?us-ascii?Q?rpo9tdPgX3t5893sh08+955oZQ7o1iHHvpmW5asGYvDXKlI7f21gepTF2ln/?=
 =?us-ascii?Q?SmjbTMzeWrcbuz29FaorSGZepKdlaZ76oUQPTOA+3gCM92jcmtexSB9LKKuU?=
 =?us-ascii?Q?AZ6ZTXDGlMUtWoYpJWng3DDUPIrWYV7qVNvkAq7GsuAYVhGRPEVl/ppUDGSQ?=
 =?us-ascii?Q?pYej1G8M8ArQ+5dpJz68fcqBxbsZlhBGoUfiVuUa/+1COIN4iJzZLjeNVhO1?=
 =?us-ascii?Q?6BHvUYmKZ5LPeYt3e+fqvquIA7QytUTqPtnsu0dHvexip0HL+g6DJgZti75Y?=
 =?us-ascii?Q?lZHgUcIbfARtbiAtc6HAtwpUp5Zoz6afaBlAVSmkRwe8emQujhBJfQxpGtq2?=
 =?us-ascii?Q?PWYzxaRKrshB/fbqpsgJp65VtejbS6WTVieU/Gc2tdRTbNpFc7tHtGUPZbHq?=
 =?us-ascii?Q?BH8NGTPgjl+0U04Hp4mIc/TOknJBrZ1kVWqh0G29Xir+U2B8e5gkb132HMyl?=
 =?us-ascii?Q?gLI0nVMgJ9whAdhq0giBYyZKp1bv06B5Xbxr9tobzdc4BGws3cSmOaZQl6hK?=
 =?us-ascii?Q?beQneSfrFgyfz6DQq4weWGxL5hDuNW9Vo/Z/L3qt26eWoUZymSVE26+DkjqA?=
 =?us-ascii?Q?CAXRTrWPmw9Gb1n90JM=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7dc1eb46-6452-4174-e470-08d99e1b87a5
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 16:12:12.8151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 24R3dsD0KsqWXS9J7JiiVEHihIudtfFqB+4DQDDQmIpBVl8eeOlhP4a4wk2oWo0l
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5286
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 02, 2021 at 08:05:46AM +0100, Christoph Hellwig wrote:
> Just open code the calls to the VFIO APIs.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>  drivers/gpu/drm/i915/gvt/dmabuf.c    | 12 ++++++-----
>  drivers/gpu/drm/i915/gvt/hypercall.h |  2 --
>  drivers/gpu/drm/i915/gvt/kvmgt.c     | 22 --------------------
>  drivers/gpu/drm/i915/gvt/mpt.h       | 30 ----------------------------
>  4 files changed, 7 insertions(+), 59 deletions(-)

I suspect the use of get/put here is very questionable

It only prevents the vfio_device from becoming unregistered, but the
main thing a mdev should care about is if it is still beween
opne_device() / close_device() - ie the FD is open, there is a SW
IOMMU available, and memory pins can be made.

Still, not for this patch

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason