Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Nov 2021 20:40:28 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     LABBE Corentin <clabbe@baylibre.com>
Cc:     mchehab@kernel.org, hverkuil@xs4all.nl, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev, mjpeg-users@lists.sourceforge.net
Subject: Re: [PATCH v2 04/10] staging: media: zoran: add debugfs
Message-ID: <20211102174027.GK2794@kadam>
References: <20211013185812.590931-1-clabbe@baylibre.com>
 <20211013185812.590931-5-clabbe@baylibre.com>
 <20211014073752.GM8429@kadam>
 <YWyB8kwsqAvHMuhb@Red>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YWyB8kwsqAvHMuhb@Red>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?lq8+Mcka58hxmcSKGbJFrYD8Aa1hRGtEQJwh1bKyX/u7sncE72S+2rZK6H?=
 =?iso-8859-1?Q?/mAOlFevgsXxs4j1AZEeVewetlStZPVApVUx7fHKygIG7AsWxzo6nSpVhO?=
 =?iso-8859-1?Q?xC3euvlJN9+P00Guy4Fi6h4JpkhaawdRcAzG2U+tnAb4ygAsGpfya9ArfN?=
 =?iso-8859-1?Q?M4EkpQDCSQuH/gLP9wGBD+NjTSs9g6psijH6nN15Mm3dk48ksz6hK6jJRK?=
 =?iso-8859-1?Q?6ueIz0SR0qxVuDmblNTPuT0H+8TGXa98R9qvVeRb787nbh48C2PhAEW4cC?=
 =?iso-8859-1?Q?9BG45nPs7rTHea7DeDr8CkiDBcmgQtxqfFwmyFy2I1HfKwUADHNRgl+KIx?=
 =?iso-8859-1?Q?qMxFWCCbAwlRPIx19psrn7SqdQu35QiS1nlHY+ns9RVVuXOP4R97Z7hrFn?=
 =?iso-8859-1?Q?agao9Z3Z+XIb+sauDAtP7V9vHQFGmJii3hBZLA5aWgQGRh6Q9HPHB+UBpk?=
 =?iso-8859-1?Q?gOgs5ycRMgsCkYS9UPPGpOU/Aw6EGHeWRzLr+YRgMJ44O0uiOLhYaQKJIs?=
 =?iso-8859-1?Q?+b5Ev+OfWXzhILSMctaFMocmHlNW5k4SY563/svnrj2J+e+Vj5lb3vnR0b?=
 =?iso-8859-1?Q?NvcF7j8vE3U6P4MeGzIae0RW8avMXS0I1AYClwtju3ekzhlVKjg8yApuin?=
 =?iso-8859-1?Q?iVkUDTVQ74NT6TJXvGCfkvs+QtYmPla/SRcQTSqHxuMby/pwFncNvhtkVo?=
 =?iso-8859-1?Q?5Zvt3ump3UZJQkyu+ojLN27caHMVVqM3Git5O5RrXBHv/hdg+WE3ezyJ+N?=
 =?iso-8859-1?Q?TOAneCS/a0rX3thgRKQ5HtMHblPjMR0akq4Isivm6m9DYsY/umkzj4MuZO?=
 =?iso-8859-1?Q?gBkjvcoxtlsJAFOWD6RajjdxIgCW8dpWT1r9FqABeG0QzDwfJuE39a+F9A?=
 =?iso-8859-1?Q?bJChEa2KsLUY7Ja0EZ64bQOd3JgV9mEgVNe5o/iZhZf4bXwhJSrDTPZrir?=
 =?iso-8859-1?Q?oiRYffqS4qtaGjPTGinJprZswKvUpSqMDZxHgwtWdkXbXtXQUIjFFqHZ7j?=
 =?iso-8859-1?Q?e4qlot65VkoWl6Cd0Ae6246BSJl1gVfc8hXArRy9ZeMrJejuKdH/Xt/aeq?=
 =?iso-8859-1?Q?GwoHTevB6JmvpYTf75VV82c6OCE6sAA0BvKJwKrZd/TLiiL0LA/c+iMXQX?=
 =?iso-8859-1?Q?E41kPlbJS4gN8FsVvr/U7mra3jThE0po0bjjgkmHWmzFVCRDA3Tr1pbMeb?=
 =?iso-8859-1?Q?Rr72LbbpCjzdtqtpm8FZl1N4j0G703XidS5ZKjocVsqOwg+YFLoDOTulb1?=
 =?iso-8859-1?Q?OuXbh6vMv7hY8diSZHHHiIOLV0yV2lmv2b9EunAUF5wdEHiKsITJjQyR2B?=
 =?iso-8859-1?Q?bIdzbbwYgrAleTBMxY8P76lMd+ynV4ETk0WDi2VLwWITSgcJ4sgrqU1jA3?=
 =?iso-8859-1?Q?QNl+YNoZNvXlKLZbJ90XaellmIrssAkmnU0HbfNl9Ar8MKoh1KaIUie0xJ?=
 =?iso-8859-1?Q?W1mBPGfrcwiEVgoh5Arxs5p0F94PJXHYuBJcF/WsEPRkTTT6Bp9oArS3dh?=
 =?iso-8859-1?Q?YuHDIFwWdV/RefhZztx7WKHqUuHZxmODxGeAa4qTgeoIkf9mJYt/DE7O0p?=
 =?iso-8859-1?Q?hvv/R1KfooRNO3Pt105AB0UbFpZx/6SiZ5mmj8DvzgioclkdSB+C8JdAp1?=
 =?iso-8859-1?Q?lcXQXSr64gQVRx1ONwzaRDeMifkyA9CW6mCSFzmzeaVUINapGTCT10rQqt?=
 =?iso-8859-1?Q?AH4koVHaUFRb2v/LW2zPaFk8Lq/sCOW7c1kDOfQE8/J7KqEeYALRlirjhk?=
 =?iso-8859-1?Q?grUw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad627bf6-289b-4751-59c9-08d99e27ece9
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 17:40:56.8932
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w97YDfstUubHlQLmiIsfnMvTI/+6siirS3G2hCUmD2fV+/vcaH+DCjeiHIeP+uZnhxBzFxZy9rGHn1sqhtHbqjtxGr4Lb1TmjPFCWQS0D3I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5412
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10156 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 malwarescore=0
 mlxscore=0 suspectscore=0 mlxlogscore=632 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111020099
X-Proofpoint-GUID: rxut2FgLRUpquLV3c-Xr0kSOcAXH2_Nc
X-Proofpoint-ORIG-GUID: rxut2FgLRUpquLV3c-Xr0kSOcAXH2_Nc
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Oct 17, 2021 at 10:05:06PM +0200, LABBE Corentin wrote:
> Le Thu, Oct 14, 2021 at 10:37:52AM +0300, Dan Carpenter a ?crit :
> > On Wed, Oct 13, 2021 at 06:58:06PM +0000, Corentin Labbe wrote:
> > > +config VIDEO_ZORAN_DEBUG
> > > +	bool "Enable zoran debugfs"
> > > +	depends on VIDEO_ZORAN
> > > +	depends on DEBUG_FS
> > > +	help
> > > +	  Say y to enable zoran debug file.
> > > +	  This will create /sys/kernel/debug/CARD_NAME/debug for displaying
> > > +	  stats and debug information.
> > 
> > Why bother with a CONFIG?  Just make it always on?
> > 
> 
> Hello
> 
> I love to provides choice to user (and so avoid a dep on DEBUG_FS), even if I think I am the only one remaining user.

Sorry, for the delay, I was on vacation.

No, there is no depends on DEBUG_FS in the method that I am describing.

How that works is when DEBUG_FS is turned on then it's on for everything,
but when it's disabled it's disabled for everything.  You do not need
the "depends on DEBUG_FS" and if you make this an option the it feels
like it should be a selects DEBUG_FS instead.

How this normally works is that when you have debugfs disabled, there
are dummy files in the debugfs .h files.  I bet the compiler can tell
most of those are empty and removes them.  So if you have DEBUG_FS then
it doesn't use that much more memory than when VIDEO_ZORAN_DEBUG is
disabled.

I don't know if I'm being clear at all #jetlag.

It should be easy to check.  Just remove the "depends on DEBUG_FS" and
enable VIDEO_ZORAN_DEBUG.  Disable DEBUG_FS.  It should still build fine
because of the dummy functions.  That's build 1.  Then disable
VIDEO_ZORAN_DEBUG and that's build 2.  See how much memory difference
there is between 1 and 2.

regards,
dan carpenter