Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965088AbXADWxG (ORCPT ); Thu, 4 Jan 2007 17:53:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964820AbXADWxG (ORCPT ); Thu, 4 Jan 2007 17:53:06 -0500 Received: from e34.co.us.ibm.com ([32.97.110.152]:60244 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965089AbXADWxF (ORCPT ); Thu, 4 Jan 2007 17:53:05 -0500 Date: Thu, 4 Jan 2007 16:52:53 -0600 From: "Serge E. Hallyn" To: Valdis.Kletnieks@vt.edu Cc: Frederik Deweerdt , "Serge E. Hallyn" , Andrew Morton , lkml Subject: Re: [PATCH -mm 8/8] user ns: implement user ns unshare Message-ID: <20070104225253.GA3087@sergelap.austin.ibm.com> References: <20070104180635.GA11377@sergelap.austin.ibm.com> <20070104181310.GI11377@sergelap.austin.ibm.com> <20070104190700.GB17863@slug> <200701042223.l04MNZB2002002@turing-police.cc.vt.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200701042223.l04MNZB2002002@turing-police.cc.vt.edu> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1182 Lines: 31 Quoting Valdis.Kletnieks@vt.edu (Valdis.Kletnieks@vt.edu): > On Thu, 04 Jan 2007 19:07:00 GMT, Frederik Deweerdt said: > > On Thu, Jan 04, 2007 at 12:13:10PM -0600, Serge E. Hallyn wrote: > > > From: Serge E. Hallyn > > > Subject: [PATCH -mm 8/8] user ns: implement user ns unshare > > > > > > Implement CLONE_NEWUSER flag useable at clone/unshare. > > > > > > Signed-off-by: Serge E. Hallyn > > > --- > > > > > int copy_user_ns(int flags, struct task_struct *tsk) > > > { > > > - struct user_namespace *old_ns = tsk->nsproxy->user_ns; > > > + struct user_namespace *new_ns, *old_ns = tsk->nsproxy->user_ns; > > > int err = 0; > > ^^^^^^^^^^^^ > > The "= 0" is superfluous here. > > Umm? bss gets cleared automagically, but when did we start auto-zeroing > the stack? No, no, that's what i thought he meant at first too, but I actually manually set err on all paths anyway :) -serge - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/