Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4644732pxb; Tue, 2 Nov 2021 13:17:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXv2w1prPt62q4QfFnfIeNJwym8SrrmL9sJSoVmbVjv0E5IseIGJYFAZzskQAFHzgjx5a+ X-Received: by 2002:a05:6402:26c2:: with SMTP id x2mr6746335edd.198.1635884272572; Tue, 02 Nov 2021 13:17:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635884272; cv=none; d=google.com; s=arc-20160816; b=mnecZhhGU69C6qtlz0zFVDhwg+NYBgLabIZA/I69gn/+Gg+XEEvtvTm0JGX3REsQ4U sBe7uOjO6xjjBO12Rj6mv+jGNiiuen4j7AagdAUSULOIjn0+ofkLJH8aCWlFjUTSrnEl CYu4kTcsd5P+iY8yzQwOGAavE/C2zOzl0l2xVrnnMUvfcKsKUHGsRC0Hdza7rpvG6gUA uZf7eTT/1UVy+NjbhG7Dx7ajRTpSBXAFH4d2I3yH2nIN0C0MkIKBXbG0iPZKZUGOSxJ1 u/EPvIhdvgp1GTcGpqke7Z62YO/J09xbdHUlecHUadv3JsgUwTB/NblxjItwlkV9ZOmV 8PAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=PqKC2t1Z5DmsnmpUEFoy3liKWP90tFs8sH60erHgihQ=; b=xBFjCi6zOcEd29jXh+vywWuu1dqPuAJNuQiUxB68g7KD63dpAOv4wpVXvcTQ20ttl0 6EwL/KJ2rllxkITawg/2DIBwPOjtrXVE+osr0qiWXzkH0scsVUkrVOUTUyCgz8hTppL6 Q3V9IHqDffQVEAr550k3561E18rqNM8FyZdBIJVdtSNr3pi2whHrLuAcK4cUFy8yfRln r1OCr5KAIqSmCWfLXFzpS6sggrHtn34uJrnDNzeBvaFNgISjaXfIpmOTvg+3nz2TjqhD 8ynhtjwjAsxDrKz7YgFmrSYKLLaKwVpbxrX0UejJFljtv8D+9VT3X54gK99qdQhWRoer JiIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=fEzLluxt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t12si29391edi.312.2021.11.02.13.17.28; Tue, 02 Nov 2021 13:17:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=fEzLluxt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231379AbhKBURv (ORCPT + 99 others); Tue, 2 Nov 2021 16:17:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230060AbhKBURt (ORCPT ); Tue, 2 Nov 2021 16:17:49 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 447F8C061714; Tue, 2 Nov 2021 13:15:14 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id ee33so1591480edb.8; Tue, 02 Nov 2021 13:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PqKC2t1Z5DmsnmpUEFoy3liKWP90tFs8sH60erHgihQ=; b=fEzLluxtpVt49nA4nW9VmHwOB8olNv+cr8vCPFXRg0BkU9xXcs+9xohjH/dbJb/JZm Jn3Q3DM8vHyiyVHH9L88UrLBov1G/x2g9AS8+xnhPdqgsW3BSmt0mE0+OlmkbrDrd0jp 9LhOL8TleGNjvJ8eV+5+vmURHblBY/BVRfriYPyvzd8G/vkEED7FSUuW1YE22Qfbf+qg jaNSsvv5/ym05HE998urmd/1qGbYVG5FTeSoz5dM7zj779osugHcFdEe8INh9MBGEafG RUGhXbDGYgkziz96URb0Gr84f6OovpS6941kwHY0lsVhfWJNPA2rtK8XlwpQjnxrR9PT kDjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PqKC2t1Z5DmsnmpUEFoy3liKWP90tFs8sH60erHgihQ=; b=fUgb6F/H2CHsjqnm2CtZxT9pZjkonJxxVSE3KZsDrsPwR4Y+ofRFAcEXIlk5a5L5hP K4gnH4OtO9J5YKN9Mp5SESn/WSUpWYaAF5UE5IOw5O+zltOWBPpXQoVvNRUAxThosLB0 mqdCxdASor+jfjJkRoMn3fmFhftc026iHUIj/DvTCLAA822qzTwPoupFVq3JW1fM4f3i HbhL41uaNF47Xsc31RIaylYVXZ5O6wUiH4fusMgSy6p7Hlz3wOdlwPS/JRriyh/2Jn1i Cw28vPpbVROTaB6OmVPQrXEWAzIRnV6PGy5cNW8ErjkirwKL7hL0WUspqARvmQr/rq6x iVKg== X-Gm-Message-State: AOAM531tsuz2pwsT5x4P0tOBQeXHsJ4MKjShQRB1YqukBSXHYWG1RdRr +g3B9+wzJnSJJYx5HWAmQ3/jCH/Rq/1MnwACYeM= X-Received: by 2002:a17:906:1707:: with SMTP id c7mr47407307eje.377.1635884112761; Tue, 02 Nov 2021 13:15:12 -0700 (PDT) MIME-Version: 1.0 References: <20211102161125.1144023-1-kernel@esmil.dk> <20211102161125.1144023-15-kernel@esmil.dk> In-Reply-To: <20211102161125.1144023-15-kernel@esmil.dk> From: Andy Shevchenko Date: Tue, 2 Nov 2021 22:14:23 +0200 Message-ID: Subject: Re: [PATCH v3 14/16] serial: 8250_dw: Add StarFive JH7100 quirk To: Emil Renner Berthing Cc: linux-riscv , devicetree , linux-clk , "open list:GPIO SUBSYSTEM" , "open list:SERIAL DRIVERS" , Palmer Dabbelt , Paul Walmsley , Rob Herring , Michael Turquette , Stephen Boyd , Thomas Gleixner , Marc Zyngier , Philipp Zabel , Linus Walleij , Greg Kroah-Hartman , Daniel Lezcano , Andy Shevchenko , Jiri Slaby , Maximilian Luz , Sagar Kadam , Drew Fustini , Geert Uytterhoeven , Michael Zhu , Fu Wei , Anup Patel , Atish Patra , Matteo Croce , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 2, 2021 at 6:44 PM Emil Renner Berthing wrote: > > On the StarFive JH7100 RISC-V SoC the UART core clocks can't be set to > exactly 16 * 115200Hz and many other common bitrates. Trying this will > only result in a higher input clock, but low enough that the UART's > internal divisor can't come close enough to the baud rate target. > So rather than try to set the input clock it's better to skip the > clk_set_rate call and rely solely on the UART's internal divisor. Bingo! Reviewed-by: Andy Shevchenko > Signed-off-by: Emil Renner Berthing > --- > drivers/tty/serial/8250/8250_dw.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c > index 53f57c3b9f42..1769808031c5 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -414,6 +414,8 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data) > > if (of_device_is_compatible(np, "marvell,armada-38x-uart")) > p->serial_out = dw8250_serial_out38x; > + if (of_device_is_compatible(np, "starfive,jh7100-uart")) > + p->set_termios = dw8250_do_set_termios; > > } else if (acpi_dev_present("APMC0D08", NULL, -1)) { > p->iotype = UPIO_MEM32; > @@ -696,6 +698,7 @@ static const struct of_device_id dw8250_of_match[] = { > { .compatible = "cavium,octeon-3860-uart" }, > { .compatible = "marvell,armada-38x-uart" }, > { .compatible = "renesas,rzn1-uart" }, > + { .compatible = "starfive,jh7100-uart" }, > { /* Sentinel */ } > }; > MODULE_DEVICE_TABLE(of, dw8250_of_match); > -- > 2.33.1 > -- With Best Regards, Andy Shevchenko