Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4654883pxb; Tue, 2 Nov 2021 13:30:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8dPy2qsygKy1nvo1G6R/bnQ592af2JyQJWLMCAiWG2q1hPajXNFEz+sZSqosjTxWWpdv4 X-Received: by 2002:a50:ab44:: with SMTP id t4mr44599484edc.105.1635885030045; Tue, 02 Nov 2021 13:30:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635885030; cv=none; d=google.com; s=arc-20160816; b=zlQJ9fU8kCDDcqloB7RY3GvTsZhuxd8Q2/3PRTkAhGfbPl8jnkS6ZZHa+K0kEhhH7o 4tGMa4nd1uSy2nMBVtOmx2dKogqKH4dEZBRm/SzBbP9zsp0b+VBLkhZq7jcEo39St2kL YR2hB89i9denAQ7Gnf8s1VwBCjbQ5YJnNzZTpQJLVfI+QXoL6ESkOv2ABNja7bHdTglh BDApa+PS0YVcQ8iKy8S+5ODVQTUh0+KXnNQ5PK75PAH/sWkLPHGxAkcQsS2qiHeCdhtM SdDkIlN5M/u49Hc+4YlqScyzs+XTuGBtNjZwV04L8lgdCfyEWSyW05MksaGSeARUq8/l nxXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TwAdYSvQMjSkM+QbGzkxmC3xOEssRxXLA7w8gBqLwCI=; b=aAyHaCMQjrEY7xVZBqjFOpqtiF2N8SQ7kTdhVTv+UGXWN960RQW6AAR6ZLBiW69TCW IZGqsWIZY6/wC2hGyYOMPtCQfQ2+6ZH+otbOuaxAc94SKUJcFKZQnzXsj9i0fTpbdeBw mDedAJThxiTj0p6KFaG+TkE56sDe4n2gM+rWruAdGaVKmiYDNLYkgQ25ZGFjfR1xUY0H Atlk4P9N+9jLjbJZ/Dmaq1haVap9zWbniu+WRXCQpcDYlSUFcff5POH6xp3P6xI+D5E1 yiNhLvwF2g9DC232IPbberWJ0idVYGP7DY/F89/YEjQ2p4aJUXYKuFGnDIrgY4+lMRa0 VGzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vtz5jC+f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si74436edf.101.2021.11.02.13.30.06; Tue, 02 Nov 2021 13:30:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vtz5jC+f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231433AbhKBU2Q (ORCPT + 99 others); Tue, 2 Nov 2021 16:28:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbhKBU2P (ORCPT ); Tue, 2 Nov 2021 16:28:15 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18C69C061714; Tue, 2 Nov 2021 13:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TwAdYSvQMjSkM+QbGzkxmC3xOEssRxXLA7w8gBqLwCI=; b=vtz5jC+fhEx+jAidmWR9mVihx5 yawM+y2UNbGb3c++cN8NYK0a2SYFvhxdlPKHSktgkHLXJMx+6yM9KNwt2ZUyE8tdpJgYvM8lhxvbO Kv4Ft+9JCt279hDjGVezQKrMuDt50XkWhW5cwe+mFb/4vFNE66FGYE11XhNLJSLDGhK1SqrZeJSvn CLMHAloBtDWwd1Pa3DYPfngGgG9OHPk0KQfloEAnmV0Kk3niyBu+cVI5+RYooBok6vktETzZ4/mRW ATcmnTYSK6FEBMlPWTur/WvoRYf+1CxTJKVFgSDYTCAPQBVrWhM1t8F4Ldy5ehYz/Ls4t96yAuopn 5kMeFWOA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mi0KM-004kCi-0z; Tue, 02 Nov 2021 20:24:30 +0000 Date: Tue, 2 Nov 2021 20:24:14 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Jens Axboe Subject: Re: [PATCH 03/21] block: Add bio_for_each_folio_all() Message-ID: References: <20211101203929.954622-1-willy@infradead.org> <20211101203929.954622-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 02, 2021 at 12:13:22AM -0700, Christoph Hellwig wrote: > On Mon, Nov 01, 2021 at 08:39:11PM +0000, Matthew Wilcox (Oracle) wrote: > > +static inline > > +void bio_first_folio(struct folio_iter *fi, struct bio *bio, int i) > > Please fix the weird prototype formatting here. I dunno, it looks weirder this way: -static inline -void bio_first_folio(struct folio_iter *fi, struct bio *bio, int i) +static inline void bio_first_folio(struct folio_iter *fi, struct bio *bio, + int i) Anyway, I've made that change, but I still prefer it the way I had it. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig