Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211102084856.483534-1-zhudi2@huawei.com> <7511b8fd-c5b6-96b3-8b1d-e7eeeb0b2c33@fb.com>
In-Reply-To: <7511b8fd-c5b6-96b3-8b1d-e7eeeb0b2c33@fb.com>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Tue, 2 Nov 2021 14:16:13 -0700
Message-ID: <CAADnVQKKqnBJ+VjAFrWdM4BgRe4KdmeF5LYm9i96gZsr_urcvA@mail.gmail.com>
Subject: Re: [PATCH bpf-next v4 1/2] bpf: support BPF_PROG_QUERY for progs
 attached to sockmap
To:     Yonghong Song <yhs@fb.com>
Cc:     Di Zhu <zhudi2@huawei.com>,
        "David S. Miller" <davem@davemloft.net>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Jakub Sitnicki <jakub@cloudflare.com>,
        bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Nov 2, 2021 at 1:11 PM Yonghong Song <yhs@fb.com> wrote:
> >
> > -static int sock_map_prog_update(struct bpf_map *map, struct bpf_prog *prog,
> > -                             struct bpf_prog *old, u32 which)
> > +static int sock_map_prog_lookup(struct bpf_map *map, struct bpf_prog **pprog[],
>
> Can we just change "**pprog[]" to "***pprog"? In the code, you really
> just pass the address of the decl "struct bpf_prog **pprog;" to the
> function.

Di,

this feedback was given twice already.
You also didn't address several other points from the earlier reviews.
Please do not resubmit until you address all points.