Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210930085932.1.I8043d61cc238e0168e2f4ca5f4783223434aa587@changeid>
 <17d63b06-d1bd-85ab-92d3-71fa236b9493@suse.de>
In-Reply-To: <17d63b06-d1bd-85ab-92d3-71fa236b9493@suse.de>
From:   "Anand K. Mistry" <amistry@google.com>
Date:   Wed, 3 Nov 2021 11:12:25 +1100
Message-ID: <CAATStaMSFu=27LdxNOabtARGaRq7rm_k2BHSsZ9+M-fF+nnk7Q@mail.gmail.com>
Subject: Re: [PATCH] drm/prime: Fix use after free in mmap with drm_gem_ttm_mmap
To:     Thomas Zimmermann <tzimmermann@suse.de>
Cc:     dri-devel@lists.freedesktop.org, nartemiev@google.com,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Any movement on merging this patch? Not urgent on my end (we have this
patch in our tree), but I think other amd users might run into this
UAF.

On Thu, 30 Sept 2021 at 17:21, Thomas Zimmermann <tzimmermann@suse.de> wrot=
e:
>
> Hi
>
> Am 30.09.21 um 01:00 schrieb Anand K Mistry:
> > drm_gem_ttm_mmap() drops a reference to the gem object on success. If
> > the gem object's refcount =3D=3D 1 on entry to drm_gem_prime_mmap(), th=
at
> > drop will free the gem object, and the subsequent drm_gem_object_get()
> > will be a UAF. Fix by grabbing a reference before calling the mmap
> > helper.
> >
> > This issue was forseen when the reference dropping was adding in
> > commit 9786b65bc61ac ("drm/ttm: fix mmap refcounting"):
> >    "For that to work properly the drm_gem_object_get() call in
> >    drm_gem_ttm_mmap() must be moved so it happens before calling
> >    obj->funcs->mmap(), otherwise the gem refcount would go down
> >    to zero."
> >
> > Signed-off-by: Anand K Mistry <amistry@google.com>
>
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> This looks fine to me, but it affects many drivers. Let's maybe wait a
> bit if more reviews come it.
>
> Best regards
> Thomas
>
> > ---
> >
> >   drivers/gpu/drm/drm_prime.c | 6 ++++--
> >   1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> > index 2a54f86856af..e1854fd24bb0 100644
> > --- a/drivers/gpu/drm/drm_prime.c
> > +++ b/drivers/gpu/drm/drm_prime.c
> > @@ -719,11 +719,13 @@ int drm_gem_prime_mmap(struct drm_gem_object *obj=
, struct vm_area_struct *vma)
> >       if (obj->funcs && obj->funcs->mmap) {
> >               vma->vm_ops =3D obj->funcs->vm_ops;
> >
> > +             drm_gem_object_get(obj);
> >               ret =3D obj->funcs->mmap(obj, vma);
> > -             if (ret)
> > +             if (ret) {
> > +                     drm_gem_object_put(obj);
> >                       return ret;
> > +             }
> >               vma->vm_private_data =3D obj;
> > -             drm_gem_object_get(obj);
> >               return 0;
> >       }
> >
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
> (HRB 36809, AG N=C3=BCrnberg)
> Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer

--=20
Anand K. Mistry
Software Engineer
Google Australia