Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4863901pxb; Tue, 2 Nov 2021 17:41:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDJH0QaY2jHe9LSdieU58BETzzV7uZyqqmogTEGFkX+eKjkc0ZGjayzyY/0fuvGPOLYubf X-Received: by 2002:a05:6602:2d0a:: with SMTP id c10mr15825483iow.186.1635900092049; Tue, 02 Nov 2021 17:41:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635900092; cv=none; d=google.com; s=arc-20160816; b=pGuwvZm08dF+nQWhxLJdX2ArW05Z8XYIrrNE1CaP8YQl5ReWjm3FSw+ZFkO865ZloG WiqXwv28riYJZZTnYD3J/eSM+9i1r1sh27QbuoE7WtaJv7bNTrx7CVle80V+b1euqJwr Z6i8M6qZ7w+ipxZOsOtAYvqNRg162g0xVQS0MAR3UL49QM+H4e27+0oB+3PO0Q85RFM0 YWQT3RSL27m0Up4t2b3GEj75JYV5ADzpShc22M3bwkNzVn74QCxgGNLeMrrEUvMpF1r2 SS0Oc0bA2o+/+SEjAZ1oxCM8rbh6ydO7DixAxlXYXd5emeLWgfXpqvkygpT7e7lS1TGt Xfmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=gYoKRf4MqsMr/R9A80cIw2QMlCLwgbH1+G1TyuipPVI=; b=Yr9wKqNgeHY6YqYiOYhIHUIrUJPqKdRdMGmZqzQq4Ak7YsOC+Bbw8/10cSMwMJvDzf bHY9WYDFiRkDl7OCcC5tigC3aw1OthyCRLl9yjKceR3mQqIUjnQZSn2Vuxi79JWIrIml a9M8xJrViAHWn3Sq8kmwcD7CqW1fuyT3IXCWbB0KkU+uF68UVfgpNHu1WDZEIRcd83/S xk8ck7N0q7iHp18z0M/1uRt/6yHl7BVvX32q0PFuFMpHLoE+g+yPz9bOduPMdQfkqs9z fZT9KCgOCfNJpw3xsuAea5+SFnYfRZsaJyhVZSpiW5DQZY4jZUIpVO5m7swFhBh/NB6h Oulg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gkNwUyZj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s7si1153458ilu.90.2021.11.02.17.41.09; Tue, 02 Nov 2021 17:41:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gkNwUyZj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231576AbhKCAlW (ORCPT + 99 others); Tue, 2 Nov 2021 20:41:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:47732 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230248AbhKCAlU (ORCPT ); Tue, 2 Nov 2021 20:41:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F271960F24; Wed, 3 Nov 2021 00:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635899924; bh=IADdOEF9lRlVoBcCABpgQbZIB9Dd/AMu4fq3dlVGaQY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gkNwUyZjDO4imsbWpR/RdZfu0y6k9XEMTg4giwAtEFvIMy1a4YZLLn5Pe8ChORLj7 dUafHb43O6tOVygh5oM06hrjChqjJ3IhwnSkG22QtudQN1ODLjtnrzIwONk+oUxQQV gcGFd45znOx5pREi2wmlB91AjR6IClLcGhxg8pat1I8eNhH1ayec1hF8e7j2sHUgZz x71JXDSf+1DkAFR4aqzZjehwtGRnyZfcAza9Q3F8qHCfaAl1eJ0Eg9HfvQ7qkicbWq LzFWwF/upv+FPkTHrEyZV8yTr5wjff8Lre8djkRrh5XLSGSNvE6RwMB9BEYMCRQyiZ j6qziu/4tPKpA== Date: Tue, 2 Nov 2021 17:38:40 -0700 From: Jakub Kicinski To: Grygorii Strashko Cc: "David S. Miller" , , , Kishon Vijay Abraham I , Vignesh Raghavendra , , Tony Lindgren , Andrew Lunn , Vladimir Oltean Subject: Re: [PATCH net-next v2 2/3] net: ethernet: ti: am65-cpsw: enable bc/mc storm prevention support Message-ID: <20211102173840.01f464ec@kicinski-fedora-PC1C0HJN> In-Reply-To: <20211101170122.19160-3-grygorii.strashko@ti.com> References: <20211101170122.19160-1-grygorii.strashko@ti.com> <20211101170122.19160-3-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Nov 2021 19:01:21 +0200 Grygorii Strashko wrote: > - 01:00:00:00:00:00 fixed value has to be used for MC packets rate > limiting (exact match) This looks like a stretch, why not use a mask? You can require users to always install both BC and MC rules if you want to make sure the masked rule does not match BC.