Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4876494pxb;
        Tue, 2 Nov 2021 17:57:57 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxhfHfaH02QrLi33hRejZVZ2SAQ03ZLOXHPxjXQ+nc7SgPeHz8Hm5ecYLMLx7E2Wzl+rN5q
X-Received: by 2002:a17:906:fcc8:: with SMTP id qx8mr7491597ejb.370.1635901077098;
        Tue, 02 Nov 2021 17:57:57 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1635901077; cv=none;
        d=google.com; s=arc-20160816;
        b=gqSICbwYxF62E5VskNiRR5XdQpHkTUaS5KcRZNlUAJKm1hLIcKiTLvoLtTxUxu/LhR
         0A8jm8D4lTCzUVDwQ17EId8U3aqW1RjZ44ap+LwmNGxjiXstyy651Wyn8wC1k1rFVR+H
         wViiScfr7hX2XsHf1E7D06ZHMGIh2Fh6WXiolALPc21aAZOKntKAfS0u4ZTyTfjyRQoW
         H4bnqg8G4Q2fqNmiJHJmIWVgDl2+RpcRRZZip3uYGixazOypomytKoQX/DAHdxKArhQe
         euUi6pLmy457NKolkQ2LKo0uQizgiXbPyjUTGHjgF7ef6i/SQ51OiA3zqRlFdJE4iHL5
         WtKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=5De7WVU7FOAran62ITkdM63lBSh9+g4axPy0hY1s/Ds=;
        b=Z3qsK1GxRVPFz18st8bgB7RHbvNn1k1+LMiRgqM/MlzYK5gO3z3/goBkBE0Qs7hLXB
         tRdkVKQN/nVirHFOM1XXUFDAerngXh5SapJ5bnxyaBx5ZZyIq6NxxYvxUCFRMNjSjaum
         1LcUYlkdZyp8ecYEm1xA+6xWnU9V0WFODyTLof/0R7oOMAJJptp2uKr0kq6iWFNwqpH7
         828VSkLqOwNJrVRmMiii/Lr5sFaV7N5zJOIjIq4TMDdMnygPGMy5636MEtzHQ3+F4oxM
         1bpK4NHRLi49+CIyRiCeRnA7mmgaZ80Wwn4lbaPHT3nPFSM0rNbGxmbB4LQ9MH0TbmZT
         OT4g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HZXHqeIY;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id cs11si1341707ejc.624.2021.11.02.17.57.32;
        Tue, 02 Nov 2021 17:57:57 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HZXHqeIY;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231311AbhKCA6R (ORCPT <rfc822;ly15351151@gmail.com> + 99 others);
        Tue, 2 Nov 2021 20:58:17 -0400
Received: from mail.kernel.org ([198.145.29.99]:51446 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229804AbhKCA6Q (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 2 Nov 2021 20:58:16 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0EA0061073;
        Wed,  3 Nov 2021 00:55:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1635900941;
        bh=j1uFTRgMamxbv0IZhp13qGNR+gqIVaeJXd0FjonuOwo=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=HZXHqeIYUp/TZjxVZogjbhpGCQ6pKDCpl1wxmq1zgaQJb3iLLnNavFCqMmUSq/4rO
         M+xtPH1JFWuUzTfqOTnXExBIpuWqYPKW8Qi8qvD315SwCUOju8l0yIZiwePau3ev7A
         i8+Rk3Ho5ho/Wad5kuVUhDcALoAArs8FEFNxWzu1YALJJ411tEW1+NF1fwf1LMeHGd
         5++HxK95oJm9NEUhaOSUWaHsCVP/8QRVC1qmN2FmqS5bsylM6vYYw3/Q736Y9OGL1v
         jgZdyfuFHy+cIZYzqwV+G1d14mXKddrhckifvTk9saupRUEuvDpy5Pz4VHqjoyC6yS
         e6s6a7kRwJmBg==
Date:   Tue, 2 Nov 2021 17:55:37 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Eugene Syromiatnikov <esyr@redhat.com>
Cc:     Jeremy Kerr <jk@codeconstruct.com.au>,
        Matt Johnston <matt@codeconstruct.com.au>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] mctp: handle the struct sockaddr_mctp_ext
 padding field
Message-ID: <20211102175537.0a004f77@kicinski-fedora-PC1C0HJN>
In-Reply-To: <ebab61afcbcd91441c4a5395612a4f1eca691bae.1635788968.git.esyr@redhat.com>
References: <cover.1635788968.git.esyr@redhat.com>
        <ebab61afcbcd91441c4a5395612a4f1eca691bae.1635788968.git.esyr@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 1 Nov 2021 18:54:53 +0100 Eugene Syromiatnikov wrote:
> +static bool mctp_sockaddr_ext_is_ok(const struct sockaddr_mctp_ext *addr)
> +{
> +	return !addr->__smctp_pad0[0]
> +	       && !addr->__smctp_pad0[1]
> +	       && !addr->__smctp_pad0[2];

&& at the end of the previous line please. Checkpatch will point those
out to you.

> +}