Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4913324pxb; Tue, 2 Nov 2021 18:47:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/IZFHzAOhC/BizL6Cil6wmKxkfQJXl8TMs0Pcy6IjRPG90HYP3j884ufMJfVkSULLnms1 X-Received: by 2002:aa7:c4d3:: with SMTP id p19mr13794217edr.333.1635904067604; Tue, 02 Nov 2021 18:47:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635904067; cv=none; d=google.com; s=arc-20160816; b=R6peU0tDTSN+YDSJfORnBE/989Ju/cWj5IyIdVUfCv+bbVIwASTjYfC4xQZmdc/Kp2 BL0Jh943eB0EXrXDOCQlefGwiW0hG80pVvJv097PadVtIpw84kvT9w7VUQCUC9wyYz4O w5hKHNuPewlBeYC22BPr8fZ3UGBxL+xiORNnDc5pAVwYd71soyKJ55zw2mX88a34vfON 126DftYZcmUkwvk+9GhppB4qJMdbfQh6aXw7ag3dq8MkC6kc0nif4r7AqnMGUGrpoRu7 PNeNjol3XD9AE2icIA4eMlLDTb/rjozUImXUOuznpszc9grJz7NTH5+4sbaffeKA7/58 myLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=+Vcd/xQmbgyEga0QAqHsy2l5McbxkCHEnU/yhhv018E=; b=C3asN2ppzFhs5z8NdEjv2x7pNxintnyDLP2rAwIDJnO4TK3Y2iOfdWthGYtUqYqB/l CUf1EY7Yi15gdlLeY4sLKI6cx9u9SQpIQEjpeloQQXWnLsAJ2WBzl3SXHHzl4PelzBRJ B+GOXzGc9PuBs05VmEn41AdSwHabN7I9l6g42SU+hU8z5dHtSokgfdERbPnmY3QJ8GA0 erJLFU4Q8Meqs2Ie9khZIPkEJvIVBIKsAVcSr+WbxJJnQPNdqSCwgJUTz3bGcz533UYN iklqtXcKjJg/f2sBGNn4apg+0nywrDVugXh+vY7Bk/3tzpaOgOR8iU1QeZjdlC6vI04Q aXdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l16si1472837edb.525.2021.11.02.18.47.24; Tue, 02 Nov 2021 18:47:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230250AbhKCBsO (ORCPT + 99 others); Tue, 2 Nov 2021 21:48:14 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:15348 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229844AbhKCBsN (ORCPT ); Tue, 2 Nov 2021 21:48:13 -0400 Received: from dggeme755-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4HkV2t4N15z90jv; Wed, 3 Nov 2021 09:45:26 +0800 (CST) Received: from huawei.com (10.67.174.47) by dggeme755-chm.china.huawei.com (10.3.19.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.15; Wed, 3 Nov 2021 09:45:35 +0800 From: He Ying To: , , CC: , Subject: [PATCH] powerpc/sysdev/of_rtc: Fix possible memory leak in of_instantiate_rtc Date: Tue, 2 Nov 2021 21:47:17 -0400 Message-ID: <20211103014717.162886-1-heying24@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.174.47] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggeme755-chm.china.huawei.com (10.3.19.101) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If of_address_to_resource() in of_instantiate_rtc() fails, previously allocated memory res is not freed. Add missing kfree() for it. Signed-off-by: He Ying --- arch/powerpc/sysdev/of_rtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/sysdev/of_rtc.c b/arch/powerpc/sysdev/of_rtc.c index 1f408d34a6a7..23b896996c2f 100644 --- a/arch/powerpc/sysdev/of_rtc.c +++ b/arch/powerpc/sysdev/of_rtc.c @@ -44,6 +44,7 @@ void __init of_instantiate_rtc(void) printk(KERN_ERR "OF RTC: Error " "translating resources for %pOF\n", node); + kfree(res); continue; } -- 2.17.1