Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [RFC v2 10/11] hte: Add tegra GPIO HTE test driver
To:     Randy Dunlap <rdunlap@infradead.org>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <linux-kernel@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <linus.walleij@linaro.org>, <bgolaszewski@baylibre.com>,
        <warthog618@gmail.com>, <devicetree@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <robh+dt@kernel.org>
References: <20210930232617.6396-1-dipenp@nvidia.com>
 <20210930232617.6396-11-dipenp@nvidia.com>
 <466cf944-4eae-ad4c-dcf5-42e2e043b754@infradead.org>
From:   Dipen Patel <dipenp@nvidia.com>
Message-ID: <26baa410-7df7-901e-00e2-0b3cca3491c8@nvidia.com>
Date:   Tue, 2 Nov 2021 22:07:28 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <466cf944-4eae-ad4c-dcf5-42e2e043b754@infradead.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 05:06:33.7456
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 40428d34-a220-46d4-61f1-08d99e87b4b5
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT068.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB2517
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,


On 10/1/21 4:47 PM, Randy Dunlap wrote:
> Hi,
>
> On 9/30/21 4:26 PM, Dipen Patel wrote:
>> diff --git a/drivers/hte/Kconfig b/drivers/hte/Kconfig
>> index eb339526f141..57c97034d187 100644
>> --- a/drivers/hte/Kconfig
>> +++ b/drivers/hte/Kconfig
>> @@ -38,4 +38,13 @@ config HTE_TEGRA194_IRQ_TEST
>>         The NVIDIA Tegra194 GTE IRQ test driver demonstrates HTE subsystem
>>         usage for the LIC IRQ hardware timestamp.
>>   +config HTE_TEGRA194_GPIO_TEST
>> +        tristate "NVIDIA Tegra194 HTE GPIO Test"
>> +        depends on HTE_TEGRA194
>> +        help
>> +      The NVIDIA Tegra194 GTE GPIO test driver demonstrates how to use HTE
>
>                                                                 to use the HTE
>
>> +      subsystem indirectly through gpiolib API calls for GPIO line for the
>
>                                                               lines
>
>> +      hardware assisted timestamping.
>
>       hardware-assisted
>
>> +
>>   endif
>
> Also:
>
> Please follow coding-style for Kconfig files:
>
> (from Documentation/process/coding-style.rst, section 10):
>
> For all of the Kconfig* configuration files throughout the source tree,
> the indentation is somewhat different.  Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.
>
> Some of the lines above are indented with spaces instead of one tab.
>
I will double check this. From the RFCv1 comments, I did correct formatting according

to above coding style i.e. everything 1 tab except help which is 1 tab + 2 spaces.

>
> thanks.