Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Yihao Han <hanyihao@vivo.com>
To:     Saeed Mahameed <saeedm@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, Roi Dayan <roid@nvidia.com>,
        Paul Blakey <paulb@nvidia.com>, Oz Shlomo <ozsh@nvidia.com>,
        Ariel Levkovich <lariel@nvidia.com>,
        Vlad Buslov <vladbu@nvidia.com>, Chris Mi <cmi@nvidia.com>,
        netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] net/mlx5:using swap() instead of tmp variable
Date:   Tue,  2 Nov 2021 23:21:09 -0700
Message-Id: <20211103062111.3286-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pqyBGzhgpMzmIsZo4JN6ycG/Zro7K7XPADbqP3JyyUxOOJIWI5bohMFXgzHk?=
 =?us-ascii?Q?84liILD3PzT2mi5qgMTlbvY5O9ADcf6gVQxdK/ngFc9ivr5vN7sN8martSym?=
 =?us-ascii?Q?9GM1gaB5zas7fOdUHuF0ZYlJTlWlFnDgvq2hzQplVbPIbOWBsVE+xOwNykEX?=
 =?us-ascii?Q?TgXAK+AbLzVPby6NB2mXfflVscJpyBzqq657HRmvWiijbt2TpTDdsaq+RlzV?=
 =?us-ascii?Q?9TPzn7mhnbvvJ3tvbA8uH21UG8HuenZ5L4tcoikPePQVtX8AoOop1egDIv64?=
 =?us-ascii?Q?3cfTr4J1dgbOvvbH4lnKUS4w3a7PkMqUjlbptQ+TNn25JqposB6Oe7u+Fsko?=
 =?us-ascii?Q?66rhwTVtdJ1al1hLsjWP0tFcLRtuqR6AyuI9L8SKynPJu3tLq2SauMJTOUpA?=
 =?us-ascii?Q?yzPbD5igxb9RunfbNNvC4i8rpkQwlPljq6tGuh+8aHLYxM3D7pZ6ysinkgiS?=
 =?us-ascii?Q?0ZC+P8WsDMeU9YDBYjGGXN65a9zkQzChzCajJwK/pFMRDzYg3RmqXzD3LeCH?=
 =?us-ascii?Q?qVWw79vCuf4xpylL0R7vrg9itwQ23kGcoaMFOF8SlOqFbRnBoEFe9jyFalP3?=
 =?us-ascii?Q?5UZxQtVtlNE3+3l+9UjtSY9J/XuXz4bjmDhJW2HS8PWv5E7TNeyMawSJscou?=
 =?us-ascii?Q?fMeB4tj3hTbAeUGppVqG8ycuwfVo9L4Vxd+KXK0CX68h+CgL6CNQAM1uK6y2?=
 =?us-ascii?Q?d96M0h0n8VaYABdBGy/46d6+Ug24PL005Uycsory3G7wGjWdb9Bs8QUhlKZk?=
 =?us-ascii?Q?h0CEX4fdQmvTT4M2LpxbedfOSVTYrxGHeX5dAv6Dvii3bHxMq71fPuRdIx/O?=
 =?us-ascii?Q?4w7B9ZQqKbtc36yrnCLDvRt9fdBpRjK7ZiUknqU0pF1y7NQ4vrh3awiv2J4Y?=
 =?us-ascii?Q?hF3xuZ2h3GTq+OPLSIUjMrf0Y8PutFa6MMu1elmjTY8SkD4XNnCVPk/TcgjE?=
 =?us-ascii?Q?N+L/tTpIFAzXAVeqvTvV6Q56HmhlODjkPcQgC0jmqyFfvnqHoV/X/1nJ7nSQ?=
 =?us-ascii?Q?Ycf/h1VGNLMJOg8lflVyrPnnADnuSK9p/dap3hCqH51ygfe25+thWABQYx9K?=
 =?us-ascii?Q?cpfrS6n9+HzYilISL3c9YDlNGLoX+IWlHAw019pyTw1GY1b6hTN7Wk7skYeK?=
 =?us-ascii?Q?P1hg44V+be7+UPysjWkz5i2k2dw34hHsZco9j2ZHx2DSXZrahMAhBiZySqXz?=
 =?us-ascii?Q?9gCtKbdq7ocP1rHk7IABYRB3xwMNVVxVWR0U6Lh4reEIkZQzke2UOi3zlzKK?=
 =?us-ascii?Q?YubzfoKBp8su8zwHhGQc1M3PV0Dtb2RUj6sXpKLzspDltQSVORXlnofj5R8u?=
 =?us-ascii?Q?+/iLpXAPzPHDb9aRAfUS+nLKHGDS1Rb92OmGZo4n/oe64JZCI9SYUaz/Koi/?=
 =?us-ascii?Q?4usUQ65+Er14i92rjtJnbLs9UJ/978TdDSeTlb0g4y23BKB1GQwtLml4urSF?=
 =?us-ascii?Q?XagfE+wtysdah0BbNSZPfJggBePLj3Nr6bYXAsTc3fIo4/GjvzJpppdlEI/B?=
 =?us-ascii?Q?JbUjmLZ/M8oSKZ1cpSupL4AOat2hFN2HsQiyf8PMnac7DtRNPVx4AH/zAodf?=
 =?us-ascii?Q?kdMjhceUYHJURj9X/4jHiG4vCXHzlQdxD+quVIEpfYEFY/YeJIDPpzyu53AT?=
 =?us-ascii?Q?wfI8sMvgswN3s1RTNnHb+nY=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1024c525-1c69-4819-7fb1-08d99e922c6e
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 06:21:29.9081
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YVmyUE4kBpkqvL6LQO34IhjgqOa+/SmkozX0X+diGCvNqgpAzJCufPuEFlJOsqFaKzQAPhsrvrKK3T43XhBU+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR06MB2413
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

swap() was used instead of the tmp variable to swap values

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
index 740cd6f088b8..d4b4f32603f2 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
@@ -907,12 +907,9 @@ mlx5_tc_ct_shared_counter_get(struct mlx5_tc_ct_priv *ct_priv,
 	struct mlx5_ct_tuple rev_tuple = entry->tuple;
 	struct mlx5_ct_counter *shared_counter;
 	struct mlx5_ct_entry *rev_entry;
-	__be16 tmp_port;
 
 	/* get the reversed tuple */
-	tmp_port = rev_tuple.port.src;
-	rev_tuple.port.src = rev_tuple.port.dst;
-	rev_tuple.port.dst = tmp_port;
+	swap(rev_tuple.port.src, rev_tuple.port.dst);
 
 	if (rev_tuple.addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) {
 		__be32 tmp_addr = rev_tuple.ip.src_v4;
-- 
2.17.1