Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Xiaowei Song <songxiaowei@hisilicon.com>,
        Binghui Wang <wangbinghui@hisilicon.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Rob Herring <robh@kernel.org>,
        =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     jiabing.wan@qq.com, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] PCI: kirin: Fix of_node_put() issue in pcie-kirin
Date:   Wed,  3 Nov 2021 02:25:18 -0400
Message-Id: <20211103062518.25695-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TjbUw0wgUIFDQTkUiDFjlQFjkSNZEPOMjaDm+us16pvmRz4B10FKz+a6W2l7?=
 =?us-ascii?Q?60h37gGfahgZDXLTT4xvRz8/4UpA3Duqs4i/qrhRhpOc6bxI9VpM2hDtBeYz?=
 =?us-ascii?Q?9Fg56GxdZlHLw+q/bOpiG3MlYKYWbejC3U95sZ7NptAC0Uls5J63QByzMCqc?=
 =?us-ascii?Q?QIaUclRJV42yWfJ8eV0oTbnjDPfWtilkfxIARF9aOiobWV88CXqIJ9VJSsCl?=
 =?us-ascii?Q?wUPyPM6YizbR6bzCfRfdSS0e+qKaw6L2E4Fq/XsgTJZp3DH5e8ef6bJPMYXn?=
 =?us-ascii?Q?p8zMuyx0CW4H4uW2ExQPChcUPIc2xEOZ7wKOzt3sNzyeqzxZb6V/ap/ImXnW?=
 =?us-ascii?Q?u5LuOsYyKvtIDHBIVrw5RzW6XSQoELIZmV4SjBFu3pS80RAGdO64e2AZaYCz?=
 =?us-ascii?Q?It62hh0mdf8zZRezsoDG+NPL0hjrtfJrt4qlMlXFgknVCJHOyGaDfRfY66G6?=
 =?us-ascii?Q?E20iGffSNEyeLHTVoGxbTdCkDaZSWphYPnzUXMZC/0OppTyBPpQ7gWggoSQE?=
 =?us-ascii?Q?cyNR9BqQraVOKO56PSyoSUxAYVWlv7DsGavTt7qPTz15WI4RA4Hvq13MWtCS?=
 =?us-ascii?Q?FRfI98FYP5W+VUsdqG8GvCQi9BNXUJNcFp9YiN1gr0VsNKkgW+DIq6SqWICf?=
 =?us-ascii?Q?3mekNQI+8ETH/Y7F53FcuICz4x0np5mdmkhEoEl9/fH6DDhN9VW3TC5FXVye?=
 =?us-ascii?Q?sJQfb0oBhF0MzV3Hj87ntlqdEevZ2ih2DkGyC9+uW5Q0JA+TbbIrCg0k6cV3?=
 =?us-ascii?Q?1cfzSVanNDTrhMbPmtVnAfnpFIvqqQs537liIMn8/CxZq7DmqFdSN3AXSkdc?=
 =?us-ascii?Q?eJl2YjvpbfE445q+Hkn/ShTx5dExV4pSHh5o9XnfOltqsUkZuYzQRm/fg8Sh?=
 =?us-ascii?Q?jLe96q5vtHAx+TTZEXSz6yXrGMo0oQPF+mB28TydY3W07rnjQ3XEbvizmnw9?=
 =?us-ascii?Q?JKeLX2tuZCiODi6/tSGpT6Y9VRXq3IYgp5B5s/SXuida2d18z4Dx15oGQwFs?=
 =?us-ascii?Q?9ttAf54NTpbEDwJkVqZFOG0ymJbvjlmOU356tVXmYrEabU1bIyxp0ooVWqEP?=
 =?us-ascii?Q?1yujL/RuOhzFVGuSHW62J0vE4ttT7hcItXOpiWknDfivkEwm5rcojDNbqWq1?=
 =?us-ascii?Q?fXrFxIy74+6GS3gpujK4LI9qAfRzUqnr+Ru+cRs5e8E4Fk0zC8v99D+Dfh/c?=
 =?us-ascii?Q?i/4VvrLJEIVLSFxu+zMtyDQN8IA2UEDebN1HPN9NzS7hKGKbOE7HbThcBx3a?=
 =?us-ascii?Q?9RyjWKMiMU3FrN01otMvB9F0VWIThQINqAIaS3zzvhThf+2uNGCoOm/t2tzv?=
 =?us-ascii?Q?dnk+Cw8uNo3h1eOzbW6P7h5jaxg7LSvJ1zo3fVpB4Bajj1QLCYJFDvN31TCG?=
 =?us-ascii?Q?1cGvmndiWE2EnCi12DCQ7FSjwfZbcYXHcEYfyG0LmxyFhWyvSXZF0Zw7AG+R?=
 =?us-ascii?Q?a0upGqPud+87SDdI04ri9ojIKbTP5O3qIrBbYXouFZ6mxHdted7xa2EW6IKP?=
 =?us-ascii?Q?nD72W6vfHEfgzmYSKqzc/2vlSB+NyaGb1GKvP+rBYu7eUyoU7g+qx/pbN6MO?=
 =?us-ascii?Q?EhY4qcixuYlHuAgQMyTTyohADvr4G3+Dmo7yDzMwbd0KbASbD2R/I7dfMHSw?=
 =?us-ascii?Q?vohISqinYO1wEHmYh2pKD34=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b8b9536-cc10-4004-942f-08d99e92c53e
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3374.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 06:25:46.4620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rivxcW18U3Ah6wV7+ReSmce/UQc9NKEsQY0k+p9EO+ASnEsZWaOEOVWWM5IHfz7ukJV65Jl+feJcqnCkzGXsAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4175
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/pci/controller/dwc/pcie-kirin.c:414:2-34: WARNING: Function
for_each_available_child_of_node should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter. Replace return by goto here.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/pci/controller/dwc/pcie-kirin.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c
index 06017e826832..23a2c076ce53 100644
--- a/drivers/pci/controller/dwc/pcie-kirin.c
+++ b/drivers/pci/controller/dwc/pcie-kirin.c
@@ -422,7 +422,8 @@ static int kirin_pcie_parse_port(struct kirin_pcie *pcie,
 			pcie->num_slots++;
 			if (pcie->num_slots > MAX_PCI_SLOTS) {
 				dev_err(dev, "Too many PCI slots!\n");
-				return -EINVAL;
+				ret = -EINVAL;
+				goto put_node;
 			}
 
 			ret = of_pci_get_devfn(child);
-- 
2.20.1