Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 03 Nov 2021 08:36:42 +0100
From:   Michael Walle <michael@walle.cc>
To:     Lee Jones <lee.jones@linaro.org>
CC:     Robert Marko <robert.marko@sartura.hr>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: simple-mfd-i2c: Select MFD_CORE to fix build error
User-Agent: K-9 Mail for Android
In-Reply-To: <YYI7DFjoCgYMdLl5@google.com>
References: <20211102100420.112215-1-robert.marko@sartura.hr> <YYEeS8gz8TBW63X8@google.com> <8b2b9e6f61107b79f93dd191c3fc2918@walle.cc> <YYI7DFjoCgYMdLl5@google.com>
Message-ID: <1FD0767C-3BF3-46D3-8C7D-BA31F9D7AE0D@walle.cc>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Am 3=2E November 2021 08:32:28 MEZ schrieb Lee Jones <lee=2Ejones@linaro=2E=
org>:
>On Tue, 02 Nov 2021, Michael Walle wrote:
>
>> Am 2021-11-02 12:17, schrieb Lee Jones:
>> > On Tue, 02 Nov 2021, Robert Marko wrote:
>> >=20
>> > > MFD_SIMPLE_MFD_I2C should select the MFD_CORE to a prevent build
>> > > error:
>> > >=20
>> > > aarch64-linux-ld: drivers/mfd/simple-mfd-i2c=2Eo: in function
>> > > `simple_mfd_i2c_probe':
>> > > drivers/mfd/simple-mfd-i2c=2Ec:55: undefined reference to
>> > > `devm_mfd_add_devices'
>> >=20
>> > What is your use-case?
>> >=20
>> > How are you enabling this symbol?
>>=20
>> Mh? drivers/mfd/simple-mfd-i2c=2Ec is using devm_mfd_add_devices which
>> is provided by drivers/mfd/core=2Ec=2E So select MFD_CORE is clearly
>> missing here, no? I mean most of the MFD drivers do a "select MFD_CORE"=
=2E
>
>I'm not debating that=2E  The patch is fine=2E
>
>I am however, interested in how MFD_CORE is enabled for MFD_SL28CPLD=2E

Because I'm mostly using the arch defconfig (arm64) it
must have missed it because it was probably already=20
enabled by another mfd driver=2E=20

-michael