Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Nov 2021 10:08:16 +0200
From:   Sakari Ailus <sakari.ailus@linux.intel.com>
To:     Eugen Hristev <eugen.hristev@microchip.com>
Cc:     akinobu.mita@gmail.com, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: ov7740: implement get_mbus_config
Message-ID: <YYJDcIiBXo/XlKCX@paasikivi.fi.intel.com>
References: <20211102153008.1349895-1-eugen.hristev@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211102153008.1349895-1-eugen.hristev@microchip.com>
Precedence: bulk

Hi Eugen,

Thanks for the patch.

On Tue, Nov 02, 2021 at 05:30:08PM +0200, Eugen Hristev wrote:
> Implement the get_mbus_config callback.
> ov7740 is a parallel sensor, and according to datasheet, the register
> REG12 controls the CCIR656 mode. This register is written to 0 in yuyv mode.
> According to REG12[5] , CCIR656 mode, the behavior is:
> CCIR656: disabled
> REG28 controls the polarity of the signals. This register is unused.
> The default behavior is then:
> HSYNC polarity : positive
> VSYNC polarity : positive
> HREF polarity: positive
> 

Doesn't the receiver driver get this information from DT?

> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
>  drivers/media/i2c/ov7740.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c
> index 2539cfee85c8..f8a717aecb6f 100644
> --- a/drivers/media/i2c/ov7740.c
> +++ b/drivers/media/i2c/ov7740.c
> @@ -873,12 +873,26 @@ static int ov7740_get_fmt(struct v4l2_subdev *sd,
>  	return ret;
>  }
>  
> +static int ov7740_get_mbus_config(struct v4l2_subdev *sd,
> +				  unsigned int pad,
> +				  struct v4l2_mbus_config *cfg)
> +{
> +	cfg->type = V4L2_MBUS_PARALLEL;
> +	cfg->flags = V4L2_MBUS_MASTER | V4L2_MBUS_HSYNC_ACTIVE_HIGH |
> +		     V4L2_MBUS_VSYNC_ACTIVE_HIGH |
> +		     V4L2_MBUS_PCLK_SAMPLE_RISING |
> +		     V4L2_MBUS_FIELD_EVEN_LOW | V4L2_MBUS_DATA_ACTIVE_HIGH;
> +
> +	return 0;
> +}
> +
>  static const struct v4l2_subdev_pad_ops ov7740_subdev_pad_ops = {
>  	.enum_frame_interval = ov7740_enum_frame_interval,
>  	.enum_frame_size = ov7740_enum_frame_size,
>  	.enum_mbus_code = ov7740_enum_mbus_code,
>  	.get_fmt = ov7740_get_fmt,
>  	.set_fmt = ov7740_set_fmt,
> +	.get_mbus_config = ov7740_get_mbus_config,
>  };
>  
>  static const struct v4l2_subdev_ops ov7740_subdev_ops = {

-- 
Regards,

Sakari Ailus