Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>
To:     Rob Herring <robh@kernel.org>
CC:     "jic23@kernel.org" <jic23@kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Sa, Nuno" <Nuno.Sa@analog.com>
Subject: RE: [PATCH v3 2/2] dt-bindings: iio: frequency: add admv1013 doc
Thread-Topic: [PATCH v3 2/2] dt-bindings: iio: frequency: add admv1013 doc
Thread-Index: AQHXzwfj21y5Dnr/k0eZeDeswgk2M6vwhjwAgADvSCA=
Date:   Wed, 3 Nov 2021 08:09:20 +0000
Message-ID: <CY4PR03MB3399E5DC1D8A966C7CFC8C049B8C9@CY4PR03MB3399.namprd03.prod.outlook.com>
References: <20211101100420.70304-1-antoniu.miclaus@analog.com>
 <20211101100420.70304-2-antoniu.miclaus@analog.com>
 <YYF6cPSDroPz/wun@robh.at.kernel.org>
In-Reply-To: <YYF6cPSDroPz/wun@robh.at.kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?bE3cdQgsZSM4GIDt+uEEJ8uG+tuiTHKDbZ/QUiUH5AZ3lVfwx44TvtGEX3?=
 =?iso-8859-2?Q?d5u4A/gz3quxu0DPBYASSyxZQ4JpbKkwjmeA+aaWdejEA6tTXh4gXsdoc9?=
 =?iso-8859-2?Q?HIzGEWUNg0gER6KvCZxzi/IrZ55uAOXjJLf3w8m3RTOQOqi+o0BtA8fr2j?=
 =?iso-8859-2?Q?mo3tvLAiTbzbVBw+L/K/PRgYRZRWqiVGZJm+6SXTmDKrmOx9tThIPd5sjQ?=
 =?iso-8859-2?Q?S+0k1/7CM9Rlp9yd/FOx3lR7sDafTdifMQBPfLgfW/jnPia0j8PWh+qGj5?=
 =?iso-8859-2?Q?ez/gyV6GvjbpcoLiAUUnfMbHJExsu/q/f0gg6LL6P0Gjc3gr/p0fk/TWAU?=
 =?iso-8859-2?Q?eqkUYkyog40NTMmHUgIwMcA3d4bE67cun5g+KYLMtHQVp5Sk5uJMA3VRQx?=
 =?iso-8859-2?Q?bS4fe3bq1pT1kdyJC5Jo0qR5UIjDf+itdA0cFskTCg4SxQ7AiiCZhwwPX9?=
 =?iso-8859-2?Q?Gx6YVJHgwIjTFktHq22VqWBVyWgBvG9Hew5yQq8BTjDRZHq6ZNjIsx/JX3?=
 =?iso-8859-2?Q?3d747Y/WE/EWwd8FcEKxyaDh07pMbRfKhlUwvXXodl9fZJqra6m8ii+Axu?=
 =?iso-8859-2?Q?yPGQ8kEblapY3cOx2bnLENFrhn7Qd1uuXE5q4T02aq6LEQ0hSE8GhTnBII?=
 =?iso-8859-2?Q?OFk3nsCxEB4xGx+eS6UJfvhuSZtgaMGQDqZQuMn1oCNyopZ8j8XQdt3QRt?=
 =?iso-8859-2?Q?jxWDfLIANDG65nvlczV16OWKHF726k1TZ+Wb3IUSt1SDxsNW1DgU++3ckG?=
 =?iso-8859-2?Q?wybyfQTeig+kZDi3zGfwme9e/aDO1u/SewInZ0gjO0HTcVWumBkTlPWB32?=
 =?iso-8859-2?Q?k+/Ka2gV1S8Kq/AoFIjDhHRVpK2nKOr41tJEvS5Z/9zMSP2Hohrbn1zIHG?=
 =?iso-8859-2?Q?Vggk2tEbEekebKN//RWNQ23a4+q8Cc9+rWmvKTMYLKsdMSXTKE9VTw7cd4?=
 =?iso-8859-2?Q?huMBByuiR0iO9uaT+P7Jatdh4hjV5JlfG9ZbG0Cm5ERS5GSsWFl4B5wDaX?=
 =?iso-8859-2?Q?qdQTO6vXvKAYY22IsvXc+LozeJXbxGWJGysBCXYOhEYrBjuDy9k0DASAfy?=
 =?iso-8859-2?Q?hFwQXPxH12HjPeQ7zxjZvQnbiE5Wb+mbL3nU3I0sX6nIQ0H08UyNtDuxTN?=
 =?iso-8859-2?Q?FKnfItkEh0i/hFTE2wVP4IM8R7/wMNEy6aiAGNUo6WJRD+idO1NPkuaUAB?=
 =?iso-8859-2?Q?+zAawnnht28Q2+6Kf0zo2pY+K+OlzOgEOw8Oge9MTbSJhe2w8DYe+gp3Zj?=
 =?iso-8859-2?Q?auP+eVB3JCgI3IUGsdBbJi3sQNdsdF+ypDMraKkPp3MDnqCQZzFaaE1bBU?=
 =?iso-8859-2?Q?FEWCFT1qKbp3Rt6llv1iH/RcS9Q/GdANh5aNxfzAmudpQeTQMqIzGFBZFr?=
 =?iso-8859-2?Q?HcAc4P4NSRrQRdlXjNW17rn9P+4PwvO/qwHu81Wd6IjiP4/lInH+T2Z6/0?=
 =?iso-8859-2?Q?EH6njOSd78t+b0vrrIW7iWnFzA3NB3TeFYTFrIVBTRk3Ae8T5Z63pGkCrt?=
 =?iso-8859-2?Q?6FwoqqVFnwPa+aN2WEH4rIZUOD+jTV6nahc5eOatV2uUC4OJZ+Zdu3YD4i?=
 =?iso-8859-2?Q?W38nfhXG/0yoUHHJ5SvnJtmE8l7GYPhBvRCyWDtxPaP48SJB1cDuumD+9v?=
 =?iso-8859-2?Q?59kdyc7bCjNkYiVfnZu1y0P0s3GIo5r2sZWqEKuqG5Y8eVeEfAyn0Kc8Jf?=
 =?iso-8859-2?Q?MpokjMN+8l0Sic74/Xb4LpToWj8ynxvKXk2chmLIDg1Zq3KX/Guhsp+bz6?=
 =?iso-8859-2?Q?WsNw=3D=3D?=
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR03MB3399.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f85b67e4-2e0f-41c7-6ddf-08d99ea13d7b
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2021 08:09:20.6009
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EPikJnTgBLYVCTTPSWwtKwCBz7W95K6T2g8XXpUf0xI+AUbG2UzqghBGp9bSSZXCLEa1QBMTDMZ7V9rXNuU0+9pKc3Rp2Og45imTgCXzEJA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2885
X-Proofpoint-GUID: GvlCdTMym0HxP5GdqzuitKLDDGaPGitI
X-Proofpoint-ORIG-GUID: GvlCdTMym0HxP5GdqzuitKLDDGaPGitI
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-11-03_02,2021-11-02_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 impostorscore=0
 mlxscore=0 phishscore=0 spamscore=0 priorityscore=1501 clxscore=1015
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2111030049
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Rob,

These properties are fixed and available in the datasheet (binary format):
https://www.analog.com/media/en/technical-documentation/data-sheets/ADMV101=
3.pdf

Please see Page 37 of 39, Table 15, QUAD_SE_MODE.

Regards,
--
Antoniu Micl=E3u=BA

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Tuesday, November 2, 2021 7:51 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>
> Cc: jic23@kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.o=
rg;
> linux-kernel@vger.kernel.org; Sa, Nuno <Nuno.Sa@analog.com>
> Subject: Re: [PATCH v3 2/2] dt-bindings: iio: frequency: add admv1013 doc
>=20
> [External]
>=20
> On Mon, Nov 01, 2021 at 12:04:20PM +0200, Antoniu Miclaus wrote:
> > Add device tree bindings for the ADMV1013 Upconverter.
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---
> >  .../bindings/iio/frequency/adi,admv1013.yaml  | 119
> ++++++++++++++++++
> >  1 file changed, 119 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
> >
> > diff --git
> a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
> b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
> > new file mode 100644
> > index 000000000000..47993253a586
> > --- /dev/null
> > +++
> b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
> > @@ -0,0 +1,119 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> https://urldefense.com/v3/__http://devicetree.org/schemas/iio/frequency
> /adi,admv1013.yaml*__;Iw!!A3Ni8CS0y2Y!uTDPalOgj6YS_vZ6bsDSbA_Qna6Q
> OwMpoRxzo6nn06i5TNuGWZEk9PvtbC6SKQGXrugy$
> > +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/core.yaml*__;Iw!!A3Ni8CS0y2Y!uTDPalOgj6YS_vZ6bsDSbA_Qna6Q
> OwMpoRxzo6nn06i5TNuGWZEk9PvtbC6SKYugV1fM$
> > +
> > +title: ADMV1013 Microwave Upconverter
> > +
> > +maintainers:
> > +  - Antoniu Miclaus <antoniu.miclaus@analog.com>
> > +
> > +description: |
> > +   Wideband, microwave upconverter optimized for point to point
> microwave
> > +   radio designs operating in the 24 GHz to 44 GHz frequency range.
> > +
> > +   https://www.analog.com/en/products/admv1013.html
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,admv1013
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  spi-max-frequency:
> > +    maximum: 1000000
> > +
> > +  clocks:
> > +    description:
> > +      Definition of the external clock.
> > +    minItems: 1
> > +
> > +  clock-names:
> > +    items:
> > +      - const: lo_in
> > +
> > +  clock-output-names:
> > +    maxItems: 1
> > +
> > +  vcm-supply:
> > +    description:
> > +      Analog voltage regulator.
> > +
> > +  adi,vga-powerdown:
> > +    description:
> > +      Power Down the Voltage Gain Amplifier Circuit available at
> > +      BG_RBIAS2 pin.
> > +    type: boolean
> > +
> > +  adi,mixer-powerdown:
> > +    description:
> > +      Power Down the Mixer Circuit. Enable to put the block in
> > +      a power down state.
> > +    type: boolean
> > +
> > +  adi,quad-powerdown:
> > +    description:
> > +      Power Down the Quadrupler. Enable to put the block in
> > +      a power down state.
> > +    type: boolean
> > +
> > +  adi,bg-powerdown:
> > +    description:
> > +      Power Down the Transmitter Band Gap. Enable to put the part in
> > +      a power down state.
> > +    type: boolean
> > +
> > +  adi,mixer-if-enable:
> > +    description:
> > +      Enable the Intermediate Frequency Mode. Either IF Mode or I/Q Mo=
de
> > +      can be enabled at a time.
> > +    type: boolean
> > +
> > +  adi,detector-enable:
> > +    description:
> > +      Enable the Envelope Detector available at output pins VENV_P and
> > +      VENV_N. Disable to reduce power consumption.
> > +    type: boolean
> > +
> > +  adi,quad-se-mode:
> > +    description:
> > +      Switch the LO path from differential to single-ended operation.
> > +      Set value 6 for Single-Ended Mode, Negative Side Disabled.
> > +      Set value 9 for Single-Ended Mode, Positive Side Disabled.
> > +      Set value 12 for Differential Mode.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    enum: [6, 9, 12]
>=20
> All these vendor properties are fixed based on the board design or
> something a user may want to change? The latter does not belong in DT.
>=20
> Rob