Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Nov 2021 10:13:23 +0100
From:   Stefano Garzarella <sgarzare@redhat.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     andraprs@amazon.com, lexnv@amazon.com, alcioa@amazon.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nitro_enclaves: Fix implicit type conversion
Message-ID: <20211103091323.clvhuiaf7kwrbywy@steredhat>
References: <1635472126-1822073-1-git-send-email-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <1635472126-1822073-1-git-send-email-jiasheng@iscas.ac.cn>
Precedence: bulk

On Fri, Oct 29, 2021 at 01:48:46AM +0000, Jiasheng Jiang wrote:
>The variable 'cpu' and 'cpu_sibling' are defined as unsigned int.
>However in the for_each_cpu, their values are assigned to -1.
>That doesn't make sense and in the cpumask_next() they are implicitly
>type conversed to int.
>It is universally accepted that the implicit type conversion is
>terrible.
>Also, having the good programming custom will set an example for
>others.
>Thus, it might be better to change the definition of 'cpu' and
>'cpu_sibling' from unsigned int to int.
>
>Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
>---
> drivers/virt/nitro_enclaves/ne_misc_dev.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)


The for_each_cpu documentation explicitly says that unsigned is 
supported and -1 is commonly used to refer to the value before 0 even 
for unsigned.

However I have nothing against changing them to int.

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Thanks,
Stefano