Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp207679pxb; Wed, 3 Nov 2021 02:50:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDNlUPP5Uhl93uwsbo8GL6KFzeFcluryuA04a0csvfeKAOimnp64Np8xpwfkfso9FSJKvP X-Received: by 2002:a17:906:6dc9:: with SMTP id j9mr41495664ejt.317.1635933056762; Wed, 03 Nov 2021 02:50:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635933056; cv=none; d=google.com; s=arc-20160816; b=VcrxHEF6WNk97LlyI50XPuV6DPZop03ymQzD3eR4bLFv28Lo1dEipwd7TCbfdd0WPw bivbZ3QrLXexLBvss4MEPuy9XA2fb9NA5C7ehPuMgxf2eQg0/xjitK4IwZ0k3LLb6LrH R8iPLCKQNe0//XhmRmGLb3TvyDLts4fV/YN34BNXfsJ25WG9CABNmN5ZG62I6VVRUpvC URmbF1maTBad8Vy+mSBgFz85f1H8oxYDjCXqnh9uQfHjtb1zSOh45p6VEL5L8H797v6H gBWWEdBltx2/VtX4qC/3yKZETmETpEfit7YiBEk6fmHwOMmrbfLyZZ4kGTLji50NZiBc gX0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6i9bPgjwVqS5X5rQj+iclCvW1CN7cEK52O4jAhh8NJg=; b=E85i0jr4N4s2kk86P5UPXa+Msr12iUbp1rQdcv1+FBg2UqWua9TvfmWwp3CAhsDqMg yde0ZBRCVxCX3yypAKnl4XIlIjf7uuIf/aassQBmCJwncp3j0uXlskSWnZ9h+cGhryKZ tCgG3sqhKVYRv9vqr3ApB9wg0hCnzxqW++GQVKARiotf/3p0kXKNerlRf64d1gZ3LqK4 k4WkisTC/qHhdlufu21/eE8FxFdfdj3ZwS+R+MX1VQyA2DDOcQKsy9IgIhxhrxfDNFNs 9K4+7TH2C1CbbX8Gs7mTq3dduB5fH5GafK9dgMAvBCEHKSDH7PjquDlxaka8v1FyCT+3 OsLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bneuEKaA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e22si3245473edu.306.2021.11.03.02.50.32; Wed, 03 Nov 2021 02:50:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bneuEKaA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231721AbhKCJtJ (ORCPT + 99 others); Wed, 3 Nov 2021 05:49:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:59446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231278AbhKCJtI (ORCPT ); Wed, 3 Nov 2021 05:49:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7D3FD6113B; Wed, 3 Nov 2021 09:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635932792; bh=JCi57Xe87vMD6it97QtxyVClRxGWin28JiPQM/PNxXU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bneuEKaAdHECFDnx94bbIp260s+LI+jR0VcjtwrIrBlTxKQ3z3me+H9bNobVOJiIo 0VtywvsFq0zscmyMoWDeqVNAD9bxKXSg7Ag6ISx8FxNcMxtIKHXEQpi/iGneEtfn5a UAka8oAggOnnbugDBD2ZfshujS28F41Eu5D4hAbg= Date: Wed, 3 Nov 2021 10:46:24 +0100 From: Greg KH To: Yang Shi Cc: naoya.horiguchi@nec.com, hughd@google.com, kirill.shutemov@linux.intel.com, willy@infradead.org, osalvador@suse.de, peterx@redhat.com, akpm@linux-foundation.org, stable@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [stable 5.10 PATCH] mm: hwpoison: remove the unnecessary THP check Message-ID: References: <20211101194856.305642-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211101194856.305642-1-shy828301@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 01, 2021 at 12:48:56PM -0700, Yang Shi wrote: > commit c7cb42e94473aafe553c0f2a3d8ca904599399ed upstream. > > When handling THP hwpoison checked if the THP is in allocation or free > stage since hwpoison may mistreat it as hugetlb page. After commit > 415c64c1453a ("mm/memory-failure: split thp earlier in memory error > handling") the problem has been fixed, so this check is no longer > needed. Remove it. The side effect of the removal is hwpoison may > report unsplit THP instead of unknown error for shmem THP. It seems not > like a big deal. > > The following patch "mm: filemap: check if THP has hwpoisoned subpage > for PMD page fault" depends on this, which fixes shmem THP with > hwpoisoned subpage(s) are mapped PMD wrongly. So this patch needs to be > backported to -stable as well. > > Link: https://lkml.kernel.org/r/20211020210755.23964-2-shy828301@gmail.com > Signed-off-by: Yang Shi > Suggested-by: Naoya Horiguchi > Acked-by: Naoya Horiguchi > Cc: Hugh Dickins > Cc: Kirill A. Shutemov > Cc: Matthew Wilcox > Cc: Oscar Salvador > Cc: Peter Xu > Cc: > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds > --- > mm-filemap-check-if-thp-has-hwpoisoned-subpage-for-pmd-page-fault.patch > depends on this one. Both now queued up, thanks. greg k-h