Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= <clement.leger@bootlin.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 1/6] net: ocelot: add support to get port mac from
 device-tree
Thread-Topic: [PATCH v2 1/6] net: ocelot: add support to get port mac from
 device-tree
Thread-Index: AQHX0JQL0SfN3NCuTUafOx0abL6ZS6vxmVgA
Date:   Wed, 3 Nov 2021 10:26:25 +0000
Message-ID: <20211103102624.uujlwyhzq2t572o3@skbuf>
References: <20211103091943.3878621-1-clement.leger@bootlin.com>
 <20211103091943.3878621-2-clement.leger@bootlin.com>
In-Reply-To: <20211103091943.3878621-2-clement.leger@bootlin.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?wmTKMTsgbEiyDgrqt/Yh3oLIkWBf6RS7K5GGShE/fYqDQtPOsgk0spXwcw?=
 =?iso-8859-1?Q?1YA6tonlzLIvIYDcl0NKg4ZINUWMN93w93a03yfAbb2oJjtTRLB3xujaMK?=
 =?iso-8859-1?Q?mxCi4MdhME2W5BqUDpgeoxeA/DDqlBFKYY+ou7akIySm7/0qsRg8/8f54V?=
 =?iso-8859-1?Q?0nxptz05MZrt5Y75TPUTlAjd/lVNDFMeC+kMcjE4P6LD3FeETEYrLL3UO5?=
 =?iso-8859-1?Q?a41ClBRpEm1N1QjmAymxsZho0QTD0n26lQLgUwwzE4o0VS4usOW1i+cBs4?=
 =?iso-8859-1?Q?isdi9CclpXkoQ0MO2GqKU4ktN+wLylOosNj6vTjE64+KVZ1kYY6P4+TCy1?=
 =?iso-8859-1?Q?vtCOW9s4WAPYaZRKYP2EV2TFml6J+icbSgxfyUWyn/RmeFNZmCdU8MShSQ?=
 =?iso-8859-1?Q?tiSeviGC3YoZ9/QSAJC9G47yRkvngA9ytioOEZq1yB4WIfEdTBUPWzjmrA?=
 =?iso-8859-1?Q?w/YveDQcIBxgGAIhK7L60JnensvapHvn5yJR+SFcBEJsby015tIyQeUTd/?=
 =?iso-8859-1?Q?ik0G/+oeObXVC60BmLAjbR+xCzSJSPU0h2um2AU7yaEbj2J7kESCcbmzUa?=
 =?iso-8859-1?Q?kpbo7XwvopQwaNCQyF8rIOCOXKTsUdKfNt/W5ECYBs3F9oigCRXAHoNAkf?=
 =?iso-8859-1?Q?O0Nw5erIgO5QecQYqIZP51+SJLHBUUf61GC6rARTWklxpBg/ar8oHmV7Qn?=
 =?iso-8859-1?Q?8OGgDzWSOF8S6NouICl73Loax+vEkrIbEctjfaPUt+F18A4owg5HOD3cXQ?=
 =?iso-8859-1?Q?6znc281tFRLxn0Otj0v/XqmKNvjDe+kX2GB7yL1kPTrCKFNkGJv88/iMYp?=
 =?iso-8859-1?Q?terl8edv2QDCq8SfVaoAH+mhZT5cZtTCmS4h7rTrOtx7OaFmwZ8XK4aPif?=
 =?iso-8859-1?Q?qUxUbzLKrrZaBiBOElLJIZMuWRzdtpZbDjYplg9Y78cOAQKP/pBspr2ktk?=
 =?iso-8859-1?Q?/Yor2HMUxLLlfHiEd8zuNFT8LIW1W/gqNahXtsQ0qoSiiG04LYUOfePsNf?=
 =?iso-8859-1?Q?+Ue3Jlg3rGtKl/2xLaACbXmF6cB1CSNKMm6ZOR0lUA5masohwIQB7UeZGQ?=
 =?iso-8859-1?Q?pwHPXLIqquzMZymjGQ63uEGGu+p0t+hY5qgvBYUWvQ9PJyn7Hj0Jzbob4a?=
 =?iso-8859-1?Q?PWrJ+GyL/j23PT6DH9wJAM0iizDd1m+zSPikmclDL4ZzrnF6w4cDIdXXH+?=
 =?iso-8859-1?Q?Z0uOL4Z1/a86ux26jU4U1Nukha0WZSd0ObRfO4fAXaapnnVI2XA+UHj3iT?=
 =?iso-8859-1?Q?b6VW0Zl9HO0W5ZhhgAJPeol+S6q7S7LrOrBucmeH4OMfKOZ9Wq3kw9VXoi?=
 =?iso-8859-1?Q?6niRr/cdyJKTnkfKS2kseHx1MhQfpBLzqSdB453L9GOtBISKAGUuv5pY/w?=
 =?iso-8859-1?Q?1QA9U49r1mtzW63I/LgazkwVutedcIzyfuMJKNHic/58CFtRPCTWtNKlNv?=
 =?iso-8859-1?Q?1UnLMl1C9uIQz7mWVZbUCcEzWsKS6pmHjkRrAaAzIaUtxePYqYbwpjPeOr?=
 =?iso-8859-1?Q?dQYUiclVunJpNoAbG3oo+6DAQ0b9pMMzYVLsbYSX2LDtgZLSJvnO96F3qu?=
 =?iso-8859-1?Q?gGp3+SzzoGlD6W9nzbVm3vMu2j/f8+/cMDnRwKLNMmccL28FmkgFfhDQRa?=
 =?iso-8859-1?Q?SPugE7AJYgiJ/SBWHIQ2YSlTJjJgab7+5ACoYENjGqMCleM+guTjR552VA?=
 =?iso-8859-1?Q?hNyyv4mVmF3jMu9yqKg=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <518BF9C9D917C147B10223BD2B86F6C1@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5676875b-2e98-4b82-f2b7-08d99eb463f8
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2021 10:26:25.6558
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8unISCMJojtCDG7tzoCWvtzdACpPz9v3hU3WQPqqMaalwtxJ8vxXmZx4MrWLkvaFXWtjCwqG5R2im+fHo4mtjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4432
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 03, 2021 at 10:19:38AM +0100, Cl=E9ment L=E9ger wrote:
> Add support to get mac from device-tree using of_get_mac_address.
>=20
> Signed-off-by: Cl=E9ment L=E9ger <clement.leger@bootlin.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

>  drivers/net/ethernet/mscc/ocelot_net.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/mscc/ocelot_net.c b/drivers/net/etherne=
t/mscc/ocelot_net.c
> index eaeba60b1bba..d76def435b23 100644
> --- a/drivers/net/ethernet/mscc/ocelot_net.c
> +++ b/drivers/net/ethernet/mscc/ocelot_net.c
> @@ -1704,7 +1704,10 @@ int ocelot_probe_port(struct ocelot *ocelot, int p=
ort, struct regmap *target,
>  		NETIF_F_HW_TC;
>  	dev->features |=3D NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_HW_TC;
> =20
> -	eth_hw_addr_gen(dev, ocelot->base_mac, port);
> +	err =3D of_get_mac_address(portnp, dev->dev_addr);
> +	if (err)
> +		eth_hw_addr_gen(dev, ocelot->base_mac, port);
> +
>  	ocelot_mact_learn(ocelot, PGID_CPU, dev->dev_addr,
>  			  OCELOT_VLAN_UNAWARE_PVID, ENTRYTYPE_LOCKED);
> =20
> --=20
> 2.33.0
>=