Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Nov 2021 13:48:54 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     Stefan Wahren <stefan.wahren@i2se.com>,
        Kushal-kothari <kushalkothari285@gmail.com>,
        linux-arm-kernel@lists.infradead.org, mike.rapoport@gmail.com,
        kushalkothari2850@gmail.com, outreachy-kernel@googlegroups.com,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev, nsaenz@kernel.org,
        bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v2] staging: vc04_services: replace msleep() by
 usleep_range()
Message-ID: <20211103104854.GO2794@kadam>
References: <20211017092900.134752-1-kushalkothari285@gmail.com>
 <83076fd7-3183-5665-a9df-63a0b7e13c3f@i2se.com>
 <alpine.DEB.2.22.394.2110171433141.3026@hadrien>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2110171433141.3026@hadrien>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m/NhsOsPSo3bGrFx5vDY/kRgxsYjQBhzh3u1dsZZ6KZvaJVs33tM6Dnduri8?=
 =?us-ascii?Q?ZBM0V4kqAIaFz/SQ5Uo6vaOesoc+8gyDHOuJQOrep9x1lvra1oji3FYZhuFs?=
 =?us-ascii?Q?mFlqBYCHmT4MA8BjWLlbMuxhx7iNnoMW6IBjOcq62+hbBr9VHyKHRLnjwYlO?=
 =?us-ascii?Q?8RAvAC4qY5mrMgppTGwSaNxSErHTFQDai7orgqCmwBXfvi70Wzzu7+x5988j?=
 =?us-ascii?Q?2YjyvpqEo73jGzWxyKtKY5CiugOoO8ERTNG6gO1PfBdmEb/GB07FecEzkqZz?=
 =?us-ascii?Q?Sdo/hIJzBwq7OgFqyG/nyCAMIAJIpU5g/Ai54/Cc15jz3kCSG8x5SDktDhXD?=
 =?us-ascii?Q?XfD0elpis2l16/gSMJgn5nz5WUmvDkBEsh7fvoV/wwGHviwK22xha5pSwNmd?=
 =?us-ascii?Q?SMgAdb/7uBQ17MNPTSZIUI10nn2tDX3ab+tTCJqbRlCezs8un7FqfZdjhjYE?=
 =?us-ascii?Q?a9am0Qpw0Krl6E+a5LsYpowT4W4/vx1LZqcaqJHTgZJuwBKGrngi4ZYypLhM?=
 =?us-ascii?Q?p/48DBHFns2tPD1QYO0j9zfiHNkgWzl4xcrsieLOxh9vtBmTgnQqflMjE7uU?=
 =?us-ascii?Q?Sik/Uq5JalvRphXgkevv+bcE4eRdPDGsyUiLwk2+kIJyKOMdih0gfxCQ6iKV?=
 =?us-ascii?Q?3hluTSsGLfJj6RYHsZWQGB4KH3tH7Q9z6UjA2uClRta/XTvmts+K+/IsnB+H?=
 =?us-ascii?Q?T4NglGmwXt5GEPZ47p7s/d89qFlZyBipFX8dy/VrDChJ/sLJm4cH5X9GVwK2?=
 =?us-ascii?Q?m96CU6mp6Mglp8wUfiPIGMVf20r/UkzclFEItsNkHlWasdz8tqC+hrGuvLAe?=
 =?us-ascii?Q?6k7p+SVxlAMQ3DQ2lkz2amsKL/RPCRdqtE6PnPWYNSxK2UogM5ruF/78UHZF?=
 =?us-ascii?Q?FtBqes/zU09Nw9LrXJOdItUDaT1+0jY8S0TmGbn7MugoJLYAdfiKoOe5lZM2?=
 =?us-ascii?Q?bHiM6a7Ji+HIznYdGJ8XCogIY0dzsJPIpU3xMI0IEp4xMsBscB8BMLj9q1qJ?=
 =?us-ascii?Q?QELOVtWUzB1YQh3AYfJX4KXrMFFjKOqJvWoNfKtik8aosn0ApiDLRaqE2WEs?=
 =?us-ascii?Q?Br1tjBG8qs08wNqH8aN32DV1QEUmK3UnxeZ5F75/N/AV5k5FcPNqkK9ztLdY?=
 =?us-ascii?Q?FzCfttCSpFsKhb15gVWjz2IkWXGzBELeZnwcnytKt8Sd9itZIMQLaz56vESN?=
 =?us-ascii?Q?NlHaZdQ2RDpyxnLQCAYHrQDEioqNN1CgJZ10aX928NJh1K5HRPVeXRNPXuh4?=
 =?us-ascii?Q?OeERfgtpmEHuK/t6TGajHTr1nKSjsd4zatmirskx3f76c+1nFdPOe5Gc3raq?=
 =?us-ascii?Q?EAb7QP6WT9bBOOea6n7K44k/7bXsPs8xF5Y+vNXUikfJNg+sXZJebhhsxHvf?=
 =?us-ascii?Q?mza+TgyzvaGoaYycfSbNwImNHxl57gL9dQgr7YJ7zsQx+AovTp8pXocgmFid?=
 =?us-ascii?Q?j+VmLKLfvE4FJE62JCksJH8hiQ07aCSmgeDQVbHMRZTor9+yGKRfUQcYZ6Ag?=
 =?us-ascii?Q?0CEXAtIZEG2AsC2yPc1yNughlEfX2xdZRINeZDzxu89GbVe41hWGBla9QucI?=
 =?us-ascii?Q?SvbempGk7GBht3kxHJsGyZpZbGe1n+Wxq+VRjqIGTRfHeahbdGuLKsA8Erz1?=
 =?us-ascii?Q?eV0P9gBDy07KAy552otUPoszIa9f1EnjzyL2rLPJ5+od959TkueLdCVYFTm6?=
 =?us-ascii?Q?/bbH7A=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f52bcc53-8bc1-4654-fb54-08d99eb79232
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 10:49:12.3261
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rZ/7HxZndfEWGYOxHkSp9u8tevxzBTIHauVNYsFOdyCTzgLYfurZuMKhww64hkMKxqtQ/FXCbB8OmIBfirOSHJv2+RvzIrpmvH4y6gep4F0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2127
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10156 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0
 malwarescore=0 mlxlogscore=999 adultscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111030061
X-Proofpoint-ORIG-GUID: kxsBo0HpiC4P2seiMjNDwhATSgj5mAmK
X-Proofpoint-GUID: kxsBo0HpiC4P2seiMjNDwhATSgj5mAmK
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Oct 17, 2021 at 02:33:57PM +0200, Julia Lawall wrote:
> 
> 
> On Sun, 17 Oct 2021, Stefan Wahren wrote:
> 
> > Hi,
> >
> > Am 17.10.21 um 11:29 schrieb Kushal-kothari:
> > > Fixed the warning:-msleep < 20ms can sleep for up to 20ms by replacing
> > > msleep(unsigned long msecs) by usleep_range(unsigned long min, unsigned long max)
> > > in usecs as msleep(1ms~20ms) can sleep for upto 20 ms.
> > >
> > > Signed-off-by: Kushal-kothari <kushalkothari285@gmail.com>
> > > ---
> > >
> > > Changes from v1: Reword both the subject and the log message.
> > >
> > >  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > > index 6fbafdfe340f..80a7898c5331 100644
> > > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > > @@ -857,7 +857,7 @@ vchiq_bulk_transmit(unsigned int handle, const void *data, unsigned int size,
> > >  		if (status != VCHIQ_RETRY)
> > >  			break;
> > >
> > > -		msleep(1);
> > > +		usleep_range(1000, 2000);
> >
> > there was a recent discussion about this checkpatch warning [1]
> 
> Should there be a comment about it?

Even better would be an alternate wrapper around usleep(1) which would
silence the checkpatch warning.  Something like:

#define short_sleep() usleep(1)

regards,
dan carpenter