Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Nov 2021 13:46:05 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, yang.lee@linux.alibaba.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: Fix WCD_MBHC_HPH_PA_EN usage
Message-ID: <20211103104605.GN2794@kadam>
References: <988948f7f266aa00698704687537335b7e6a67b2.1634455711.git.christophe.jaillet@wanadoo.fr>
 <3ff34912-19e6-4d52-e9da-0e78ceb1d2ff@linaro.org>
 <c01b6669-d0f7-aab5-3aca-02f19be8a319@wanadoo.fr>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c01b6669-d0f7-aab5-3aca-02f19be8a319@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?Q9yoWAN1/er9fVFuMjVXYM8S5o0zwBlIPtsqsOX09KnIETVaDTrvDmUyva?=
 =?iso-8859-1?Q?ATbIC13kR4KKzBdueNtQZjVolzV9CCrU59ao9XBtKfN13HgUuYUOxcI9Fe?=
 =?iso-8859-1?Q?RH7bMT9pO+CrfQj1VY3Zeh/LrxFyeMncBADuNBQQMVTxKFTNWAIBC4a2h8?=
 =?iso-8859-1?Q?sHp23w09R/kW1IIavuJZGkJjSydbyzrzhabshzwxkQpAPjx139k2L1VIuW?=
 =?iso-8859-1?Q?tX1vBJC1YtyjXCQeRBpW2YSXgRjMtiP05+Bh6VgJ07vE/n8/C5Ntdu0yw2?=
 =?iso-8859-1?Q?1S7YIzuyV6vbELbGxiuUYoSltm5Fh1//owq+biZQ/recZy662UM6MnrfV5?=
 =?iso-8859-1?Q?Il01KHV03xST/sIhThKVxQTHC3pu3XAgF0EnuagKd+yXG+5dWuga4KMcSA?=
 =?iso-8859-1?Q?/UG88ubHkLSbJ4c66crSmzRVUPyMwt3qa1WGhcwWz+VShgHe0nDnZM53qO?=
 =?iso-8859-1?Q?kUTwA3AIQjr6g9DHWtjTCRHpwtay3D6QZZMsiwvahxog2rF3Gx88g+4f8g?=
 =?iso-8859-1?Q?adqu5uuye2yoD3CL93mpMLWGsfr9ehVsSz39zPH8AffDp7ilETBib4UbVa?=
 =?iso-8859-1?Q?mxZo6J7gbv9lWhkZWtwKKq6iRDskrM0bDMaXth6FWD/WXQw/A2cZQHU2tI?=
 =?iso-8859-1?Q?NnmhlUcARfdA5V8qZRSdVXDIQAgsxu09YcO7iOEkDTR4oQOdJ2KVV07PAk?=
 =?iso-8859-1?Q?j3x0CWCrOXfqcaNV2jAhjbPOxY8E8UGZaQRhjQ1QmCd+6vNmBQnQp3LHA1?=
 =?iso-8859-1?Q?My1Q33Hsy0VXrhaJOlXonVi4kdMLrz7c2QOVtTzcLEhIj9OsumoWkanGry?=
 =?iso-8859-1?Q?9K5MbZYfiHRrRLf3JD3mNyMxjsd0VbAK8Rdh7/PL9QiFtAwq+NIsGuBRJ8?=
 =?iso-8859-1?Q?UrT4xU2XLeVRVJ6+KGHmKr/OtlBDqiqmhzCjnKxJ7JZgNyx7h9Q5FkhjjH?=
 =?iso-8859-1?Q?41ueiCMmnDhuL61ORccaXJGf7DRrCpfO0cM6lPc0SovbdbR5NhUCtoKFz9?=
 =?iso-8859-1?Q?u8rRqLHNIu96zHiH6s76ZJouYCT+e2zCj/vGPDmEWYJztqZRzdEG1GY4SE?=
 =?iso-8859-1?Q?XjGOatWEbeq/l6lWNKtNXZJjiM0QCaaS/Cjcy6josFUd7hnH1nkUDVHbk+?=
 =?iso-8859-1?Q?DIV74zjDyuBPvrPpUX+ORp9/Ez91WsTqkISyDJYegnkGjWOVOX5y4ZqOtR?=
 =?iso-8859-1?Q?L43/Obe59CrYWMfFeP3LqMloROLY6zL6q1qaDNIRTJlXpCeZJ5mZEzRABI?=
 =?iso-8859-1?Q?EatH8oKm0seXNB79ZaiqwCgmnfMWlNM8Gw+RoOYoeD/kWgsQ7ddzWM5lL1?=
 =?iso-8859-1?Q?XbAdDbU4ov65u2pjZVdTMRkFqGsuR3mxrX2lbJsrYNvcnwXSohlVWU94vh?=
 =?iso-8859-1?Q?kqp7+1PDOlx3YS4PWoJUuV7aF1S2qKSZz1MwthVQubM/2Vafw2gbhOWdQ8?=
 =?iso-8859-1?Q?HutLLh1UvvaUCWtuESy74UgW+fz3whYw0xAEZfVgF/uf88TTpXg2PhOu2i?=
 =?iso-8859-1?Q?zeZsfdkeTfwLyMLTNvoeGgYLTlkwveSeXrx0YQGRUIvDL41T2y2C2c//9k?=
 =?iso-8859-1?Q?1Mvg5yAU5sOn49emZ+4/w5qCVMByLc7o50HqwpsCCNYAT2vjC1hJi9+kLP?=
 =?iso-8859-1?Q?Usg5iGk/22oP3Ju7uQyJduFiVh5ZkJbhuxcl9+TRlSnm9x0vNQwHH5iZVQ?=
 =?iso-8859-1?Q?S9UvLTnmfvgJ2xts6BG1U9xZj1/5Lph9GHU+K4ObchgxzRVJftv1eXejLh?=
 =?iso-8859-1?Q?rchw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 820637b8-17ae-462d-62df-08d99eb72da9
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 10:46:23.3244
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gG19bG5/nVOLQTJEFR5uI5IDwvyOOzy+V4ZGYg3Hh3k4zysJumPdD2/cpcRtNNOnH/dkiXRgt1cfqauCtds7aXkqX+soqUUI5AoKlu1Jttk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1824
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10156 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0
 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=999
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2111030061
X-Proofpoint-ORIG-GUID: 4aIo4VcmqMhqApv8TORVDSrIG96forhw
X-Proofpoint-GUID: 4aIo4VcmqMhqApv8TORVDSrIG96forhw
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 19, 2021 at 07:39:04PM +0200, Christophe JAILLET wrote:
> Le 19/10/2021 ? 15:47, Srinivas Kandagatla a ?crit?:
> > 
> > 
> > On 17/10/2021 08:31, Christophe JAILLET wrote:
> > > 'hphpa_on' is known to be false, so the if block at the end of the
> > > function
> > > is dead code.
> > 
> > Yes, this is a dead code we should remove it.
> 
> Ok, thanks for the clarification.
> 
> > 
> > This code was part of moisture detection logic which is not enabled in
> > upstream code yet.
> 
> If 'yet' is the important word of the sentence, maybe the best is to leave
> the code as-is.
> If you prefer it to be removed, I can send a patch if it helps.

Just delete the dead code...  Never try to plan for the future, it's too
unpredictable.

regards,
dasn carpenter