Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6bd3ff4c-c2df-5cc8-bdc5-22bc37c0cb9e@redhat.com>
Date:   Wed, 3 Nov 2021 12:21:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 2/5] drm: Move nomodeset kernel parameter handler to the
 DRM subsystem
Content-Language: en-US
To:     Neal Gompa <ngompa13@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Pekka Paalanen <pekka.paalanen@collabora.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Peter Robinson <pbrobinson@gmail.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel@daenzer.net>
References: <20211103104812.1022936-1-javierm@redhat.com>
 <20211103104812.1022936-3-javierm@redhat.com>
 <CAEg-Je_3n9vFpP-vmVzkbDZY154g3xOK5JqPN7r9kGXJ1Zp0+w@mail.gmail.com>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <CAEg-Je_3n9vFpP-vmVzkbDZY154g3xOK5JqPN7r9kGXJ1Zp0+w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Neal,

On 11/3/21 12:05, Neal Gompa wrote:
> On Wed, Nov 3, 2021 at 6:48 AM Javier Martinez Canillas
> <javierm@redhat.com> wrote:
>>
>> The "nomodeset" kernel cmdline parameter is handled by the vgacon driver
>> but the exported vgacon_text_force() symbol is only used by DRM drivers.
>>
>> It makes much more sense for the parameter logic to be in the subsystem
>> of the drivers that are making use of it. Let's move that to DRM.
>>
>> Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>> ---
> 
> Please no, I'd much rather have a better, more meaningful option
> instead of "nomodeset". If anything, I would like this option to
> eventually do nothing and replace it with a better named option that's
> namespaced by drm on the command-line. That was part of the feedback I
> gave in the original patch set, and I still stand by that.
> 

I do agree with you that a more meaningful parameter would be desirable.

But I think that's orthogonal to this series and something that could be
done as a follow-up. That is, nomodeset isn't going away anytime soon as
that's what users are get to.

This doesn't mean that a drm.disable_native_drivers, drm.safe_mode or
whatever could be added. Internally it would also toggle the same value
but it will be much more clear to users what's the expected behaviour.

By having a module parameter under the drm namespace, it would also allow
to change this from user-space through a sysfs entry. Something that's not
currently possible for the "nomodeset" paramter.

Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat